From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/ Date: Fri, 04 Apr 2014 09:18:43 -0700 Message-ID: <533EDB63.8090909@intel.com> References: <1396592835-24767-1-git-send-email-maddy@linux.vnet.ibm.com> <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" To: Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org Cc: riel@redhat.com, ak@linux.intel.com, peterz@infradead.org, rusty@rustcorp.com.au, paulus@samba.org, mgorman@suse.de, akpm@linux-foundation.org, mingo@kernel.org, kirill.shutemov@linux.intel.com List-Id: linux-arch.vger.kernel.org T24gMDQvMDMvMjAxNCAxMToyNyBQTSwgTWFkaGF2YW4gU3Jpbml2YXNhbiB3cm90ZToKPiBUaGlz IHBhdGNoIGNyZWF0ZXMgaW5mcmFzdHJ1Y3R1cmUgdG8gbW92ZSB0aGUgRkFVTFRfQVJPVU5EX09S REVSCj4gdG8gYXJjaC8gdXNpbmcgS2NvbmZpZy4gVGhpcyB3aWxsIGVuYWJsZSBhcmNoaXRlY3R1 cmUgbWFpbnRhaW5lcnMKPiB0byBkZWNpZGUgb24gc3VpdGFibGUgRkFVTFRfQVJPVU5EX09SREVS IHZhbHVlIGJhc2VkIG9uCj4gcGVyZm9ybWFuY2UgZGF0YSBmb3IgdGhhdCBhcmNoaXRlY3R1cmUu IFBhdGNoIGFsc28gYWRkcwo+IEZBVUxUX0FST1VORF9PUkRFUiBLY29uZmlnIGVsZW1lbnQgaW4g YXJjaC9YODYuCgpQbGVhc2UgZG9uJ3QgZG8gaXQgdGhpcyB3YXkuCgpJbiBtbS9LY29uZmlnLCBw dXQKCgljb25maWcgRkFVTFRfQVJPVU5EX09SREVSCgkJaW50CgkJZGVmYXVsdCAxMjM0IGlmIFBP V0VSUEMKCQlkZWZhdWx0IDQKClRoZSB3YXkgeW91IGhhdmUgaXQgbm93LCBldmVyeSBzaW5nbGUg YXJjaGl0ZWN0dXJlIHRoYXQgbmVlZHMgdG8gZW5hYmxlCnRoaXMgaGFzIHRvIGdvIHB1dCB0aGF0 IGluIHRoZWlyIEtjb25maWcuICBUaGF0J3MgbWFkbmVzcy4gIFRoaXMgd2F5LAp5b3Ugb25seSBw dXQgaXQgaW4gb25lIHBsYWNlLCBhbmQgZm9sa3Mgb25seSBoYXZlIHRvIGNhcmUgaWYgdGhleSB3 YW50CnRvIGNoYW5nZSB0aGUgZGVmYXVsdCB0byBiZSBzb21ldGhpbmcgb3RoZXIgdGhhbiA0LgoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXhwcGMt ZGV2IG1haWxpbmcgbGlzdApMaW51eHBwYy1kZXZAbGlzdHMub3psYWJzLm9yZwpodHRwczovL2xp c3RzLm96bGFicy5vcmcvbGlzdGluZm8vbGludXhwcGMtZGV2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:26490 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753259AbaDDQUM (ORCPT ); Fri, 4 Apr 2014 12:20:12 -0400 Message-ID: <533EDB63.8090909@intel.com> Date: Fri, 04 Apr 2014 09:18:43 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/ References: <1396592835-24767-1-git-send-email-maddy@linux.vnet.ibm.com> <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> In-Reply-To: <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Madhavan Srinivasan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org Cc: benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, peterz@infradead.org, mingo@kernel.org Message-ID: <20140404161843.eqmGiLpUXHSH3CoqWB0tFjB8_QoHoI86S8fgogXVycc@z> On 04/03/2014 11:27 PM, Madhavan Srinivasan wrote: > This patch creates infrastructure to move the FAULT_AROUND_ORDER > to arch/ using Kconfig. This will enable architecture maintainers > to decide on suitable FAULT_AROUND_ORDER value based on > performance data for that architecture. Patch also adds > FAULT_AROUND_ORDER Kconfig element in arch/X86. Please don't do it this way. In mm/Kconfig, put config FAULT_AROUND_ORDER int default 1234 if POWERPC default 4 The way you have it now, every single architecture that needs to enable this has to go put that in their Kconfig. That's madness. This way, you only put it in one place, and folks only have to care if they want to change the default to be something other than 4.