From mboxrd@z Thu Jan 1 00:00:00 1970 From: Madhavan Srinivasan Subject: Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/ Date: Thu, 10 Apr 2014 13:59:29 +0530 Message-ID: <53465669.80701@linux.vnet.ibm.com> References: <1396592835-24767-1-git-send-email-maddy@linux.vnet.ibm.com> <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> <533EDB63.8090909@intel.com> <5344A312.80802@linux.vnet.ibm.com> <20140409082008.GA10526@twins.programming.kicks-ass.net> <53456BE2.90905@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53456BE2.90905@intel.com> Sender: owner-linux-mm@kvack.org To: Dave Hansen , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, mingo@kernel.org List-Id: linux-arch.vger.kernel.org On Wednesday 09 April 2014 09:18 PM, Dave Hansen wrote: > On 04/09/2014 01:20 AM, Peter Zijlstra wrote: >> This still misses out on Ben's objection that its impossible to get this >> right at compile time for many kernels, since they can boot and run on >> many different subarchs. > > Completely agree. The Kconfig-time stuff should probably just be a knob > to turn it off completely, if anything. > ok. Here is my thought. So to address Ben's concern, it would be better to have this as a variable with a default value (and the platform can override ride it). And a mm/Kconfig to disable it? Kindly let me know whether this will work. Thanks for review comments. With regards Maddy -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from e28smtp08.in.ibm.com ([122.248.162.8]:57195 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965066AbaDJI3j (ORCPT ); Thu, 10 Apr 2014 04:29:39 -0400 Received: from /spool/local by e28smtp08.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 10 Apr 2014 13:59:36 +0530 Message-ID: <53465669.80701@linux.vnet.ibm.com> Date: Thu, 10 Apr 2014 13:59:29 +0530 From: Madhavan Srinivasan MIME-Version: 1.0 Subject: Re: [PATCH V2 1/2] mm: move FAULT_AROUND_ORDER to arch/ References: <1396592835-24767-1-git-send-email-maddy@linux.vnet.ibm.com> <1396592835-24767-2-git-send-email-maddy@linux.vnet.ibm.com> <533EDB63.8090909@intel.com> <5344A312.80802@linux.vnet.ibm.com> <20140409082008.GA10526@twins.programming.kicks-ass.net> <53456BE2.90905@intel.com> In-Reply-To: <53456BE2.90905@intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Hansen , Peter Zijlstra Cc: linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, x86@kernel.org, benh@kernel.crashing.org, paulus@samba.org, kirill.shutemov@linux.intel.com, rusty@rustcorp.com.au, akpm@linux-foundation.org, riel@redhat.com, mgorman@suse.de, ak@linux.intel.com, mingo@kernel.org Message-ID: <20140410082929.Qwv_1LnuMbHD_44TUwCodcc3C8Bv4FFB9uXSdgFhGa8@z> On Wednesday 09 April 2014 09:18 PM, Dave Hansen wrote: > On 04/09/2014 01:20 AM, Peter Zijlstra wrote: >> This still misses out on Ben's objection that its impossible to get this >> right at compile time for many kernels, since they can boot and run on >> many different subarchs. > > Completely agree. The Kconfig-time stuff should probably just be a knob > to turn it off completely, if anything. > ok. Here is my thought. So to address Ben's concern, it would be better to have this as a variable with a default value (and the platform can override ride it). And a mm/Kconfig to disable it? Kindly let me know whether this will work. Thanks for review comments. With regards Maddy