From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS Date: Thu, 17 Apr 2014 17:29:26 -0400 Message-ID: <535047B6.6000404@hp.com> References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-6-git-send-email-Waiman.Long@hp.com> <20140417155002.GP11096@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140417155002.GP11096@twins.programming.kicks-ass.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Peter Zijlstra Cc: linux-arch@vger.kernel.org, Rik van Riel , Raghavendra K T , Gleb Natapov , kvm@vger.kernel.org, Konrad Rzeszutek Wilk , Scott J Norton , x86@kernel.org, Paolo Bonzini , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Chegu Vinod , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , "Paul E. McKenney" , Linus Torvalds , Oleg Nesterov List-Id: linux-arch.vger.kernel.org On 04/17/2014 11:50 AM, Peter Zijlstra wrote: > On Thu, Apr 17, 2014 at 11:03:57AM -0400, Waiman Long wrote: >> +#if !defined(__LITTLE_ENDIAN)&& !defined(__BIG_ENDIAN) >> +#error "Missing either LITTLE_ENDIAN or BIG_ENDIAN definition." >> +#endif > This seems entirely superfluous, I don't think a kernel build will go > anywhere if either is missing. Yes, I am on the conservative side when I add that. I can certainly take it out if you think that is not needed. -Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g6t1526.atlanta.hp.com ([15.193.200.69]:20763 "EHLO g6t1526.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751001AbaDQV3a (ORCPT ); Thu, 17 Apr 2014 17:29:30 -0400 Message-ID: <535047B6.6000404@hp.com> Date: Thu, 17 Apr 2014 17:29:26 -0400 From: Waiman Long MIME-Version: 1.0 Subject: Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-6-git-send-email-Waiman.Long@hp.com> <20140417155002.GP11096@twins.programming.kicks-ass.net> In-Reply-To: <20140417155002.GP11096@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Paolo Bonzini , Konrad Rzeszutek Wilk , "Paul E. McKenney" , Rik van Riel , Linus Torvalds , Raghavendra K T , David Vrabel , Oleg Nesterov , Gleb Natapov , Scott J Norton , Chegu Vinod Message-ID: <20140417212926.241L9ti_b4VC8_acS4Nymkg6esM6bllxzlXwIG-v10k@z> On 04/17/2014 11:50 AM, Peter Zijlstra wrote: > On Thu, Apr 17, 2014 at 11:03:57AM -0400, Waiman Long wrote: >> +#if !defined(__LITTLE_ENDIAN)&& !defined(__BIG_ENDIAN) >> +#error "Missing either LITTLE_ENDIAN or BIG_ENDIAN definition." >> +#endif > This seems entirely superfluous, I don't think a kernel build will go > anywhere if either is missing. Yes, I am on the conservative side when I add that. I can certainly take it out if you think that is not needed. -Longman