From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v9 03/19] qspinlock: Add pending bit Date: Fri, 18 Apr 2014 14:12:52 -0400 Message-ID: <53516B24.3060108@hp.com> References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-4-git-send-email-Waiman.Long@hp.com> <20140418074255.GA13517@gmail.com> <53515181.8090303@hp.com> <20140418163543.GA6208@phenom.dumpdata.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140418163543.GA6208@phenom.dumpdata.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Konrad Rzeszutek Wilk Cc: linux-arch@vger.kernel.org, Rik van Riel , Raghavendra K T , Gleb Natapov , kvm@vger.kernel.org, Oleg Nesterov , Peter Zijlstra , Scott J Norton , x86@kernel.org, Paolo Bonzini , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Chegu Vinod , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , "Paul E. McKenney" , Linus Torvalds , Ingo Molnar List-Id: linux-arch.vger.kernel.org On 04/18/2014 12:35 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 18, 2014 at 12:23:29PM -0400, Waiman Long wrote: >> On 04/18/2014 03:42 AM, Ingo Molnar wrote: >>> * Waiman Long wrote: >>> >>>> Because the qspinlock needs to touch a second cacheline; add a pending >>>> bit and allow a single in-word spinner before we punt to the second >>>> cacheline. >>>> >>>> Signed-off-by: Peter Zijlstra >>>> Signed-off-by: Waiman Long >>> This patch should have a "From: Peter" in it as well, right? >>> >>> Thanks, >>> >>> Ingo >> Do you mean a "From:" line in the mail header? It will be a bit hard >> to have different "From:" header in the same patch series. I can >> certainly do that if there is an easy way to do it. > It is pretty easy. > > Just do 'git commit --amend --author "The Right Author"' and when > you send the patches (git send-email) it will include that. Thank for the tip. I will do that in the next version. -Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3426.houston.hp.com ([15.201.208.54]:4215 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752055AbaDRSNL (ORCPT ); Fri, 18 Apr 2014 14:13:11 -0400 Message-ID: <53516B24.3060108@hp.com> Date: Fri, 18 Apr 2014 14:12:52 -0400 From: Waiman Long MIME-Version: 1.0 Subject: Re: [PATCH v9 03/19] qspinlock: Add pending bit References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-4-git-send-email-Waiman.Long@hp.com> <20140418074255.GA13517@gmail.com> <53515181.8090303@hp.com> <20140418163543.GA6208@phenom.dumpdata.com> In-Reply-To: <20140418163543.GA6208@phenom.dumpdata.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Konrad Rzeszutek Wilk Cc: Ingo Molnar , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Paolo Bonzini , "Paul E. McKenney" , Rik van Riel , Linus Torvalds , Raghavendra K T , David Vrabel , Oleg Nesterov , Gleb Natapov , Scott J Norton , Chegu Vinod Message-ID: <20140418181252.zJ-I7SKKXGMqwJN4Rxv3ofYC_RN8W7A4OWfMGWqkWlc@z> On 04/18/2014 12:35 PM, Konrad Rzeszutek Wilk wrote: > On Fri, Apr 18, 2014 at 12:23:29PM -0400, Waiman Long wrote: >> On 04/18/2014 03:42 AM, Ingo Molnar wrote: >>> * Waiman Long wrote: >>> >>>> Because the qspinlock needs to touch a second cacheline; add a pending >>>> bit and allow a single in-word spinner before we punt to the second >>>> cacheline. >>>> >>>> Signed-off-by: Peter Zijlstra >>>> Signed-off-by: Waiman Long >>> This patch should have a "From: Peter" in it as well, right? >>> >>> Thanks, >>> >>> Ingo >> Do you mean a "From:" line in the mail header? It will be a bit hard >> to have different "From:" header in the same patch series. I can >> certainly do that if there is an easy way to do it. > It is pretty easy. > > Just do 'git commit --amend --author "The Right Author"' and when > you send the patches (git send-email) it will include that. Thank for the tip. I will do that in the next version. -Longman