From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS Date: Fri, 18 Apr 2014 17:40:15 -0400 Message-ID: <53519BBF.7060506@hp.com> References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-6-git-send-email-Waiman.Long@hp.com> <20140417155649.GR11096@twins.programming.kicks-ass.net> <53504BB3.4010009@hp.com> <20140418082716.GZ11096@twins.programming.kicks-ass.net> <53516672.3010701@hp.com> <20140418190519.GA11182@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140418190519.GA11182@twins.programming.kicks-ass.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Peter Zijlstra Cc: linux-arch@vger.kernel.org, Rik van Riel , Raghavendra K T , Gleb Natapov , kvm@vger.kernel.org, Konrad Rzeszutek Wilk , Scott J Norton , x86@kernel.org, Paolo Bonzini , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Chegu Vinod , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , "Paul E. McKenney" , Linus Torvalds , Oleg Nesterov List-Id: linux-arch.vger.kernel.org On 04/18/2014 03:05 PM, Peter Zijlstra wrote: > On Fri, Apr 18, 2014 at 01:52:50PM -0400, Waiman Long wrote: >> I am confused by your notation. > Nah, I think I was confused :-) Make the 1 _Q_LOCKED_VAL though, as > that's the proper constant to use. Everyone gets confused once in a while:-) I have plenty of that myself. I will change 1 to _Q_LOCKED_VAL as suggested. -Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g4t3426.houston.hp.com ([15.201.208.54]:16710 "EHLO g4t3426.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754684AbaDRVkg (ORCPT ); Fri, 18 Apr 2014 17:40:36 -0400 Message-ID: <53519BBF.7060506@hp.com> Date: Fri, 18 Apr 2014 17:40:15 -0400 From: Waiman Long MIME-Version: 1.0 Subject: Re: [PATCH v9 05/19] qspinlock: Optimize for smaller NR_CPUS References: <1397747051-15401-1-git-send-email-Waiman.Long@hp.com> <1397747051-15401-6-git-send-email-Waiman.Long@hp.com> <20140417155649.GR11096@twins.programming.kicks-ass.net> <53504BB3.4010009@hp.com> <20140418082716.GZ11096@twins.programming.kicks-ass.net> <53516672.3010701@hp.com> <20140418190519.GA11182@twins.programming.kicks-ass.net> In-Reply-To: <20140418190519.GA11182@twins.programming.kicks-ass.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Paolo Bonzini , Konrad Rzeszutek Wilk , "Paul E. McKenney" , Rik van Riel , Linus Torvalds , Raghavendra K T , David Vrabel , Oleg Nesterov , Gleb Natapov , Scott J Norton , Chegu Vinod Message-ID: <20140418214015.r9txD72wcAHA1kuQtMfU3XOPS3IrQEMyXaWnn20bNRw@z> On 04/18/2014 03:05 PM, Peter Zijlstra wrote: > On Fri, Apr 18, 2014 at 01:52:50PM -0400, Waiman Long wrote: >> I am confused by your notation. > Nah, I think I was confused :-) Make the 1 _Q_LOCKED_VAL though, as > that's the proper constant to use. Everyone gets confused once in a while:-) I have plenty of that myself. I will change 1 to _Q_LOCKED_VAL as suggested. -Longman