From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chung-Lin Tang Subject: Re: [PATCH 06/28] nios2: Memory management Date: Wed, 23 Apr 2014 00:01:18 +0800 Message-ID: <5356924E.7020605@codesourcery.com> References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397824031-4892-5-git-send-email-lftan@altera.com> <20140422142443.GB15745@arch.cereza> <20140422151458.GC1053@distanz.ch> <20140422153522.GF15745@arch.cereza> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20140422153522.GF15745@arch.cereza> Sender: linux-kernel-owner@vger.kernel.org To: Ezequiel Garcia , Tobias Klauser Cc: Ley Foon Tan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, lftan.linux@gmail.com List-Id: linux-arch.vger.kernel.org On 2014/4/22 =E4=B8=8B=E5=8D=88 11:35, Ezequiel Garcia wrote: > On Apr 22, Tobias Klauser wrote: >> On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia wrote: >>> Hi Ley Foon, >>> >>> On Apr 18, Ley Foon Tan wrote: >>>> +/* >>>> + * PAGE_SHIFT determines the page size >>>> + */ >>>> +#define PAGE_SHIFT 12 >>>> +#define PAGE_SIZE 4096 >>>> +#define PAGE_MASK (~(PAGE_SIZE - 1)) >>>> + >>> >>> How about something like this: >>> >>> /* PAGE_SHIFT determines the page size */ >>> #define PAGE_SHIFT 12 >>> #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) >>> #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) >>> >>> Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC. >> >> AFAIR old nios2 GCC versions (the 4.1 version from Windriver, IIRC) >> would complain about something like the above, that's the reason I a= dded >> an explicit value for PAGE_SIZE back then. >> >=20 > Other than being "pretty" the above fix is to remove a mismatch type > warning. You can get rid of the warning in different ways: >=20 > ifdef __ASSEMBLY__ > define PAGE_SIZE 4096 > else > define PAGE_SIZE 4096UL > endif >=20 >> I assume with the new nios2 GCC this should no longer be necessary a= nd >> Ezequiel's fix should be fine. >=20 > Speaking of GCC... is there a libc available to test this kernel port= ? > (which I assume uses the generic syscall ABI) It's submitted to libc-alpha, also still review in progress. Chung-Lin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relay1.mentorg.com ([192.94.38.131]:38548 "EHLO relay1.mentorg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756902AbaDVQBa (ORCPT ); Tue, 22 Apr 2014 12:01:30 -0400 Message-ID: <5356924E.7020605@codesourcery.com> Date: Wed, 23 Apr 2014 00:01:18 +0800 From: Chung-Lin Tang MIME-Version: 1.0 Subject: Re: [PATCH 06/28] nios2: Memory management References: <1397824031-4892-1-git-send-email-lftan@altera.com> <1397824031-4892-5-git-send-email-lftan@altera.com> <20140422142443.GB15745@arch.cereza> <20140422151458.GC1053@distanz.ch> <20140422153522.GF15745@arch.cereza> In-Reply-To: <20140422153522.GF15745@arch.cereza> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ezequiel Garcia , Tobias Klauser Cc: Ley Foon Tan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, lftan.linux@gmail.com Message-ID: <20140422160118.N4Wfz1q3ijlifsqWPgTWcj3zBEYa5kA02ufaplZXbeI@z> On 2014/4/22 下午 11:35, Ezequiel Garcia wrote: > On Apr 22, Tobias Klauser wrote: >> On 2014-04-22 at 16:24:43 +0200, Ezequiel Garcia wrote: >>> Hi Ley Foon, >>> >>> On Apr 18, Ley Foon Tan wrote: >>>> +/* >>>> + * PAGE_SHIFT determines the page size >>>> + */ >>>> +#define PAGE_SHIFT 12 >>>> +#define PAGE_SIZE 4096 >>>> +#define PAGE_MASK (~(PAGE_SIZE - 1)) >>>> + >>> >>> How about something like this: >>> >>> /* PAGE_SHIFT determines the page size */ >>> #define PAGE_SHIFT 12 >>> #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) >>> #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) >>> >>> Otherwise, the PAGE_SIZE macro above produces some warnings, IIRC. >> >> AFAIR old nios2 GCC versions (the 4.1 version from Windriver, IIRC) >> would complain about something like the above, that's the reason I added >> an explicit value for PAGE_SIZE back then. >> > > Other than being "pretty" the above fix is to remove a mismatch type > warning. You can get rid of the warning in different ways: > > ifdef __ASSEMBLY__ > define PAGE_SIZE 4096 > else > define PAGE_SIZE 4096UL > endif > >> I assume with the new nios2 GCC this should no longer be necessary and >> Ezequiel's fix should be fine. > > Speaking of GCC... is there a libc available to test this kernel port? > (which I assume uses the generic syscall ABI) It's submitted to libc-alpha, also still review in progress. Chung-Lin