From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Hansen Subject: Re: Dirty/Access bits vs. page content Date: Fri, 25 Apr 2014 09:30:52 -0700 Message-ID: <535A8DBC.4010202@intel.com> References: <53558507.9050703@zytor.com> <53559F48.8040808@intel.com> <20140422075459.GD11182@twins.programming.kicks-ass.net> <20140423184145.GH17824@quack.suse.cz> <20140424065133.GX26782@laptop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: owner-linux-mm@kvack.org To: Linus Torvalds , Hugh Dickins Cc: Peter Zijlstra , Jan Kara , "H. Peter Anvin" , Benjamin Herrenschmidt , "linux-arch@vger.kernel.org" , linux-mm , Russell King - ARM Linux , Tony Luck List-Id: linux-arch.vger.kernel.org On 04/24/2014 04:46 PM, Linus Torvalds wrote: > IOW, how about the attached patch that entirely replaces my previous > two patches. DaveH - does this fix your test-case, while _not_ > introducing any new BUG_ON() triggers? > > I didn't test the patch, maybe I did something stupid. It compiles for > me, but it only works for the HAVE_GENERIC_MMU_GATHER case, but > introducing tlb_flush_mmu_tlbonly() and tlb_flush_mmu_free() into the > non-generic cases should be trivial, since they really are just that > old "tlb_flush_mmu()" function split up (the tlb_flush_mmu() function > remains available for other non-forced flush users) > > So assuming this does work for DaveH, then the arm/ia64/um/whatever > people would need to do those trivial transforms too, but it really > shouldn't be too painful. It looks happy on both my debugging kernel (which was triggering it before) and the one without lockdep and all the things that normally slow it down and change timing. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com ([134.134.136.20]:42069 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753890AbaDYQa4 (ORCPT ); Fri, 25 Apr 2014 12:30:56 -0400 Message-ID: <535A8DBC.4010202@intel.com> Date: Fri, 25 Apr 2014 09:30:52 -0700 From: Dave Hansen MIME-Version: 1.0 Subject: Re: Dirty/Access bits vs. page content References: <53558507.9050703@zytor.com> <53559F48.8040808@intel.com> <20140422075459.GD11182@twins.programming.kicks-ass.net> <20140423184145.GH17824@quack.suse.cz> <20140424065133.GX26782@laptop.programming.kicks-ass.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Linus Torvalds , Hugh Dickins Cc: Peter Zijlstra , Jan Kara , "H. Peter Anvin" , Benjamin Herrenschmidt , "linux-arch@vger.kernel.org" , linux-mm , Russell King - ARM Linux , Tony Luck Message-ID: <20140425163052.GDNMaFb3wOUp_Zyy1S1sbioZLPJFYP9FZ-8QuraY3zA@z> On 04/24/2014 04:46 PM, Linus Torvalds wrote: > IOW, how about the attached patch that entirely replaces my previous > two patches. DaveH - does this fix your test-case, while _not_ > introducing any new BUG_ON() triggers? > > I didn't test the patch, maybe I did something stupid. It compiles for > me, but it only works for the HAVE_GENERIC_MMU_GATHER case, but > introducing tlb_flush_mmu_tlbonly() and tlb_flush_mmu_free() into the > non-generic cases should be trivial, since they really are just that > old "tlb_flush_mmu()" function split up (the tlb_flush_mmu() function > remains available for other non-forced flush users) > > So assuming this does work for DaveH, then the arm/ia64/um/whatever > people would need to do those trivial transforms too, but it really > shouldn't be too painful. It looks happy on both my debugging kernel (which was triggering it before) and the one without lockdep and all the things that normally slow it down and change timing.