From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [PATCH v10 08/19] qspinlock: Make a new qnode structure to support virtualization Date: Fri, 09 May 2014 21:08:56 -0400 Message-ID: <536D7C28.8010609@hp.com> References: <1399474907-22206-1-git-send-email-Waiman.Long@hp.com> <1399474907-22206-9-git-send-email-Waiman.Long@hp.com> <20140508190459.GQ2844@laptop.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140508190459.GQ2844@laptop.programming.kicks-ass.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: Peter Zijlstra Cc: linux-arch@vger.kernel.org, Rik van Riel , Raghavendra K T , Oleg Nesterov , Gleb Natapov , kvm@vger.kernel.org, Konrad Rzeszutek Wilk , Scott J Norton , x86@kernel.org, Paolo Bonzini , linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Ingo Molnar , Chegu Vinod , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Thomas Gleixner , "Paul E. McKenney" , Linus Torvalds , Boris Ostrovsky List-Id: linux-arch.vger.kernel.org On 05/08/2014 03:04 PM, Peter Zijlstra wrote: > On Wed, May 07, 2014 at 11:01:36AM -0400, Waiman Long wrote: >> /* >> + * To have additional features for better virtualization support, it is >> + * necessary to store additional data in the queue node structure. So >> + * a new queue node structure will have to be defined and used here. >> + */ >> +struct qnode { >> + struct mcs_spinlock mcs; >> +}; > You can ditch this entire patch; its pointless, just add a new > DEFINE_PER_CPU for the para-virt muck. Yes, I can certainly merge it to the next one in the series. I break it out to make each individual patch smaller, more single-purpose and easier to review. -Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g6t1526.atlanta.hp.com ([15.193.200.69]:58980 "EHLO g6t1526.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756541AbaEJBJS (ORCPT ); Fri, 9 May 2014 21:09:18 -0400 Message-ID: <536D7C28.8010609@hp.com> Date: Fri, 09 May 2014 21:08:56 -0400 From: Waiman Long MIME-Version: 1.0 Subject: Re: [PATCH v10 08/19] qspinlock: Make a new qnode structure to support virtualization References: <1399474907-22206-1-git-send-email-Waiman.Long@hp.com> <1399474907-22206-9-git-send-email-Waiman.Long@hp.com> <20140508190459.GQ2844@laptop.programming.kicks-ass.net> In-Reply-To: <20140508190459.GQ2844@laptop.programming.kicks-ass.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , linux-arch@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, kvm@vger.kernel.org, Paolo Bonzini , Konrad Rzeszutek Wilk , Boris Ostrovsky , "Paul E. McKenney" , Rik van Riel , Linus Torvalds , Raghavendra K T , David Vrabel , Oleg Nesterov , Gleb Natapov , Scott J Norton , Chegu Vinod Message-ID: <20140510010856.-qCVbU0R8NeAJKdyC_OPrno2ADtS3vXltk-uf9NH7FA@z> On 05/08/2014 03:04 PM, Peter Zijlstra wrote: > On Wed, May 07, 2014 at 11:01:36AM -0400, Waiman Long wrote: >> /* >> + * To have additional features for better virtualization support, it is >> + * necessary to store additional data in the queue node structure. So >> + * a new queue node structure will have to be defined and used here. >> + */ >> +struct qnode { >> + struct mcs_spinlock mcs; >> +}; > You can ditch this entire patch; its pointless, just add a new > DEFINE_PER_CPU for the para-virt muck. Yes, I can certainly merge it to the next one in the series. I break it out to make each individual patch smaller, more single-purpose and easier to review. -Longman