From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h Date: Wed, 14 May 2014 22:57:50 +0200 Message-ID: <5373D8CE.6090003@nod.at> References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-14-git-send-email-richard@nod.at> <5373C36E.3020900@nod.at> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-m68k-owner@vger.kernel.org To: Geert Uytterhoeven Cc: Linux-Arch , Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-m68k List-Id: linux-arch.vger.kernel.org Am 14.05.2014 21:34, schrieb Geert Uytterhoeven: > Hi Richard, > > On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger wrote: >>> But why this sudden #ifdef checks? >> >> They are needed because in pgalloc.h you have: >> #ifdef CONFIG_MMU >> #include >> #if defined(CONFIG_COLDFIRE) >> #include >> #elif defined(CONFIG_SUN3) >> #include >> #else >> #include >> #endif >> >> And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. >> Therefore we need to define them such that the generic tlb.h versions will not clash >> with yours. > > Thanks for the clarification! One problem which arises here is that me need to make sure that pgalloc.h is included before tlb.h. Which kind of sucks. I'll move __pte/pmd_free_tlb from *_pgalloc.h into tlb.h to prevent this issue. Are you fine with that? > Perhaps this deserves a comment: > > /* Applies to Classic m68k MMU only */ Will add. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751221AbaENU5y (ORCPT ); Wed, 14 May 2014 16:57:54 -0400 Message-ID: <5373D8CE.6090003@nod.at> Date: Wed, 14 May 2014 22:57:50 +0200 From: Richard Weinberger MIME-Version: 1.0 Subject: Re: [PATCH 13/27] m68k: Use common bits from generic tlb.h References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-14-git-send-email-richard@nod.at> <5373C36E.3020900@nod.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: Linux-Arch , Arnd Bergmann , "linux-kernel@vger.kernel.org" , linux-m68k Message-ID: <20140514205750.atzKf15vVtp8EygJBlw4-YN_CtcZA0b2cFKvHYQe8Do@z> Am 14.05.2014 21:34, schrieb Geert Uytterhoeven: > Hi Richard, > > On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger wrote: >>> But why this sudden #ifdef checks? >> >> They are needed because in pgalloc.h you have: >> #ifdef CONFIG_MMU >> #include >> #if defined(CONFIG_COLDFIRE) >> #include >> #elif defined(CONFIG_SUN3) >> #include >> #else >> #include >> #endif >> >> And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. >> Therefore we need to define them such that the generic tlb.h versions will not clash >> with yours. > > Thanks for the clarification! One problem which arises here is that me need to make sure that pgalloc.h is included before tlb.h. Which kind of sucks. I'll move __pte/pmd_free_tlb from *_pgalloc.h into tlb.h to prevent this issue. Are you fine with that? > Perhaps this deserves a comment: > > /* Applies to Classic m68k MMU only */ Will add. Thanks, //richard