From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Weinberger Subject: Re: [PATCH 16/27] mips: Use common bits from generic tlb.h Date: Thu, 15 May 2014 20:31:04 +0200 Message-ID: <537507E8.1010600@nod.at> References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-17-git-send-email-richard@nod.at> <53750129.6060902@imgtec.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <53750129.6060902@imgtec.com> Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Leonid Yegoshin Cc: linux-arch@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, Ralf Baechle , John Crispin , Markos Chandras , linux-mips@linux-mips.org List-Id: linux-arch.vger.kernel.org Am 15.05.2014 20:02, schrieb Leonid Yegoshin: > On 05/14/2014 11:59 AM, Richard Weinberger wrote: >> It is no longer needed to define them on our own. >> >> Cc: Ralf Baechle >> Cc: John Crispin >> Cc: Markos Chandras >> Cc: Leonid Yegoshin >> Cc: Richard Weinberger >> Cc: linux-mips@linux-mips.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Richard Weinberger >> --- >> arch/mips/include/asm/tlb.h | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/arch/mips/include/asm/tlb.h b/arch/mips/include/asm/tlb.h >> index 4a23493..5ea43ca 100644 >> --- a/arch/mips/include/asm/tlb.h >> +++ b/arch/mips/include/asm/tlb.h >> @@ -10,13 +10,6 @@ >> if (!tlb->fullmm) \ >> flush_cache_range(vma, vma->vm_start, vma->vm_end); \ >> } while (0) >> -#define tlb_end_vma(tlb, vma) do { } while (0) >> -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) >> - >> -/* >> - * .. because we flush the whole mm when it fills up. >> - */ >> -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) >> #define UNIQUE_ENTRYHI(idx) \ >> ((CKSEG0 + ((idx) << (PAGE_SHIFT + 1))) | \ > > I would like to know why these functions are eliminated (don't find any clue). > Is it just because there will be a generic one or the calls would be eliminated? There will be a generic one. See [PATCH 03/27] generic/tlb.h: Move common defines into generic tlb.h > And if there are generic - can I tune it later? Yes. You can always define your own and override the generic one. Thanks, //richard From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from b.ns.miles-group.at ([95.130.255.144]:1660 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755387AbaEOSbH (ORCPT ); Thu, 15 May 2014 14:31:07 -0400 Message-ID: <537507E8.1010600@nod.at> Date: Thu, 15 May 2014 20:31:04 +0200 From: Richard Weinberger MIME-Version: 1.0 Subject: Re: [PATCH 16/27] mips: Use common bits from generic tlb.h References: <1400093999-18703-1-git-send-email-richard@nod.at> <1400093999-18703-17-git-send-email-richard@nod.at> <53750129.6060902@imgtec.com> In-Reply-To: <53750129.6060902@imgtec.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Leonid Yegoshin Cc: linux-arch@vger.kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org, Ralf Baechle , John Crispin , Markos Chandras , linux-mips@linux-mips.org Message-ID: <20140515183104.cre3MsL3NC5ItIQ6yQF1FFvmSd_Zy43SvUX0sZj8AOM@z> Am 15.05.2014 20:02, schrieb Leonid Yegoshin: > On 05/14/2014 11:59 AM, Richard Weinberger wrote: >> It is no longer needed to define them on our own. >> >> Cc: Ralf Baechle >> Cc: John Crispin >> Cc: Markos Chandras >> Cc: Leonid Yegoshin >> Cc: Richard Weinberger >> Cc: linux-mips@linux-mips.org >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Richard Weinberger >> --- >> arch/mips/include/asm/tlb.h | 7 ------- >> 1 file changed, 7 deletions(-) >> >> diff --git a/arch/mips/include/asm/tlb.h b/arch/mips/include/asm/tlb.h >> index 4a23493..5ea43ca 100644 >> --- a/arch/mips/include/asm/tlb.h >> +++ b/arch/mips/include/asm/tlb.h >> @@ -10,13 +10,6 @@ >> if (!tlb->fullmm) \ >> flush_cache_range(vma, vma->vm_start, vma->vm_end); \ >> } while (0) >> -#define tlb_end_vma(tlb, vma) do { } while (0) >> -#define __tlb_remove_tlb_entry(tlb, ptep, address) do { } while (0) >> - >> -/* >> - * .. because we flush the whole mm when it fills up. >> - */ >> -#define tlb_flush(tlb) flush_tlb_mm((tlb)->mm) >> #define UNIQUE_ENTRYHI(idx) \ >> ((CKSEG0 + ((idx) << (PAGE_SHIFT + 1))) | \ > > I would like to know why these functions are eliminated (don't find any clue). > Is it just because there will be a generic one or the calls would be eliminated? There will be a generic one. See [PATCH 03/27] generic/tlb.h: Move common defines into generic tlb.h > And if there are generic - can I tune it later? Yes. You can always define your own and override the generic one. Thanks, //richard