From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Hogan Subject: Re: [RFA][PATCH 07/27] MIPS: ftrace: Add call to ftrace_graph_is_dead() in function graph code Date: Wed, 9 Jul 2014 16:48:32 +0100 Message-ID: <53BD6450.50103@imgtec.com> References: <20140626165221.736847419@goodmis.org> <20140626165849.321719498@goodmis.org> <20140702103138.01880b1d@gandalf.local.home> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from mailapp01.imgtec.com ([195.59.15.196]:5897 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755924AbaGIPuS (ORCPT ); Wed, 9 Jul 2014 11:50:18 -0400 In-Reply-To: <20140702103138.01880b1d@gandalf.local.home> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Steven Rostedt , linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Thomas Gleixner , Masami Hiramatsu , "H. Peter Anvin" , linux-arch@vger.kernel.org, "Rafael J. Wysocki" , Jiri Kosina , Josh Poimboeuf , Ralf Baechle Hi Steven, I've given this a quick test on a mips32 le target, on your rfc/remove-function-trace-stop branch (4161daee7df8). Booted fine, startup tests fine, function and function_graph trace appear to work from a quick cat of the trace file. Feel free to add my Tested-by: Tested-by: James Hogan [MIPS] Cheers James On 02/07/14 15:31, Steven Rostedt wrote: > > Adding linux-mips@linux-mips.org. > > -- Steve > > > On Thu, 26 Jun 2014 12:52:28 -0400 > Steven Rostedt wrote: > >> From: "Steven Rostedt (Red Hat)" >> >> ftrace_stop() is going away as it disables parts of function tracing >> that affects users that should not be affected. But ftrace_graph_stop() >> is built on ftrace_stop(). Here's another example of killing all of >> function tracing because something went wrong with function graph >> tracing. >> >> Instead of disabling all users of function tracing on function graph >> error, disable only function graph tracing. To do this, the arch code >> must call ftrace_graph_is_dead() before it implements function graph. >> >> Cc: Ralf Baechle >> Signed-off-by: Steven Rostedt >> --- >> arch/mips/kernel/ftrace.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/mips/kernel/ftrace.c b/arch/mips/kernel/ftrace.c >> index 60e7e5e45af1..8b6538750fe1 100644 >> --- a/arch/mips/kernel/ftrace.c >> +++ b/arch/mips/kernel/ftrace.c >> @@ -302,6 +302,9 @@ void prepare_ftrace_return(unsigned long *parent_ra_addr, unsigned long self_ra, >> &return_to_handler; >> int faulted, insns; >> >> + if (unlikely(ftrace_graph_is_dead())) >> + return; >> + >> if (unlikely(atomic_read(¤t->tracing_graph_pause))) >> return; >> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-arch" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >