From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Marek Subject: Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly Date: Fri, 22 Aug 2014 13:09:17 +0200 Message-ID: <53F724DD.1080605@suse.cz> References: <53EA99C3.90203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kbuild-owner@vger.kernel.org To: Geert Uytterhoeven , Chen Gang Cc: Arnd Bergmann , Andrew Morton , Jean Delvare , Russell King , Catalin Marinas , Will Deacon , Mark Salter , "a-jacquiot@ti.com" , Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , "linux-arm-kernel@lists.infradead.org" , linux-c6x-dev@linux-c6x.org, "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-Arch , linux-kbuild List-Id: linux-arch.vger.kernel.org Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): > CC kbuild > > On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index c49a775..0510a5d 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >> config ARCH_SUPPORTS_UPROBES >> def_bool y >> >> +config CPU_LITTLE_ENDIAN >> + depends on !CPU_BIG_ENDIAN >> + def_bool y >> + >> + >> config ARCH_HAS_DMA_SET_COHERENT_MASK >> bool > > As this is a common symbol, and replicated for all affected architectures, > I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in > common Kconfig code instead, and make the individual architectures do a > "select CPU_LITTLE_ENDIAN"? Yes! > Also we could have "config CPU_BIG_ENDIAN", too, and error out > if none or both are selected (can Kconfig error out?). We can error out in the Makefile, if there is consensus that we should be doing so. Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cantor2.suse.de ([195.135.220.15]:57063 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbaHVLJX (ORCPT ); Fri, 22 Aug 2014 07:09:23 -0400 Message-ID: <53F724DD.1080605@suse.cz> Date: Fri, 22 Aug 2014 13:09:17 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH v2] arch: Kconfig: Let all little endian architectures define CPU_LITTLE_ENDIAN explicitly References: <53EA99C3.90203@gmail.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven , Chen Gang Cc: Arnd Bergmann , Andrew Morton , Jean Delvare , Russell King , Catalin Marinas , Will Deacon , Mark Salter , "a-jacquiot@ti.com" , Tony Luck , Fenghua Yu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , the arch/x86 maintainers , "linux-arm-kernel@lists.infradead.org" , linux-c6x-dev@linux-c6x.org, "linux-ia64@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Linux-Arch , linux-kbuild Message-ID: <20140822110917.Vzd5cvda__h4-8yvvPQ_UPu33qT0RfQtTKK2wgjGADY@z> Dne 13.8.2014 10:03, Geert Uytterhoeven napsal(a): > CC kbuild > > On Wed, Aug 13, 2014 at 12:48 AM, Chen Gang wrote: >> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >> index c49a775..0510a5d 100644 >> --- a/arch/arm/Kconfig >> +++ b/arch/arm/Kconfig >> @@ -199,6 +199,11 @@ config NEED_DMA_MAP_STATE >> config ARCH_SUPPORTS_UPROBES >> def_bool y >> >> +config CPU_LITTLE_ENDIAN >> + depends on !CPU_BIG_ENDIAN >> + def_bool y >> + >> + >> config ARCH_HAS_DMA_SET_COHERENT_MASK >> bool > > As this is a common symbol, and replicated for all affected architectures, > I'm wondering if we should have the "config CPU_LITTLE_ENDIAN" in > common Kconfig code instead, and make the individual architectures do a > "select CPU_LITTLE_ENDIAN"? Yes! > Also we could have "config CPU_BIG_ENDIAN", too, and error out > if none or both are selected (can Kconfig error out?). We can error out in the Makefile, if there is consensus that we should be doing so. Michal