From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Vrabel Subject: Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq() Date: Thu, 11 Sep 2014 14:08:34 +0100 Message-ID: <54119ED2.3070802@citrix.com> References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-5-git-send-email-wangyijing@huawei.com> <541045BE.9050804@citrix.com> <5410F955.80609@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <5410F955.80609-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Yijing Wang , David Vrabel , Bjorn Helgaas Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org, linux-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Xinwei Hu , sparclinux-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-s390-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel-GuqFBffKawtpuQazS67q72D2FQJk+8+b@public.gmane.org, arnab.basu-KZfg59tc24xl57MIdRCFDg@public.gmane.org, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Tony Luck , Ralf Baechle , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Wuyun , linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, "David S. Miller" List-Id: linux-arch.vger.kernel.org On 11/09/14 02:22, Yijing Wang wrote: > On 2014/9/10 20:36, David Vrabel wrote: >> On 05/09/14 11:09, Yijing Wang wrote: >>> Commit 0e4ccb150 added two __weak arch functions arch_msix_mask_irq() >>> and arch_msi_mask_irq() to fix a bug found when running xen in x86. >>> Introduced these two funcntions make MSI code complex. And mask/unmask >>> is the irq actions related to interrupt controller, should not use >>> weak arch functions to override mask/unmask interfaces. This patch >>> reverted commit 0e4ccb150 and export struct irq_chip msi_chip, modify >>> msi_chip->irq_mask/irq_unmask() in xen init functions to fix this >>> bug for simplicity. Also this is preparation for using struct >>> msi_chip instead of weak arch MSI functions in all platforms. >> >> Acked-by: David Vrabel >> >> But I wonder if it would be better the Xen subsystem to provide its own >> struct irq_chip instead of adjusting the fields in the generic x86 one. > > Thanks! Currently, Xen and the bare x86 system only have the different irq_chip->irq_mask/irq_unmask. > So I chose to override the two ops of bare x86 irq_chip in xen. Konrad Rzeszutek Wilk has been tested it > ok in his platform, so I think we could use its own irq_chip for xen later if the difference become large. This sounds reasonable. David From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp02.citrix.com ([66.165.176.63]:33179 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756645AbaIKNJ4 (ORCPT ); Thu, 11 Sep 2014 09:09:56 -0400 Message-ID: <54119ED2.3070802@citrix.com> Date: Thu, 11 Sep 2014 14:08:34 +0100 From: David Vrabel MIME-Version: 1.0 Subject: Re: [Xen-devel] [PATCH v1 04/21] x86/xen/MSI: Eliminate arch_msix_mask_irq() and arch_msi_mask_irq() References: <1409911806-10519-1-git-send-email-wangyijing@huawei.com> <1409911806-10519-5-git-send-email-wangyijing@huawei.com> <541045BE.9050804@citrix.com> <5410F955.80609@huawei.com> In-Reply-To: <5410F955.80609@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yijing Wang , David Vrabel , Bjorn Helgaas Cc: linux-mips@linux-mips.org, linux-ia64@vger.kernel.org, linux-pci@vger.kernel.org, Xinwei Hu , sparclinux@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, Russell King , Joerg Roedel , x86@kernel.org, Sebastian Ott , Benjamin Herrenschmidt , xen-devel@lists.xenproject.org, arnab.basu@freescale.com, Arnd Bergmann , Chris Metcalf , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Bharat.Bhushan@freescale.com, Tony Luck , Ralf Baechle , iommu@lists.linux-foundation.org, Wuyun , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Message-ID: <20140911130834.uHk0SDHbKvpfH0yDjq1LA_T1GqxCPscV_hnDTl6di24@z> On 11/09/14 02:22, Yijing Wang wrote: > On 2014/9/10 20:36, David Vrabel wrote: >> On 05/09/14 11:09, Yijing Wang wrote: >>> Commit 0e4ccb150 added two __weak arch functions arch_msix_mask_irq() >>> and arch_msi_mask_irq() to fix a bug found when running xen in x86. >>> Introduced these two funcntions make MSI code complex. And mask/unmask >>> is the irq actions related to interrupt controller, should not use >>> weak arch functions to override mask/unmask interfaces. This patch >>> reverted commit 0e4ccb150 and export struct irq_chip msi_chip, modify >>> msi_chip->irq_mask/irq_unmask() in xen init functions to fix this >>> bug for simplicity. Also this is preparation for using struct >>> msi_chip instead of weak arch MSI functions in all platforms. >> >> Acked-by: David Vrabel >> >> But I wonder if it would be better the Xen subsystem to provide its own >> struct irq_chip instead of adjusting the fields in the generic x86 one. > > Thanks! Currently, Xen and the bare x86 system only have the different irq_chip->irq_mask/irq_unmask. > So I chose to override the two ops of bare x86 irq_chip in xen. Konrad Rzeszutek Wilk has been tested it > ok in his platform, so I think we could use its own irq_chip for xen later if the difference become large. This sounds reasonable. David