From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v2 15/22] MIPS/Xlr/MSI: Use MSI chip framework to configure MSI/MSI-X irq Date: Fri, 26 Sep 2014 10:13:42 +0800 Message-ID: <5424CBD6.1010807@huawei.com> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-16-git-send-email-wangyijing@huawei.com> <20140925073700.GL12423@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140925073700.GL12423@ulmo> Sender: linux-ia64-owner@vger.kernel.org To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.ke List-Id: linux-arch.vger.kernel.org On 2014/9/25 15:37, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:25AM +0800, Yijing Wang wrote: > [...] >> diff --git a/arch/mips/pci/pci-xlr.c b/arch/mips/pci/pci-xlr.c > [...] >> @@ -214,11 +214,11 @@ static int get_irq_vector(const struct pci_dev *dev) >> } >> >> #ifdef CONFIG_PCI_MSI >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlr_teardown_msi_irq(unsigned int irq) >> { >> } >> >> -int arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) >> +int xlr_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) > > Can both of these now be static? Yes, Will update. > > Thierry > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga01-in.huawei.com ([119.145.14.64]:46963 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752792AbaIZCOC (ORCPT ); Thu, 25 Sep 2014 22:14:02 -0400 Message-ID: <5424CBD6.1010807@huawei.com> Date: Fri, 26 Sep 2014 10:13:42 +0800 From: Yijing Wang MIME-Version: 1.0 Subject: Re: [PATCH v2 15/22] MIPS/Xlr/MSI: Use MSI chip framework to configure MSI/MSI-X irq References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-16-git-send-email-wangyijing@huawei.com> <20140925073700.GL12423@ulmo> In-Reply-To: <20140925073700.GL12423@ulmo> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thierry Reding Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Thomas Gleixner , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thomas Petazzoni Message-ID: <20140926021342.W7LW8V6BwHBUJ232PyMxP7q2-Bg7Cw1KgH4Hms_7Cis@z> On 2014/9/25 15:37, Thierry Reding wrote: > On Thu, Sep 25, 2014 at 11:14:25AM +0800, Yijing Wang wrote: > [...] >> diff --git a/arch/mips/pci/pci-xlr.c b/arch/mips/pci/pci-xlr.c > [...] >> @@ -214,11 +214,11 @@ static int get_irq_vector(const struct pci_dev *dev) >> } >> >> #ifdef CONFIG_PCI_MSI >> -void arch_teardown_msi_irq(unsigned int irq) >> +void xlr_teardown_msi_irq(unsigned int irq) >> { >> } >> >> -int arch_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) >> +int xlr_setup_msi_irq(struct pci_dev *dev, struct msi_desc *desc) > > Can both of these now be static? Yes, Will update. > > Thierry > -- Thanks! Yijing