From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yijing Wang Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip Date: Sun, 28 Sep 2014 10:35:09 +0800 Message-ID: <542773DD.8020105@huawei.com> References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> <5424D30A.6040900@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-ia64-owner@vger.kernel.org To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf List-Id: linux-arch.vger.kernel.org >> MSI chip in this series is to setup MSI irq, including IRQ allocation, Map, >> compose MSI msg ..., in different platform, many arch specific MSI irq details in it. >> It's difficult to extract the common data and code. >> >> I have a plan to rework MSI related irq_chips in kernel, PCI and Non-PCI, currently, >> HPET, DMAR and PCI have their own irq_chip and MSI related functions, write_msi_msg(), >> mask_msi_irq(), etc... I want to extract the common data set for that, so we can >> remove lots of unnecessary MSI code. > > That makes sense. Can you please make sure that this does not conflict > with the ongoing work Jiang is doing in the x86 irq area with > hierarchical irqdomains to distangle layered levels like MSI from the > underlying vector/irqremap mechanics. Yes, I'm reviewing Jiang hierarchical irqdomains series, I'm interested in that changes. Thanks! Yijing. > > Thanks, > > tglx > > . > -- Thanks! Yijing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from szxga02-in.huawei.com ([119.145.14.65]:4943 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbaI1Cf4 (ORCPT ); Sat, 27 Sep 2014 22:35:56 -0400 Message-ID: <542773DD.8020105@huawei.com> Date: Sun, 28 Sep 2014 10:35:09 +0800 From: Yijing Wang MIME-Version: 1.0 Subject: Re: [PATCH v2 06/22] PCI/MSI: Introduce weak arch_find_msi_chip() to find MSI chip References: <1411614872-4009-1-git-send-email-wangyijing@huawei.com> <1411614872-4009-7-git-send-email-wangyijing@huawei.com> <5424D30A.6040900@huawei.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Thomas Gleixner Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Xinwei Hu , Wuyun , linux-arm-kernel@lists.infradead.org, Russell King , linux-arch@vger.kernel.org, arnab.basu@freescale.com, Bharat.Bhushan@freescale.com, x86@kernel.org, Arnd Bergmann , Konrad Rzeszutek Wilk , xen-devel@lists.xenproject.org, Joerg Roedel , iommu@lists.linux-foundation.org, linux-mips@linux-mips.org, Benjamin Herrenschmidt , linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, Sebastian Ott , Tony Luck , linux-ia64@vger.kernel.org, "David S. Miller" , sparclinux@vger.kernel.org, Chris Metcalf , Ralf Baechle , Lucas Stach , David Vrabel , Sergei Shtylyov , Michael Ellerman , Thierry Reding , Thomas Petazzoni Message-ID: <20140928023509.WW1PU9yIF1W5dIvfW8USmZwE13xV8dZSOxkHMlVEXIk@z> >> MSI chip in this series is to setup MSI irq, including IRQ allocation, Map, >> compose MSI msg ..., in different platform, many arch specific MSI irq details in it. >> It's difficult to extract the common data and code. >> >> I have a plan to rework MSI related irq_chips in kernel, PCI and Non-PCI, currently, >> HPET, DMAR and PCI have their own irq_chip and MSI related functions, write_msi_msg(), >> mask_msi_irq(), etc... I want to extract the common data set for that, so we can >> remove lots of unnecessary MSI code. > > That makes sense. Can you please make sure that this does not conflict > with the ongoing work Jiang is doing in the x86 irq area with > hierarchical irqdomains to distangle layered levels like MSI from the > underlying vector/irqremap mechanics. Yes, I'm reviewing Jiang hierarchical irqdomains series, I'm interested in that changes. Thanks! Yijing. > > Thanks, > > tglx > > . > -- Thanks! Yijing