Re: [PATCH v1 1/5] uaccess: add pagefault_count to thread_info

David Hildenbrand
2014-12-08T13:25:02Z

> Am 05.12.2014 um 12:18 schrieb David Hildenbrand:
> > This patch adds the pagefault_count to the thread_info of all
> > architectures. It will be used to count the pagefault_disable() levels
> > on a per-thread basis.
> >
> > We are not reusing the preempt_count as this is per cpu on x86 and we want to
> > demangle pagefault_disable() from preemption in the future.
> >
> > Signed-off-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> > ---
> > arch/alpha/include/asm/thread_info.h | 1 +
> > arch/arc/include/asm/thread_info.h | 1 +
> > arch/arm/include/asm/thread_info.h | 1 +
> > arch/arm64/include/asm/thread_info.h | 1 +
> > arch/avr32/include/asm/thread_info.h | 1 +
> > arch/blackfin/include/asm/thread_info.h | 1 +
> > arch/c6x/include/asm/thread_info.h | 1 +
> > arch/cris/include/asm/thread_info.h | 1 +
> > arch/frv/include/asm/thread_info.h | 1 +
> > arch/hexagon/include/asm/thread_info.h | 1 +
> > arch/ia64/include/asm/thread_info.h | 1 +
> > arch/m32r/include/asm/thread_info.h | 5 +++--
> > arch/m68k/include/asm/thread_info.h | 1 +
> > arch/metag/include/asm/thread_info.h | 1 +
> > arch/microblaze/include/asm/thread_info.h | 1 +
> > arch/mips/include/asm/thread_info.h | 1 +
> > arch/mn10300/include/asm/thread_info.h | 1 +
> > arch/openrisc/include/asm/thread_info.h | 1 +
> > arch/parisc/include/asm/thread_info.h | 1 +
> > arch/powerpc/include/asm/thread_info.h | 1 +
> > arch/s390/include/asm/thread_info.h | 1 +
> > arch/score/include/asm/thread_info.h | 1 +
> > arch/sh/include/asm/thread_info.h | 1 +
> > arch/sparc/include/asm/thread_info_32.h | 20 +++++++++++---------
> > arch/sparc/include/asm/thread_info_64.h | 17 +++++++++--------
>
> Maybe its easier to put the pagefault count at the end of the thread_info struct to make the patch smaller and easier to review for thoses architectures that have hand-maintained asm offsets?

Jap, that's also what I asked for in my cover letter.

Right now I wanted to keep the new count close to the preempt_count and similar
on all archs.

So move it only on the "hand-maintained asm offset" archs or on all archs?

David