From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chanwoo Choi Subject: Re: [PATCH v3 00/15] Add support to STMicroelectronics STM32 family Date: Thu, 19 Mar 2015 08:35:09 +0900 Message-ID: <550A0BAD.2000104@samsung.com> References: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> Sender: linux-gpio-owner@vger.kernel.org To: Maxime Coquelin Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl, Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo List-Id: linux-arch.vger.kernel.org Hi Maxime, I tested this patch-set on Linux 4.0-rc4 for STM32F429IDISCOVERY board. I completed the kernel booting successfully without any modification . Looks good to me for this patch-set. Tested-by: Chanwoo Choi Best Regards, Chanwoo Choi On 03/13/2015 06:55 AM, Maxime Coquelin wrote: > From: Maxime Coquelin > > This third round tries to address most of the comments made on previous series. > > It contains few less patches, as the reset_controller_of_init() patch has been > removed, now that the bootlaoder handles the reset of the timers. > > The pinctrl driver has also been removed after Linus review. > It will be reworked to use the generic pinconf bindings, and may contain > changes for other machines (Mediatek), to add support for pinmux property > handling directly in pinconf-generic. > > STM32 MCUs are Cortex-M CPU, used in various applications (consumer > electronics, industrial applications, hobbyists...). > Datasheets, user and programming manuals are publicly available on > STMicroelectronics website. > > With this series applied, the STM32F419 Discovery can boot succesfully. > > > Changes since v2: > ----------------- > - Remove pinctrl driver from the series. > - Remove reset_controller_of_init(), and reset the timers in the bootloader > - Add HW flow contrl property for serial driver > - Lots of changes in the DTS file, as per Andreas recommendations > - Some Kconfig clean-ups > - Adapt the config to be compatible with Andreas' bootwrapper, except UART port. > - Various fixes in documentation > > Changes since v1: > ----------------- > - Move bindings documentation in their own patches (Andreas) > - Rename ARM System timer to armv7m-systick (Rob) > - Add clock-frequency property handling in armv7m-systick (Rob) > - Re-factor the reset controllers into a single controller (Philipp) > - Add kerneldoc to reset_controller_of_init (Philipp) > - Add named constants in include/dt-bindings/reset/ (Philipp) > - Make pinctrl driver to depend on ARCH_STM32 or COMPILE_TEST (Geert) > - Introduce CPUV7M_NUM_IRQ config flag to indicate the number of interrupts > supported by the MCU, in order to limit memory waste in vectors' table (Uwe) > > > Maxime Coquelin (15): > scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP > Kernel > ARM: ARMv7-M: Enlarge vector table up to 256 entries > dt-bindings: Document the ARM System timer bindings > clocksource: Add ARM System timer driver > dt-bindings: Document the STM32 reset bindings > drivers: reset: Add STM32 reset driver > dt-bindings: Document the STM32 timer bindings > clockevent: Add STM32 Timer driver > dt-bindings: Document the STM32 USART bindings > serial: stm32-usart: Add STM32 USART Driver > ARM: Add STM32 family machine > ARM: dts: Add ARM System timer as clockevent in armv7m > ARM: dts: Introduce STM32F429 MCU > ARM: configs: Add STM32 defconfig > MAINTAINERS: Add entry for STM32 MCUs > > Documentation/arm/stm32/overview.txt | 32 + > Documentation/arm/stm32/stm32f429-overview.txt | 22 + > .../devicetree/bindings/arm/armv7m_systick.txt | 26 + > .../devicetree/bindings/reset/st,stm32-rcc.txt | 102 +++ > .../devicetree/bindings/serial/st,stm32-usart.txt | 32 + > .../devicetree/bindings/timer/st,stm32-timer.txt | 22 + > MAINTAINERS | 8 + > arch/arm/Kconfig | 18 + > arch/arm/Makefile | 1 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/armv7-m.dtsi | 6 + > arch/arm/boot/dts/stm32f429-disco.dts | 71 +++ > arch/arm/boot/dts/stm32f429.dtsi | 226 +++++++ > arch/arm/configs/stm32_defconfig | 71 +++ > arch/arm/kernel/entry-v7m.S | 13 +- > arch/arm/mach-stm32/Makefile | 1 + > arch/arm/mach-stm32/Makefile.boot | 3 + > arch/arm/mach-stm32/board-dt.c | 19 + > arch/arm/mm/Kconfig | 15 + > drivers/clocksource/Kconfig | 15 + > drivers/clocksource/Makefile | 2 + > drivers/clocksource/armv7m_systick.c | 78 +++ > drivers/clocksource/timer-stm32.c | 184 ++++++ > drivers/reset/Makefile | 1 + > drivers/reset/reset-stm32.c | 125 ++++ > drivers/tty/serial/Kconfig | 17 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/stm32-usart.c | 695 +++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > scripts/link-vmlinux.sh | 2 +- > 30 files changed, 1807 insertions(+), 5 deletions(-) > create mode 100644 Documentation/arm/stm32/overview.txt > create mode 100644 Documentation/arm/stm32/stm32f429-overview.txt > create mode 100644 Documentation/devicetree/bindings/arm/armv7m_systick.txt > create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-rcc.txt > create mode 100644 Documentation/devicetree/bindings/serial/st,stm32-usart.txt > create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-timer.txt > create mode 100644 arch/arm/boot/dts/stm32f429-disco.dts > create mode 100644 arch/arm/boot/dts/stm32f429.dtsi > create mode 100644 arch/arm/configs/stm32_defconfig > create mode 100644 arch/arm/mach-stm32/Makefile > create mode 100644 arch/arm/mach-stm32/Makefile.boot > create mode 100644 arch/arm/mach-stm32/board-dt.c > create mode 100644 drivers/clocksource/armv7m_systick.c > create mode 100644 drivers/clocksource/timer-stm32.c > create mode 100644 drivers/reset/reset-stm32.c > create mode 100644 drivers/tty/serial/stm32-usart.c > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.samsung.com ([203.254.224.24]:61064 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752053AbbCRXfO (ORCPT ); Wed, 18 Mar 2015 19:35:14 -0400 Message-ID: <550A0BAD.2000104@samsung.com> Date: Thu, 19 Mar 2015 08:35:09 +0900 From: Chanwoo Choi MIME-version: 1.0 Subject: Re: [PATCH v3 00/15] Add support to STMicroelectronics STM32 family References: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> In-reply-to: <1426197361-19290-1-git-send-email-maxime.coquelin@st.com> Content-type: text/plain; charset=UTF-8 Content-transfer-encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Maxime Coquelin Cc: u.kleine-koenig@pengutronix.de, afaerber@suse.de, geert@linux-m68k.org, Rob Herring , Philipp Zabel , Linus Walleij , Arnd Bergmann , stefan@agner.ch, pmeerw@pmeerw.net, pebolle@tiscali.nl, Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org Message-ID: <20150318233509.GjUC4VT4LrHfP9dHHkK1VLBhR2-OPRL1PSo07Xj6bOQ@z> Hi Maxime, I tested this patch-set on Linux 4.0-rc4 for STM32F429IDISCOVERY board. I completed the kernel booting successfully without any modification . Looks good to me for this patch-set. Tested-by: Chanwoo Choi Best Regards, Chanwoo Choi On 03/13/2015 06:55 AM, Maxime Coquelin wrote: > From: Maxime Coquelin > > This third round tries to address most of the comments made on previous series. > > It contains few less patches, as the reset_controller_of_init() patch has been > removed, now that the bootlaoder handles the reset of the timers. > > The pinctrl driver has also been removed after Linus review. > It will be reworked to use the generic pinconf bindings, and may contain > changes for other machines (Mediatek), to add support for pinmux property > handling directly in pinconf-generic. > > STM32 MCUs are Cortex-M CPU, used in various applications (consumer > electronics, industrial applications, hobbyists...). > Datasheets, user and programming manuals are publicly available on > STMicroelectronics website. > > With this series applied, the STM32F419 Discovery can boot succesfully. > > > Changes since v2: > ----------------- > - Remove pinctrl driver from the series. > - Remove reset_controller_of_init(), and reset the timers in the bootloader > - Add HW flow contrl property for serial driver > - Lots of changes in the DTS file, as per Andreas recommendations > - Some Kconfig clean-ups > - Adapt the config to be compatible with Andreas' bootwrapper, except UART port. > - Various fixes in documentation > > Changes since v1: > ----------------- > - Move bindings documentation in their own patches (Andreas) > - Rename ARM System timer to armv7m-systick (Rob) > - Add clock-frequency property handling in armv7m-systick (Rob) > - Re-factor the reset controllers into a single controller (Philipp) > - Add kerneldoc to reset_controller_of_init (Philipp) > - Add named constants in include/dt-bindings/reset/ (Philipp) > - Make pinctrl driver to depend on ARCH_STM32 or COMPILE_TEST (Geert) > - Introduce CPUV7M_NUM_IRQ config flag to indicate the number of interrupts > supported by the MCU, in order to limit memory waste in vectors' table (Uwe) > > > Maxime Coquelin (15): > scripts: link-vmlinux: Don't pass page offset to kallsyms if XIP > Kernel > ARM: ARMv7-M: Enlarge vector table up to 256 entries > dt-bindings: Document the ARM System timer bindings > clocksource: Add ARM System timer driver > dt-bindings: Document the STM32 reset bindings > drivers: reset: Add STM32 reset driver > dt-bindings: Document the STM32 timer bindings > clockevent: Add STM32 Timer driver > dt-bindings: Document the STM32 USART bindings > serial: stm32-usart: Add STM32 USART Driver > ARM: Add STM32 family machine > ARM: dts: Add ARM System timer as clockevent in armv7m > ARM: dts: Introduce STM32F429 MCU > ARM: configs: Add STM32 defconfig > MAINTAINERS: Add entry for STM32 MCUs > > Documentation/arm/stm32/overview.txt | 32 + > Documentation/arm/stm32/stm32f429-overview.txt | 22 + > .../devicetree/bindings/arm/armv7m_systick.txt | 26 + > .../devicetree/bindings/reset/st,stm32-rcc.txt | 102 +++ > .../devicetree/bindings/serial/st,stm32-usart.txt | 32 + > .../devicetree/bindings/timer/st,stm32-timer.txt | 22 + > MAINTAINERS | 8 + > arch/arm/Kconfig | 18 + > arch/arm/Makefile | 1 + > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/armv7-m.dtsi | 6 + > arch/arm/boot/dts/stm32f429-disco.dts | 71 +++ > arch/arm/boot/dts/stm32f429.dtsi | 226 +++++++ > arch/arm/configs/stm32_defconfig | 71 +++ > arch/arm/kernel/entry-v7m.S | 13 +- > arch/arm/mach-stm32/Makefile | 1 + > arch/arm/mach-stm32/Makefile.boot | 3 + > arch/arm/mach-stm32/board-dt.c | 19 + > arch/arm/mm/Kconfig | 15 + > drivers/clocksource/Kconfig | 15 + > drivers/clocksource/Makefile | 2 + > drivers/clocksource/armv7m_systick.c | 78 +++ > drivers/clocksource/timer-stm32.c | 184 ++++++ > drivers/reset/Makefile | 1 + > drivers/reset/reset-stm32.c | 125 ++++ > drivers/tty/serial/Kconfig | 17 + > drivers/tty/serial/Makefile | 1 + > drivers/tty/serial/stm32-usart.c | 695 +++++++++++++++++++++ > include/uapi/linux/serial_core.h | 3 + > scripts/link-vmlinux.sh | 2 +- > 30 files changed, 1807 insertions(+), 5 deletions(-) > create mode 100644 Documentation/arm/stm32/overview.txt > create mode 100644 Documentation/arm/stm32/stm32f429-overview.txt > create mode 100644 Documentation/devicetree/bindings/arm/armv7m_systick.txt > create mode 100644 Documentation/devicetree/bindings/reset/st,stm32-rcc.txt > create mode 100644 Documentation/devicetree/bindings/serial/st,stm32-usart.txt > create mode 100644 Documentation/devicetree/bindings/timer/st,stm32-timer.txt > create mode 100644 arch/arm/boot/dts/stm32f429-disco.dts > create mode 100644 arch/arm/boot/dts/stm32f429.dtsi > create mode 100644 arch/arm/configs/stm32_defconfig > create mode 100644 arch/arm/mach-stm32/Makefile > create mode 100644 arch/arm/mach-stm32/Makefile.boot > create mode 100644 arch/arm/mach-stm32/board-dt.c > create mode 100644 drivers/clocksource/armv7m_systick.c > create mode 100644 drivers/clocksource/timer-stm32.c > create mode 100644 drivers/reset/reset-stm32.c > create mode 100644 drivers/tty/serial/stm32-usart.c >