* Question on ARC's thread_info
@ 2015-03-28 23:18 Richard Weinberger
2015-03-28 23:18 ` Richard Weinberger
2015-03-31 5:10 ` Vineet Gupta
0 siblings, 2 replies; 4+ messages in thread
From: Richard Weinberger @ 2015-03-28 23:18 UTC (permalink / raw)
To: vgupta@synopsys.com; +Cc: Linux-Arch, linux-kernel@vger.kernel.org
Vineet,
I'm working on a patch series which touches sturct thread_info.
ARC's thread_info has the following comment:
* - if the contents of this structure are changed, the assembly constants
* must also be changed
Is this still true? Unless I'm reading the code wrong that case should be
handled automatically by the asm-offsets mechanism.
So no manual fixup of magic constants should be needed.
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Question on ARC's thread_info
2015-03-28 23:18 Question on ARC's thread_info Richard Weinberger
@ 2015-03-28 23:18 ` Richard Weinberger
2015-03-31 5:10 ` Vineet Gupta
1 sibling, 0 replies; 4+ messages in thread
From: Richard Weinberger @ 2015-03-28 23:18 UTC (permalink / raw)
To: vgupta@synopsys.com; +Cc: Linux-Arch, linux-kernel@vger.kernel.org
Vineet,
I'm working on a patch series which touches sturct thread_info.
ARC's thread_info has the following comment:
* - if the contents of this structure are changed, the assembly constants
* must also be changed
Is this still true? Unless I'm reading the code wrong that case should be
handled automatically by the asm-offsets mechanism.
So no manual fixup of magic constants should be needed.
Thanks,
//richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Question on ARC's thread_info
2015-03-28 23:18 Question on ARC's thread_info Richard Weinberger
2015-03-28 23:18 ` Richard Weinberger
@ 2015-03-31 5:10 ` Vineet Gupta
2015-03-31 5:10 ` Vineet Gupta
1 sibling, 1 reply; 4+ messages in thread
From: Vineet Gupta @ 2015-03-31 5:10 UTC (permalink / raw)
To: Richard Weinberger; +Cc: Linux-Arch, linux-kernel@vger.kernel.org
On Sunday 29 March 2015 04:48 AM, Richard Weinberger wrote:
> Vineet,
>
> I'm working on a patch series which touches sturct thread_info.
> ARC's thread_info has the following comment:
> * - if the contents of this structure are changed, the assembly constants
> * must also be changed
>
> Is this still true? Unless I'm reading the code wrong that case should be
> handled automatically by the asm-offsets mechanism.
> So no manual fixup of magic constants should be needed.
Yep, I think that is the case too - perhaps the comment is dated when we still had
magic constants in code :-)
If not I need to fix it anyways so feel free to change it.
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Question on ARC's thread_info
2015-03-31 5:10 ` Vineet Gupta
@ 2015-03-31 5:10 ` Vineet Gupta
0 siblings, 0 replies; 4+ messages in thread
From: Vineet Gupta @ 2015-03-31 5:10 UTC (permalink / raw)
To: Richard Weinberger; +Cc: Linux-Arch, linux-kernel@vger.kernel.org
On Sunday 29 March 2015 04:48 AM, Richard Weinberger wrote:
> Vineet,
>
> I'm working on a patch series which touches sturct thread_info.
> ARC's thread_info has the following comment:
> * - if the contents of this structure are changed, the assembly constants
> * must also be changed
>
> Is this still true? Unless I'm reading the code wrong that case should be
> handled automatically by the asm-offsets mechanism.
> So no manual fixup of magic constants should be needed.
Yep, I think that is the case too - perhaps the comment is dated when we still had
magic constants in code :-)
If not I need to fix it anyways so feel free to change it.
-Vineet
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-31 5:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-28 23:18 Question on ARC's thread_info Richard Weinberger
2015-03-28 23:18 ` Richard Weinberger
2015-03-31 5:10 ` Vineet Gupta
2015-03-31 5:10 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox