From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Thompson Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU Date: Fri, 22 May 2015 15:14:53 +0100 Message-ID: <555F39DD.9060209@linaro.org> References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> <1432285588.3929.28.camel@pengutronix.de> <20150522091822.GF8557@lukather> <1432289231.3929.60.camel@pengutronix.de> <555F2A8A.5020205@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:33992 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756720AbbEVOO5 (ORCPT ); Fri, 22 May 2015 10:14:57 -0400 Received: by wghq2 with SMTP id q2so19203325wgh.1 for ; Fri, 22 May 2015 07:14:56 -0700 (PDT) In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Maxime Coquelin , =?UTF-8?B?QW5kcmVhcyBGw6Q=?= =?UTF-8?B?cmJlcg==?= Cc: Philipp Zabel , Maxime Ripard , Arnd Bergmann , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell On 22/05/15 14:57, Maxime Coquelin wrote: > 2015-05-22 15:09 GMT+02:00 Andreas F=C3=A4rber : >> As you should know, I did have an RCC clk driver, and there is no su= ch >> issue. The two drivers use different mechanisms for initialization. = And >> I'm pretty sure that I've already remarked that on the list, too. > > Yes, you use of_iomap in your clock driver [0]. > Daniel, would you accept to do the same? > That would remove one difference between stm32/sunxi/socfpga reset dr= ivers. In fact, that is exactly what I am currently doing, though I was=20 planning for it to be temporary. It seems a bit weird to me that one driver (which requests too much=20 register space) only works because another driver chooses not to reques= t=20 any. BTW in drivers/clk there are ~110 of_iomaps and only 10=20 of_io_request_and_maps... so I don't think anyone will yell at me for=20 using of_iomap(). Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:33992 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756720AbbEVOO5 (ORCPT ); Fri, 22 May 2015 10:14:57 -0400 Received: by wghq2 with SMTP id q2so19203325wgh.1 for ; Fri, 22 May 2015 07:14:56 -0700 (PDT) Message-ID: <555F39DD.9060209@linaro.org> Date: Fri, 22 May 2015 15:14:53 +0100 From: Daniel Thompson MIME-Version: 1.0 Subject: Re: [PATCH v8 14/16] ARM: dts: Introduce STM32F429 MCU References: <1431158038-3813-1-git-send-email-mcoquelin.stm32@gmail.com> <2282066.NWoIT9ZyLc@wuerfel> <13641152.Yt4ZI3oT6L@wuerfel> <1432285588.3929.28.camel@pengutronix.de> <20150522091822.GF8557@lukather> <1432289231.3929.60.camel@pengutronix.de> <555F2A8A.5020205@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Maxime Coquelin , =?UTF-8?B?QW5kcmVhcyBGw6Q=?= =?UTF-8?B?cmJlcg==?= Cc: Philipp Zabel , Maxime Ripard , Arnd Bergmann , =?UTF-8?B?VXdlIEtsZWluZS1Lw7ZuaWc=?= , Geert Uytterhoeven , Rob Herring , Linus Walleij , Stefan Agner , Peter Meerwald , Paul Bolle , Peter Hurley , Andy Shevchenko , Chanwoo Choi , Russell King , Daniel Lezcano , Joe Perches , Vladimir Zapolskiy , Lee Jones , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Thomas Gleixner , Greg Kroah-Hartman , Jiri Slaby , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Antti Palosaari , Will Deacon , Nikolay Borisov , Rusty Russell , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" , Nicolae Rosia , Kamil Lulko Message-ID: <20150522141453.S-S7DP1dPNAJhWDH6a0TBA6J2To01Rz5-W2u0e6eNas@z> On 22/05/15 14:57, Maxime Coquelin wrote: > 2015-05-22 15:09 GMT+02:00 Andreas Färber : >> As you should know, I did have an RCC clk driver, and there is no such >> issue. The two drivers use different mechanisms for initialization. And >> I'm pretty sure that I've already remarked that on the list, too. > > Yes, you use of_iomap in your clock driver [0]. > Daniel, would you accept to do the same? > That would remove one difference between stm32/sunxi/socfpga reset drivers. In fact, that is exactly what I am currently doing, though I was planning for it to be temporary. It seems a bit weird to me that one driver (which requests too much register space) only works because another driver chooses not to request any. BTW in drivers/clk there are ~110 of_iomaps and only 10 of_io_request_and_maps... so I don't think anyone will yell at me for using of_iomap(). Daniel.