From: Waiman Long <waiman.long@hp.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
Thomas Gleixner <tglx@linutronix.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
Will Deacon <will.deacon@arm.com>,
Scott J Norton <scott.norton@hp.com>,
Douglas Hatch <doug.hatch@hp.com>
Subject: Re: [PATCH-tip v2 0/2] locking/qrwlock: Improve qrwlock performance
Date: Thu, 09 Jul 2015 21:16:26 -0400 [thread overview]
Message-ID: <559F1CEA.4060806@hp.com> (raw)
In-Reply-To: <1436479469.27924.19.camel@stgolabs.net>
On 07/09/2015 06:04 PM, Davidlohr Bueso wrote:
> On Thu, 2015-07-09 at 12:32 -0400, Waiman Long wrote:
>> With this patch series in place, we can start converting some spinlocks
>> back to rwlocks where it makes sense and the lock size increase isn't
>> a concern.
> Nice, have any users to convert? I can think of a few I've encountered,
> but there must be quite a few, specially those nasty global spinlocks
> where nobody cares about the size.
>
> o hugetlb reservation map lock: Updating hugepage ranges does a two step
> read/update for the reservation map. The first step could now be done
> concurrently if converted.
>
> o The infamous swap_lock; although I doubt any of the serious offenders
> (ie zswap callbacks) would benefit much for anything
> beyond /proc/meminfo and related.
>
> o async cookie sync wait_event, battery/ata bootup(?).
>
> etc. etc. Obviously the fairness factor is also something to consider.
Yes, I saw a couple of global spinlocks that can be converted to
rwlocks. The read lock can be used for lookup, whereas the write lock is
used for modification. Doing so will enable parallel lookups. As the
qrwlock is almost fair compared with the old implementation, it removes
a big roadblock for the conversion.
Cheers,
Longman
next prev parent reply other threads:[~2015-07-10 1:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 16:32 [PATCH-tip v2 0/2] locking/qrwlock: Improve qrwlock performance Waiman Long
2015-07-09 16:32 ` [PATCH v2 1/2] locking/qrwlock: Reduce reader/writer to reader lock transfer latency Waiman Long
2015-07-09 16:32 ` Waiman Long
2015-07-09 20:52 ` Davidlohr Bueso
2015-07-10 1:10 ` Waiman Long
2015-07-09 16:32 ` [PATCH v2 2/2] locking/qrwlock: Reduce writer to writer " Waiman Long
2015-07-09 16:32 ` Waiman Long
2015-07-09 22:04 ` [PATCH-tip v2 0/2] locking/qrwlock: Improve qrwlock performance Davidlohr Bueso
2015-07-09 22:04 ` Davidlohr Bueso
2015-07-10 1:16 ` Waiman Long [this message]
2015-07-16 15:53 ` Will Deacon
2015-07-16 15:53 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=559F1CEA.4060806@hp.com \
--to=waiman.long@hp.com \
--cc=arnd@arndb.de \
--cc=dave@stgolabs.net \
--cc=doug.hatch@hp.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=scott.norton@hp.com \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).