From: Larry Finger <Larry.Finger@lwfinger.net>
To: Joe Perches <joe@perches.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bug: Fix build error in V4.2-RC1
Date: Sun, 12 Jul 2015 10:56:52 -0500 [thread overview]
Message-ID: <55A28E44.8020202@lwfinger.net> (raw)
In-Reply-To: <1436716328.2711.77.camel@perches.com>
On 07/12/2015 10:52 AM, Joe Perches wrote:
> On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote:
>> If CONFIG_BUG is not defined, then macro __WARN is not defined.
> []
>> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> []
>> @@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>
>> +#define __WARN() do {} while (1)
>
> Do you really think WARN should loop forever?
Obviously not. I copied the code in that section for BUG() without thinking.
On to V2 after I get some more feedback.
Thanks,
Larry
prev parent reply other threads:[~2015-07-12 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-12 15:00 [PATCH] bug: Fix build error in V4.2-RC1 Larry Finger
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:56 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A28E44.8020202@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox