* [PATCH] bug: Fix build error in V4.2-RC1
@ 2015-07-12 15:00 Larry Finger
2015-07-12 15:52 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2015-07-12 15:00 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Larry Finger, linux-arch, linux-kernel
If CONFIG_BUG is not defined, then macro __WARN is not defined. This shows
as the following build error:
CC [M] drivers/media/v4l2-core/videobuf2-core.o
drivers/media/v4l2-core/videobuf2-core.c: In function ‘vb2_warn_zero_bytesused’:
drivers/media/v4l2-core/videobuf2-core.c:1253:2: error: implicit declaration of function ‘__WARN’ [-Werror=implicit-function-declaration]
__WARN();
^
This problem has been bisected to commit 77a3c6fd90c94f635edb00d4a65f485687538791.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: linux-arch@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
include/asm-generic/bug.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 630dd23..c1cb4b3 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);
})
#else /* !CONFIG_BUG */
+#define __WARN() do {} while (1)
#ifndef HAVE_ARCH_BUG
#define BUG() do {} while (1)
#endif
--
2.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] bug: Fix build error in V4.2-RC1
2015-07-12 15:00 [PATCH] bug: Fix build error in V4.2-RC1 Larry Finger
@ 2015-07-12 15:52 ` Joe Perches
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:56 ` Larry Finger
0 siblings, 2 replies; 4+ messages in thread
From: Joe Perches @ 2015-07-12 15:52 UTC (permalink / raw)
To: Larry Finger; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote:
> If CONFIG_BUG is not defined, then macro __WARN is not defined.
[]
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
[]
> @@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);
> +#define __WARN() do {} while (1)
Do you really think WARN should loop forever?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bug: Fix build error in V4.2-RC1
2015-07-12 15:52 ` Joe Perches
@ 2015-07-12 15:52 ` Joe Perches
2015-07-12 15:56 ` Larry Finger
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2015-07-12 15:52 UTC (permalink / raw)
To: Larry Finger; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote:
> If CONFIG_BUG is not defined, then macro __WARN is not defined.
[]
> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
[]
> @@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);
> +#define __WARN() do {} while (1)
Do you really think WARN should loop forever?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] bug: Fix build error in V4.2-RC1
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:52 ` Joe Perches
@ 2015-07-12 15:56 ` Larry Finger
1 sibling, 0 replies; 4+ messages in thread
From: Larry Finger @ 2015-07-12 15:56 UTC (permalink / raw)
To: Joe Perches; +Cc: Arnd Bergmann, linux-arch, linux-kernel
On 07/12/2015 10:52 AM, Joe Perches wrote:
> On Sun, 2015-07-12 at 10:00 -0500, Larry Finger wrote:
>> If CONFIG_BUG is not defined, then macro __WARN is not defined.
> []
>> diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
> []
>> @@ -137,6 +137,7 @@ extern void warn_slowpath_null(const char *file, const int line);
>
>> +#define __WARN() do {} while (1)
>
> Do you really think WARN should loop forever?
Obviously not. I copied the code in that section for BUG() without thinking.
On to V2 after I get some more feedback.
Thanks,
Larry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-07-12 16:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-12 15:00 [PATCH] bug: Fix build error in V4.2-RC1 Larry Finger
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:52 ` Joe Perches
2015-07-12 15:56 ` Larry Finger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox