From mboxrd@z Thu Jan 1 00:00:00 1970 From: Palmer Dabbelt Subject: Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c Date: Thu, 17 Sep 2015 13:53:16 -0700 (PDT) Message-ID: <55fb283c.f039440a.427ff.fffff187@mx.google.com> References: <15268.1442483832@warthog.procyon.org.uk> Return-path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:33223 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbbIQUxR (ORCPT ); Thu, 17 Sep 2015 16:53:17 -0400 Received: by pacex6 with SMTP id ex6so29251508pac.0 for ; Thu, 17 Sep 2015 13:53:16 -0700 (PDT) In-Reply-To: <15268.1442483832@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: Cc: dhowells@redhat.com, arnd@arndb.de, viro@zeniv.linux.org.uk, ast@plumgrid.com, aishchuk@linux.vnet.ibm.com, aarcange@redhat.com, akpm@linux-foundation.org, luto@kernel.org, acme@kernel.org, bhe@redhat.com, 3chas3@gmail.com, chris@zankel.net, dave@sr71.net, dyoung@redhat.com, drysdale@google.com, davem@davemloft.net, ebiederm@xmission.com, geoff@infradead.org, gregkh@linuxfoundation.org, hpa@zytor.com, mingo@kernel.org, iulia.manda21@gmail.com, plagnioj@jcrosoft.com, jikos@kernel.org, josh@joshtriplett.org, kexec@lists.infradead.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, mathieu.desnoyers@efficios.com, jcmvbkbc@gmail.com, paulmck@linux.vnet.ibm.com, a.p.zijlstra@chello.nl, tglx@linutronix.de, tomi.valkeinen@ti.com, vgoyal@redhat.com, x86@kernel.org On Thu, 17 Sep 2015 02:57:12 PDT (-0700), dhowells@redhat.com wrote: > Palmer Dabbelt wrote: > >> +#ifdef CONFIG_COMPAT >> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */ >> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf) >> +#endif > > I wonder if it would hurt to ditch the conditionals entirely. It only eats > cpp namespace, not C namespace so it won't affect the output if it is not used > because the code that uses it is compiled out. Makes sense to me. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f53.google.com ([209.85.220.53]:33223 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751816AbbIQUxR (ORCPT ); Thu, 17 Sep 2015 16:53:17 -0400 Received: by pacex6 with SMTP id ex6so29251508pac.0 for ; Thu, 17 Sep 2015 13:53:16 -0700 (PDT) Message-ID: <55fb283c.f039440a.427ff.fffff187@mx.google.com> Date: Thu, 17 Sep 2015 13:53:16 -0700 (PDT) From: Palmer Dabbelt Subject: Re: [PATCH 03/13] Move COMPAT_ATM_ADDPARTY to net/atm/svc.c In-Reply-To: <15268.1442483832@warthog.procyon.org.uk> Sender: linux-arch-owner@vger.kernel.org List-ID: To: dhowells@redhat.com Cc: arnd@arndb.de, viro@zeniv.linux.org.uk, ast@plumgrid.com, aishchuk@linux.vnet.ibm.com, aarcange@redhat.com, akpm@linux-foundation.org, luto@kernel.org, acme@kernel.org, bhe@redhat.com, 3chas3@gmail.com, chris@zankel.net, dave@sr71.net, dyoung@redhat.com, drysdale@google.com, davem@davemloft.net, ebiederm@xmission.com, geoff@infradead.org, gregkh@linuxfoundation.org, hpa@zytor.com, mingo@kernel.org, iulia.manda21@gmail.com, plagnioj@jcrosoft.com, jikos@kernel.org, josh@joshtriplett.org, kexec@lists.infradead.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, mathieu.desnoyers@efficios.com, jcmvbkbc@gmail.com, paulmck@linux.vnet.ibm.com, a.p.zijlstra@chello.nl, tglx@linutronix.de, tomi.valkeinen@ti.com, vgoyal@redhat.com, x86@kernel.org Message-ID: <20150917205316.4G2cbOrpZIP6rKeSsbC1P6QXlIG6vb1Nv2u-yrgz9LE@z> On Thu, 17 Sep 2015 02:57:12 PDT (-0700), dhowells@redhat.com wrote: > Palmer Dabbelt wrote: > >> +#ifdef CONFIG_COMPAT >> +/* It actually takes struct sockaddr_atmsvc, not struct atm_iobuf */ >> +#define COMPAT_ATM_ADDPARTY _IOW('a', ATMIOC_SPECIAL+4, struct compat_atm_iobuf) >> +#endif > > I wonder if it would hurt to ditch the conditionals entirely. It only eats > cpp namespace, not C namespace so it won't affect the output if it is not used > because the code that uses it is compiled out. Makes sense to me.