From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Ungerer Subject: Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn Date: Mon, 16 Nov 2015 22:18:15 +1000 Message-ID: <5649C987.3050600@uclinux.org> References: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> <1447585455-19671-5-git-send-email-geert@linux-m68k.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1447585455-19671-5-git-send-email-geert@linux-m68k.org> Sender: linux-kernel-owner@vger.kernel.org To: Geert Uytterhoeven , Sam Creasey , linux-m68k@lists.linux-m68k.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-arch.vger.kernel.org Hi Geert, On 15/11/15 21:04, Geert Uytterhoeven wrote: > If max_pfn is not initialized, the block layer may use wrong DMA masks. > > Replace open-coded shifts by PFN_DOWN() while we're at it. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. > --- > arch/m68k/kernel/setup_no.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c > index 88c27d94a7214c95..29b44e69f0f47375 100644 > --- a/arch/m68k/kernel/setup_no.c > +++ b/arch/m68k/kernel/setup_no.c > @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) > * Give all the memory to the bootmap allocator, tell it to put the > * boot mem_map at the start of memory. > */ > + min_low_pfn = PFN_DOWN(memory_start); > + max_pfn = max_low_pfn = PFN_DOWN(memory_end); > + > bootmap_size = init_bootmem_node( > NODE_DATA(0), > - memory_start >> PAGE_SHIFT, /* map goes here */ > - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire */ > - memory_end >> PAGE_SHIFT); > + min_low_pfn, /* map goes here */ > + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */ > + max_pfn); > /* > * Free the usable memory, we have to make sure we do not free > * the bootmem bitmap so we then reserve it after freeing it :-) Should this be changed to use init_bootmem() as per your changes in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and {min,max}_low_pfn")? For the same reason? Regards Greg From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from icp-osb-irony-out4.external.iinet.net.au ([203.59.1.220]:46303 "EHLO icp-osb-irony-out4.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751465AbbKPM1h (ORCPT ); Mon, 16 Nov 2015 07:27:37 -0500 Subject: Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn References: <1447585455-19671-1-git-send-email-geert@linux-m68k.org> <1447585455-19671-5-git-send-email-geert@linux-m68k.org> From: Greg Ungerer Message-ID: <5649C987.3050600@uclinux.org> Date: Mon, 16 Nov 2015 22:18:15 +1000 MIME-Version: 1.0 In-Reply-To: <1447585455-19671-5-git-send-email-geert@linux-m68k.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven , Sam Creasey , linux-m68k@lists.linux-m68k.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20151116121815.tzYfh-chzNHfjgT_K1wENLhY1D9Ajj0W3HHk3nvXbz4@z> Hi Geert, On 15/11/15 21:04, Geert Uytterhoeven wrote: > If max_pfn is not initialized, the block layer may use wrong DMA masks. > > Replace open-coded shifts by PFN_DOWN() while we're at it. > > Signed-off-by: Geert Uytterhoeven > --- > Compile-tested only. > --- > arch/m68k/kernel/setup_no.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c > index 88c27d94a7214c95..29b44e69f0f47375 100644 > --- a/arch/m68k/kernel/setup_no.c > +++ b/arch/m68k/kernel/setup_no.c > @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p) > * Give all the memory to the bootmap allocator, tell it to put the > * boot mem_map at the start of memory. > */ > + min_low_pfn = PFN_DOWN(memory_start); > + max_pfn = max_low_pfn = PFN_DOWN(memory_end); > + > bootmap_size = init_bootmem_node( > NODE_DATA(0), > - memory_start >> PAGE_SHIFT, /* map goes here */ > - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire */ > - memory_end >> PAGE_SHIFT); > + min_low_pfn, /* map goes here */ > + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */ > + max_pfn); > /* > * Free the usable memory, we have to make sure we do not free > * the bootmem bitmap so we then reserve it after freeing it :-) Should this be changed to use init_bootmem() as per your changes in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and {min,max}_low_pfn")? For the same reason? Regards Greg