Re: [PATCH 4/4] m68knommu: Add missing initialization of max_pfn and {min,max}_low_pfn

Greg Ungerer
2015-11-16T12:27:37Z

Hi Geert,

On 15/11/15 21:04, Geert Uytterhoeven wrote:
> If max_pfn is not initialized, the block layer may use wrong DMA masks.
>
> Replace open-coded shifts by PFN_DOWN() while we're at it.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> Compile-tested only.
> ---
> arch/m68k/kernel/setup_no.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/arch/m68k/kernel/setup_no.c b/arch/m68k/kernel/setup_no.c
> index 88c27d94a7214c95..29b44e69f0f47375 100644
> --- a/arch/m68k/kernel/setup_no.c
> +++ b/arch/m68k/kernel/setup_no.c
> @@ -238,11 +238,14 @@ void __init setup_arch(char **cmdline_p)
> * Give all the memory to the bootmap allocator, tell it to put the
> * boot mem_map at the start of memory.
> */
> + min_low_pfn = PFN_DOWN(memory_start);
> + max_pfn = max_low_pfn = PFN_DOWN(memory_end);
> +
> bootmap_size = init_bootmem_node(
> NODE_DATA(0),
> - memory_start >> PAGE_SHIFT, /* map goes here */
> - PAGE_OFFSET >> PAGE_SHIFT, /* 0 on coldfire */
> - memory_end >> PAGE_SHIFT);
> + min_low_pfn, /* map goes here */
> + PFN_DOWN(PAGE_OFFSET), /* 0 on coldfire */
> + max_pfn);
> /*
> * Free the usable memory, we have to make sure we do not free
> * the bootmem bitmap so we then reserve it after freeing it :-)

Should this be changed to use init_bootmem() as per your changes
in patch 3 ("m68k/mm: sun3 - Add missing initialization of max_pfn and
{min,max}_low_pfn")? For the same reason?

Regards
Greg