Re: [PATCH 1/4] m68k/mm: motorola - Add missing initialization of max_pfn

Michael Schmitz
2015-11-17T04:42:48Z

Hi Geert,

Am 16.11.2015 um 00:04 schrieb Geert Uytterhoeven:
> If max_pfn is not initialized, the various /proc/kpage* files are empty,
> and selftests/vm/mlock2-tests will fail. max_pfn is also used by the
> block layer to calculate DMA masks.

What about platforms where the DMA can't address all available physical
memory?

Cheers,

Michael

>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> arch/m68k/mm/motorola.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c
> index b958916e5eac96b2..8f37fdd80be9e9cc 100644
> --- a/arch/m68k/mm/motorola.c
> +++ b/arch/m68k/mm/motorola.c
> @@ -250,7 +250,7 @@ void __init paging_init(void)
> high_memory = phys_to_virt(max_addr);
>
> min_low_pfn = availmem >> PAGE_SHIFT;
> - max_low_pfn = max_addr >> PAGE_SHIFT;
> + max_pfn = max_low_pfn = max_addr >> PAGE_SHIFT;
>
> for (i = 0; i < m68k_num_memory; i++) {
> addr = m68k_memory[i].addr;
>