public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Michael Schmitz <schmitzmic@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
	Greg Ungerer <gerg@uclinux.org>, Sam Creasey <sammy@sammy.net>,
	linux-m68k@lists.linux-m68k.org
Cc: linux-arch@vger.kernel.org
Subject: Re: [PATCH 1/4] m68k/mm: motorola - Add missing initialization of max_pfn
Date: Tue, 17 Nov 2015 17:42:34 +1300	[thread overview]
Message-ID: <564AB03A.80303@gmail.com> (raw)
In-Reply-To: <1447585455-19671-2-git-send-email-geert@linux-m68k.org>

Hi Geert,


Am 16.11.2015 um 00:04 schrieb Geert Uytterhoeven:
> If max_pfn is not initialized, the various /proc/kpage* files are empty,
> and selftests/vm/mlock2-tests will fail. max_pfn is also used by the
> block layer to calculate DMA masks.

What about platforms where the DMA can't address all available physical
memory?

Cheers,

	Michael


> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/m68k/mm/motorola.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/mm/motorola.c b/arch/m68k/mm/motorola.c
> index b958916e5eac96b2..8f37fdd80be9e9cc 100644
> --- a/arch/m68k/mm/motorola.c
> +++ b/arch/m68k/mm/motorola.c
> @@ -250,7 +250,7 @@ void __init paging_init(void)
>  	high_memory = phys_to_virt(max_addr);
>  
>  	min_low_pfn = availmem >> PAGE_SHIFT;
> -	max_low_pfn = max_addr >> PAGE_SHIFT;
> +	max_pfn = max_low_pfn = max_addr >> PAGE_SHIFT;
>  
>  	for (i = 0; i < m68k_num_memory; i++) {
>  		addr = m68k_memory[i].addr;
> 

  reply	other threads:[~2015-11-17  4:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15 11:04 [PATCH 0/4] m68k/mm: Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven
2015-11-15 11:04 ` Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 1/4] m68k/mm: motorola - Add missing initialization of max_pfn Geert Uytterhoeven
2015-11-17  4:42   ` Michael Schmitz [this message]
2015-11-17 19:54     ` Geert Uytterhoeven
2015-11-17 19:54       ` Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 2/4] m68k/mm: m54xx " Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-17  0:16   ` Greg Ungerer
2015-11-17  0:16     ` Greg Ungerer
2015-11-15 11:04 ` [PATCH 3/4] m68k/mm: sun3 - Add missing initialization of max_pfn and {min,max}_low_pfn Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-15 11:04 ` [PATCH 4/4] m68knommu: " Geert Uytterhoeven
2015-11-15 11:04   ` Geert Uytterhoeven
2015-11-16 12:18   ` Greg Ungerer
2015-11-16 12:18     ` Greg Ungerer
2015-11-16 13:05     ` Geert Uytterhoeven
2015-11-16 23:46       ` Greg Ungerer
2015-11-16 23:54   ` Greg Ungerer
2015-11-22 10:38     ` Geert Uytterhoeven
2015-11-17  0:17 ` [PATCH 0/4] m68k/mm: " Greg Ungerer
2015-11-17  0:17   ` Greg Ungerer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564AB03A.80303@gmail.com \
    --to=schmitzmic@gmail.com \
    --cc=geert@linux-m68k.org \
    --cc=gerg@uclinux.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=sammy@sammy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox