From: Helge Deller <deller@gmx.de>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 09/17] drivers: Initialize resource entry to zero
Date: Tue, 5 Jan 2016 21:57:33 +0100 [thread overview]
Message-ID: <568C2E3D.4060701@gmx.de> (raw)
In-Reply-To: <1452020081-26534-9-git-send-email-toshi.kani@hpe.com>
On 05.01.2016 19:54, Toshi Kani wrote:
> I/O resource descriptor, 'desc' in struct resource, needs to be
> initialized to zero by default. Some drivers call kmalloc() to
> allocate a resource entry, but does not initialize it to zero by
> memset(). Change these drivers to call kzalloc(), instead.
>
> Cc: linux-acpi@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> Acked-by: Simon Horman <horms+renesas@verge.net.au> # sh
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> ---
> drivers/acpi/acpi_platform.c | 2 +-
> drivers/parisc/eisa_enumerator.c | 4 ++--
The parisc changes look good. For those:
Acked-by: Helge Deller <deller@gmx.de>
> drivers/rapidio/rio.c | 8 ++++----
> drivers/sh/superhyway/superhyway.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 296b7a1..b6f7fa3 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
> if (count < 0) {
> return NULL;
> } else if (count > 0) {
> - resources = kmalloc(count * sizeof(struct resource),
> + resources = kzalloc(count * sizeof(struct resource),
> GFP_KERNEL);
> if (!resources) {
> dev_err(&adev->dev, "No memory for resources\n");
> diff --git a/drivers/parisc/eisa_enumerator.c b/drivers/parisc/eisa_enumerator.c
> index a656d9e..21905fe 100644
> --- a/drivers/parisc/eisa_enumerator.c
> +++ b/drivers/parisc/eisa_enumerator.c
> @@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf,
> for (i=0;i<HPEE_MEMORY_MAX_ENT;i++) {
> c = get_8(buf+len);
>
> - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
> int result;
>
> res->name = name;
> @@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, struct resource *io_parent,
> for (i=0;i<HPEE_PORT_MAX_ENT;i++) {
> c = get_8(buf+len);
>
> - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
> res->name = board;
> res->start = get_16(buf+len+1);
> res->end = get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1;
> diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
> index d7b87c6..e220edc 100644
> --- a/drivers/rapidio/rio.c
> +++ b/drivers/rapidio/rio.c
> @@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport,
> if (mport->ops->open_inb_mbox == NULL)
> goto out;
>
> - res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_mbox_res(res, mbox, mbox);
> @@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport,
> if (mport->ops->open_outb_mbox == NULL)
> goto out;
>
> - res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_mbox_res(res, mbox, mbox);
> @@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport,
> {
> int rc = 0;
>
> - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_dbell_res(res, start, end);
> @@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 start, u16 end)
> struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start,
> u16 end)
> {
> - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_dbell_res(res, start, end);
> diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/superhyway.c
> index 2d9e7f3..bb1fb771 100644
> --- a/drivers/sh/superhyway/superhyway.c
> +++ b/drivers/sh/superhyway/superhyway.c
> @@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev,
> superhyway_read_vcr(dev, base, &dev->vcr);
>
> if (!dev->resource) {
> - dev->resource = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + dev->resource = kzalloc(sizeof(struct resource), GFP_KERNEL);
> if (!dev->resource) {
> kfree(dev);
> return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: Toshi Kani <toshi.kani@hpe.com>, akpm@linux-foundation.org, bp@alien8.de
Cc: linux-arch@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 09/17] drivers: Initialize resource entry to zero
Date: Tue, 5 Jan 2016 21:57:33 +0100 [thread overview]
Message-ID: <568C2E3D.4060701@gmx.de> (raw)
Message-ID: <20160105205733.MywGSS7v-NPNDu1rgSMjo6BFJEhtivRDcl55ST0XAoc@z> (raw)
In-Reply-To: <1452020081-26534-9-git-send-email-toshi.kani@hpe.com>
On 05.01.2016 19:54, Toshi Kani wrote:
> I/O resource descriptor, 'desc' in struct resource, needs to be
> initialized to zero by default. Some drivers call kmalloc() to
> allocate a resource entry, but does not initialize it to zero by
> memset(). Change these drivers to call kzalloc(), instead.
>
> Cc: linux-acpi@vger.kernel.org
> Cc: linux-parisc@vger.kernel.org
> Cc: linux-sh@vger.kernel.org
> Acked-by: Simon Horman <horms+renesas@verge.net.au> # sh
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> ---
> drivers/acpi/acpi_platform.c | 2 +-
> drivers/parisc/eisa_enumerator.c | 4 ++--
The parisc changes look good. For those:
Acked-by: Helge Deller <deller@gmx.de>
> drivers/rapidio/rio.c | 8 ++++----
> drivers/sh/superhyway/superhyway.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/acpi/acpi_platform.c b/drivers/acpi/acpi_platform.c
> index 296b7a1..b6f7fa3 100644
> --- a/drivers/acpi/acpi_platform.c
> +++ b/drivers/acpi/acpi_platform.c
> @@ -62,7 +62,7 @@ struct platform_device *acpi_create_platform_device(struct acpi_device *adev)
> if (count < 0) {
> return NULL;
> } else if (count > 0) {
> - resources = kmalloc(count * sizeof(struct resource),
> + resources = kzalloc(count * sizeof(struct resource),
> GFP_KERNEL);
> if (!resources) {
> dev_err(&adev->dev, "No memory for resources\n");
> diff --git a/drivers/parisc/eisa_enumerator.c b/drivers/parisc/eisa_enumerator.c
> index a656d9e..21905fe 100644
> --- a/drivers/parisc/eisa_enumerator.c
> +++ b/drivers/parisc/eisa_enumerator.c
> @@ -91,7 +91,7 @@ static int configure_memory(const unsigned char *buf,
> for (i=0;i<HPEE_MEMORY_MAX_ENT;i++) {
> c = get_8(buf+len);
>
> - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
> int result;
>
> res->name = name;
> @@ -183,7 +183,7 @@ static int configure_port(const unsigned char *buf, struct resource *io_parent,
> for (i=0;i<HPEE_PORT_MAX_ENT;i++) {
> c = get_8(buf+len);
>
> - if (NULL != (res = kmalloc(sizeof(struct resource), GFP_KERNEL))) {
> + if (NULL != (res = kzalloc(sizeof(struct resource), GFP_KERNEL))) {
> res->name = board;
> res->start = get_16(buf+len+1);
> res->end = get_16(buf+len+1)+(c&HPEE_PORT_SIZE_MASK)+1;
> diff --git a/drivers/rapidio/rio.c b/drivers/rapidio/rio.c
> index d7b87c6..e220edc 100644
> --- a/drivers/rapidio/rio.c
> +++ b/drivers/rapidio/rio.c
> @@ -117,7 +117,7 @@ int rio_request_inb_mbox(struct rio_mport *mport,
> if (mport->ops->open_inb_mbox == NULL)
> goto out;
>
> - res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_mbox_res(res, mbox, mbox);
> @@ -185,7 +185,7 @@ int rio_request_outb_mbox(struct rio_mport *mport,
> if (mport->ops->open_outb_mbox == NULL)
> goto out;
>
> - res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_mbox_res(res, mbox, mbox);
> @@ -285,7 +285,7 @@ int rio_request_inb_dbell(struct rio_mport *mport,
> {
> int rc = 0;
>
> - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_dbell_res(res, start, end);
> @@ -360,7 +360,7 @@ int rio_release_inb_dbell(struct rio_mport *mport, u16 start, u16 end)
> struct resource *rio_request_outb_dbell(struct rio_dev *rdev, u16 start,
> u16 end)
> {
> - struct resource *res = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + struct resource *res = kzalloc(sizeof(struct resource), GFP_KERNEL);
>
> if (res) {
> rio_init_dbell_res(res, start, end);
> diff --git a/drivers/sh/superhyway/superhyway.c b/drivers/sh/superhyway/superhyway.c
> index 2d9e7f3..bb1fb771 100644
> --- a/drivers/sh/superhyway/superhyway.c
> +++ b/drivers/sh/superhyway/superhyway.c
> @@ -66,7 +66,7 @@ int superhyway_add_device(unsigned long base, struct superhyway_device *sdev,
> superhyway_read_vcr(dev, base, &dev->vcr);
>
> if (!dev->resource) {
> - dev->resource = kmalloc(sizeof(struct resource), GFP_KERNEL);
> + dev->resource = kzalloc(sizeof(struct resource), GFP_KERNEL);
> if (!dev->resource) {
> kfree(dev);
> return -ENOMEM;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-01-05 20:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 18:54 [PATCH v3 01/17] resource: Add System RAM resource type Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 02/17] resource: make resource flags handled properly Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 03/17] resource: Add I/O resource descriptor Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 04/17] x86/e820: Set System RAM type and descriptor Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 05/17] ia64: " Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 19:04 ` Luck, Tony
2016-01-05 18:54 ` [PATCH v3 06/17] arch: Set IORESOURCE_SYSTEM_RAM to System RAM Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-24 18:00 ` Borislav Petkov
2016-01-24 18:00 ` Borislav Petkov
2016-01-05 18:54 ` [PATCH v3 07/17] kexec: " Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-07 12:38 ` Dave Young
2016-01-05 18:54 ` [PATCH v3 08/17] xen, mm: " Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 09/17] drivers: Initialize resource entry to zero Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 20:57 ` Helge Deller [this message]
2016-01-05 20:57 ` Helge Deller
2016-01-05 18:54 ` [PATCH v3 10/17] resource: Change walk_system_ram to use System RAM type Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 11/17] arm/samsung: Change s3c_pm_run_res() " Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 12/17] memremap: Change region_intersects() to take @flags and @desc Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-05 18:54 ` [PATCH v3 13/17] resource: Add walk_iomem_res_desc() Toshi Kani
2016-01-05 18:54 ` Toshi Kani
[not found] ` <1452020081-26534-1-git-send-email-toshi.kani-ZPxbGqLxI0U@public.gmane.org>
2016-01-05 18:54 ` [PATCH v3 14/17] x86, nvdimm, kexec: Use walk_iomem_res_desc() for iomem search Toshi Kani
2016-01-05 18:54 ` [PATCH v3 14/17] x86,nvdimm,kexec: " Toshi Kani
2016-01-07 12:39 ` Dave Young
2016-01-05 18:54 ` [PATCH v3 15/17] x86/kexec: Remove walk_iomem_res() call with GART Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-07 12:37 ` Dave Young
2016-01-05 18:54 ` [PATCH v3 16/17] resource: Kill walk_iomem_res() Toshi Kani
2016-01-05 18:54 ` Toshi Kani
2016-01-07 12:40 ` Dave Young
2016-01-07 12:40 ` Dave Young
2016-01-05 18:54 ` [PATCH v3 17/17] ACPI/EINJ: Allow memory error injection to NVDIMM Toshi Kani
2016-01-05 18:54 ` Toshi Kani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568C2E3D.4060701@gmx.de \
--to=deller@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).