From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v4 0/3] kallsyms base relative series Date: Mon, 25 Jan 2016 09:44:10 -0800 Message-ID: <56A65EEA.8010908@roeck-us.net> References: <1453731572-18448-1-git-send-email-ard.biesheuvel@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bh-25.webhostbox.net ([208.91.199.152]:50681 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932713AbcAYRoh (ORCPT ); Mon, 25 Jan 2016 12:44:37 -0500 In-Reply-To: <1453731572-18448-1-git-send-email-ard.biesheuvel@linaro.org> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Ard Biesheuvel , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, keescook@chromium.org, akpm@linux-foundation.org, mingo@kernel.org, hpa@zytor.com, heiko.carstens@de.ibm.com, benh@kernel.crashing.org, mpe@ellerman.id.au, mmarek@suse.cz, rusty@rustcorp.com.au, arnd@arndb.de, linux-arch@vger.kernel.org On 01/25/2016 06:19 AM, Ard Biesheuvel wrote: > This v4 of my kallsyms base relative implementation is now a 3 piece series, > since it caused some problems due to the way absolute symbols are handled > by the absolute per cpu code. As it turns out, that code was probably wrong > in the sense that it caused non-relocated symbol addresses to be emitted > for values that are in fact relative to the address of the kernel text. > > Patch #1 fixes the scripts/kallsyms invocation to only pass the x86_64 > specific --absolute-percpu option if CONFIG_SMP is also set. > > Patch #2 reworks the absolute percpu code to only emit those percpu symbols > as absolute, and not symbols that have been classified as 'A' (absolute) by > the linker, since that does not mean quite the same thing. > > Patch #3 is the original kallsyms base relative patch, with some > modifications: > - folded the s/ULLONG_MAX/-1ULL? change made by Andrew > - ensured that the kallsyms_relative_base value itself is relocated as > required. > - dropped all of the acks and other tags, as they have become outdated with > the recent changes to this patch. > I tested the series on top of mmotm (after reverting the original patches). Qemu tests for mips, sparc, and x86 (both smp and nosmp) now pass. Tested-by: Guenter Roeck > Ard Biesheuvel (3): > x86: kallsyms: disable absolute percpu symbols on !SMP > kallsyms: don't overload absolute symbol type for percpu symbols > kallsyms: add support for relative offsets in kallsyms address table > > init/Kconfig | 16 +++ > kernel/kallsyms.c | 38 ++++++-- > scripts/kallsyms.c | 102 +++++++++++++++++--- > scripts/link-vmlinux.sh | 6 +- > scripts/namespace.pl | 2 + > 5 files changed, 142 insertions(+), 22 deletions(-) >