From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9248C0032E for ; Wed, 25 Oct 2023 21:19:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229583AbjJYVTD (ORCPT ); Wed, 25 Oct 2023 17:19:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjJYVTD (ORCPT ); Wed, 25 Oct 2023 17:19:03 -0400 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B304D132; Wed, 25 Oct 2023 14:19:01 -0700 (PDT) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 217615C02D1; Wed, 25 Oct 2023 17:19:01 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute5.internal (MEProxy); Wed, 25 Oct 2023 17:19:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1698268741; x=1698355141; bh=sB bmzZrzS7uTnh17vfzRRsLGG5pya0cO071IzBgauVw=; b=cEGW65XAIPb/2izJgp CDNL/6qj+dj9I6xTv077eqlR9F9W9CENmDXvCK5w3j0oBgdR7HbmVHLb/MrRWvHs 6fSWyu1V7USJiN7J/0oYHagyu11Opj2C6e6Jp1rGV5jOBVE8Ea4yqM09svL8kZCf pjGGu4CWF4OAcZX1K7FTRNFl/BWFqQXgqkdVEPnGzJa6dVONdvbGDDKwdgCVlHsd XMESC0iY7G2qWQgs3P+I7S1kHGTXSfZmvQrykBdFWoIz1qYWR95e7A1Vubgtrb4n yNvh/rii5JKXOwmTwghXClJTe5VfJfXno1JEpnPWJ3bdKNMwlGIHc0rYeplYAcR4 mIsQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1698268741; x=1698355141; bh=sBbmzZrzS7uTn h17vfzRRsLGG5pya0cO071IzBgauVw=; b=B6qwFUmEMob+EA2+IiIud9rsZ2Djn G3DTTilrXtsOAaKYdVplWsooJZj+Y2vbKCzWWNxY4Jfhe0di5qFyPcJ/4JQBQkZc WYYFytP0NLIGXoUhGP2JoDeANt50t3TAsZla/iURUbw98UK6E1yw3tZcEDP3oCfI 7Lp2exF8FrfsqOWwhZ/ZYWdN0v3wUyedHltDhjdiw3dQiHiH4QZXP0XavdterzXa F8hm2tsjWmUmXptrG1RIGPkVGDU0YyrnJ4XgyHIA2mWAcFRRvHjKrn6rs+GoT3fy zX3bxaMerVMOQ3VhugI0tBEane6n35v6cbCNWFAVs2DF6rLy5xHOuV/7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrledtgdduheekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id BDBADB60089; Wed, 25 Oct 2023 17:19:00 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632 MIME-Version: 1.0 Message-Id: <571211a1-470a-43da-a603-fd12a640b7a8@app.fastmail.com> In-Reply-To: References: <20230919-optimize_checksum-v7-0-06c7d0ddd5d6@rivosinc.com> <20230919-optimize_checksum-v7-2-06c7d0ddd5d6@rivosinc.com> <059f17e6-e240-40fa-8742-7844ad3b3502@app.fastmail.com> Date: Wed, 25 Oct 2023 23:18:40 +0200 From: "Arnd Bergmann" To: "Charlie Jenkins" Cc: "Wang, Xiao W" , Linux-Arch , "Albert Ou" , "linux-kernel@vger.kernel.org" , "Conor Dooley" , "David Laight" , "Palmer Dabbelt" , "Paul Walmsley" , "linux-riscv@lists.infradead.org" Subject: Re: [PATCH v7 2/4] riscv: Checksum header Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Wed, Oct 25, 2023, at 23:11, Charlie Jenkins wrote: > > Thank you for pointing that out, I had not realized that macro existed. > Since riscv keeps NET_IP_ALIGN at 0 it should be expected that > ip_fast_csum is only called with 32-bit aligned addresses. I will update > the comment and refer to that macro. riscv supports misaligned accesses > but there are no guarantees of speed. Just to clarify for your comment: riscv gets the default value of '2', which is the one that makes the header aligned. Arnd