From mboxrd@z Thu Jan 1 00:00:00 1970 From: Szabolcs Nagy Subject: Re: [PATCH v6 00/21] ILP32 for ARM64 Date: Wed, 25 May 2016 11:42:04 +0100 Message-ID: <5745817C.1070406@arm.com> References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> Mime-Version: 1.0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> Sender: linux-doc-owner@vger.kernel.org To: Yury Norov , arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, libc-alpha@sourceware.org Cc: nd@arm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, bamvor.zhangjian@huawei.com, klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de, Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl, geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com List-Id: linux-arch.vger.kernel.org On 24/05/16 01:04, Yury Norov wrote: > This version is based on kernel v4.6. > It works with glibc-2.23, and tested with LTP. > ... > ILP32 glibc branch is available here: > https://github.com/norov/glibc/tree/ilp32-2.23 > > It is tested with this series with no major downsides. I will send it to > glibc-alpha soon, after final revise. Please review and comment it as well. i spotted one __ilp32__ vs __ILP32__ typo in the glibc code, i can review it in detail when there is a cleaned up patch set. in general the approach seems ok, the ugly part is when lp64 and ilp32 share code, but ilp32 needs some tweaks compared to the current code (e.g. x vs w regs in asm, long changed to long long in syscalls, different relocations etc) those will be hard to review. the naming is sometimes _be_ilp32 sometimes ilp32_be, but let's hope there will be no new abi variant to confuse this further. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:52622 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcEYKmR convert rfc822-to-8bit (ORCPT ); Wed, 25 May 2016 06:42:17 -0400 Message-ID: <5745817C.1070406@arm.com> Date: Wed, 25 May 2016 11:42:04 +0100 From: Szabolcs Nagy MIME-Version: 1.0 Subject: Re: [PATCH v6 00/21] ILP32 for ARM64 References: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> In-Reply-To: <1464048292-30136-1-git-send-email-ynorov@caviumnetworks.com> Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-arch-owner@vger.kernel.org List-ID: To: Yury Norov , arnd@arndb.de, catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-s390@vger.kernel.org, libc-alpha@sourceware.org Cc: nd@arm.com, schwidefsky@de.ibm.com, heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org, joseph@codesourcery.com, christoph.muellner@theobroma-systems.com, bamvor.zhangjian@huawei.com, klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de, Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl, geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com Message-ID: <20160525104204.BWyY_0R-v2zD96_NbKYL5reNiVk-Pp18pEBjyy86r6A@z> On 24/05/16 01:04, Yury Norov wrote: > This version is based on kernel v4.6. > It works with glibc-2.23, and tested with LTP. > ... > ILP32 glibc branch is available here: > https://github.com/norov/glibc/tree/ilp32-2.23 > > It is tested with this series with no major downsides. I will send it to > glibc-alpha soon, after final revise. Please review and comment it as well. i spotted one __ilp32__ vs __ILP32__ typo in the glibc code, i can review it in detail when there is a cleaned up patch set. in general the approach seems ok, the ugly part is when lp64 and ilp32 share code, but ilp32 needs some tweaks compared to the current code (e.g. x vs w regs in asm, long changed to long long in syscalls, different relocations etc) those will be hard to review. the naming is sometimes _be_ilp32 sometimes ilp32_be, but let's hope there will be no new abi variant to confuse this further.