Re: [PATCH 5/8] x86, pkeys: allocation/free syscalls

Arnd Bergmann
2016-06-02T11:43:01Z

On Tuesday, May 31, 2016 8:28:22 AM CEST Dave Hansen wrote:
> diff -puN arch/x86/entry/syscalls/syscall_32.tbl~pkeys-116-syscalls-allocation arch/x86/entry/syscalls/syscall_32.tbl
> --- a/arch/x86/entry/syscalls/syscall_32.tbl~pkeys-116-syscalls-allocation 2016-05-31 08:27:49.150115539 -0700
> +++ b/arch/x86/entry/syscalls/syscall_32.tbl 2016-05-31 08:27:49.176116712 -0700
> @@ -387,3 +387,5 @@
> 378 i386 preadv2 sys_preadv2 compat_sys_preadv2
> 379 i386 pwritev2 sys_pwritev2 compat_sys_pwritev2
> 380 i386 pkey_mprotect sys_pkey_mprotect
> +381 i386 pkey_alloc sys_pkey_alloc
> +382 i386 pkey_free sys_pkey_free
> diff -puN arch/x86/entry/syscalls/syscall_64.tbl~pkeys-116-syscalls-allocation arch/x86/entry/syscalls/syscall_64.tbl
> --- a/arch/x86/entry/syscalls/syscall_64.tbl~pkeys-116-syscalls-allocation 2016-05-31 08:27:49.152115629 -0700
> +++ b/arch/x86/entry/syscalls/syscall_64.tbl 2016-05-31 08:27:49.177116758 -0700
> @@ -336,6 +336,8 @@
> 327 64 preadv2 sys_preadv2
> 328 64 pwritev2 sys_pwritev2
> 329 common pkey_mprotect sys_pkey_mprotect
> +330 common pkey_alloc sys_pkey_alloc
> +331 common pkey_free sys_pkey_free
>
> #
> # x32-specific system call numbers start at 512 to avoid cache impact
>

Could you also add the system call numbers to
include/uapi/asm-generic/unistd.h at the same time?

Even if the support is x86 specific for the forseeable future, it may
be good to reserve the number just in case.
The other architecture specific syscall lists are usually left to the
individual arch maintainers, most a lot of the newer architectures
share this table.

Arnd