From mboxrd@z Thu Jan 1 00:00:00 1970 From: Waiman Long Subject: Re: [RFC PATCH-tip v2 4/6] locking/rwsem: move down rwsem_down_read_failed function Date: Wed, 15 Jun 2016 15:21:13 -0400 Message-ID: <5761AAA9.1080406@hpe.com> References: <1465944489-43440-1-git-send-email-Waiman.Long@hpe.com> <1465944489-43440-5-git-send-email-Waiman.Long@hpe.com> <20160615174055.GS30921@twins.programming.kicks-ass.net> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160615174055.GS30921@twins.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, Davidlohr Bueso , Jason Low , Dave Chinner , Scott J Norton , Douglas Hatch List-Id: linux-arch.vger.kernel.org On 06/15/2016 01:40 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 06:48:07PM -0400, Waiman Long wrote: >> Move the rwsem_down_read_failed() function down to below the optimistic >> spinning section before enabling optimistic spinning for the readers. > newline > >> There is no change in code. > Changelog fails to explain the why part. Thanks for pointing this out. I will update the changelog to mention that the movement is needed because it is going to call rwsem_optimistic_spin() in later patch. Cheers, Longman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-by2on0132.outbound.protection.outlook.com ([207.46.100.132]:39005 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933133AbcFOTV3 (ORCPT ); Wed, 15 Jun 2016 15:21:29 -0400 Message-ID: <5761AAA9.1080406@hpe.com> Date: Wed, 15 Jun 2016 15:21:13 -0400 From: Waiman Long MIME-Version: 1.0 Subject: Re: [RFC PATCH-tip v2 4/6] locking/rwsem: move down rwsem_down_read_failed function References: <1465944489-43440-1-git-send-email-Waiman.Long@hpe.com> <1465944489-43440-5-git-send-email-Waiman.Long@hpe.com> <20160615174055.GS30921@twins.programming.kicks-ass.net> In-Reply-To: <20160615174055.GS30921@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Peter Zijlstra Cc: Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, linux-alpha@vger.kernel.org, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-arch@vger.kernel.org, Davidlohr Bueso , Jason Low , Dave Chinner , Scott J Norton , Douglas Hatch Message-ID: <20160615192113.O9rmNrrMwFgpnf3hk3ICVNfYjeS9HbYy384E5soxXpY@z> On 06/15/2016 01:40 PM, Peter Zijlstra wrote: > On Tue, Jun 14, 2016 at 06:48:07PM -0400, Waiman Long wrote: >> Move the rwsem_down_read_failed() function down to below the optimistic >> spinning section before enabling optimistic spinning for the readers. > newline > >> There is no change in code. > Changelog fails to explain the why part. Thanks for pointing this out. I will update the changelog to mention that the movement is needed because it is going to call rwsem_optimistic_spin() in later patch. Cheers, Longman