From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Simek Subject: Re: [PATCH 00/10] Hi, Date: Thu, 27 Feb 2020 08:31:28 +0100 Message-ID: <5dfa98df-8955-59fd-1d65-c0a988190acb@xilinx.com> References: <0f8140c1-da6f-ef04-0809-252d6de6a5d7@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-dm6nam12on2064.outbound.protection.outlook.com ([40.107.243.64]:4011 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726999AbgB0Hby (ORCPT ); Thu, 27 Feb 2020 02:31:54 -0500 In-Reply-To: Content-Language: en-US Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring , Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , git , Arnd Bergmann , Andrew Morton , "Aneesh Kumar K.V" , Arvind Sankar , Borislav Petkov , Cornelia Huck , Geert Uytterhoeven , Greg Kroah-Hartman , Greg Ungerer , Heiko Carstens , Kees Cook , Masahiro Yamada , Mike Rapoport , Mubin Sayyed , Nicholas Piggin , Oleg Nesterov , Palmer On 25. 02. 20 17:32, Rob Herring wrote: > On Mon, Feb 17, 2020 at 8:28 AM Michal Simek wrote: >> >> Hi Rob, >> >> On 14. 02. 20 0:47, Rob Herring wrote: >>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek wrote: >>>> >>>> >>>> I am sending this series as before SMP support. >>>> Most of these patches are clean ups and should be easy to review them. I >>>> expect there will be more discussions about SMP support. >>> >>> While not really related to adding SMP, any chance you or someone >>> could look at moving microblaze PCI support to drivers/pci/? I suspect >>> much of the code should drop out as we have common helpers for much of >>> it now. That would leave only powerpc and mips for DT+PCI platforms. >> >> can you please suggest changes which could be done? >> I have CC Bharat and he could look at it. > > Look at the host controller drivers in drivers/pci/controller/. > pci-host-{generic,common}.c is a good template to start with as that's > a controller with standard config space accesses and no h/w setup > needed. Essentially you need to call devm_pci_alloc_host_bridge(), > pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever > h/w setup you need in between those calls. > > Looking at the microblaze PCI code, looks like you may need custom > config space accessors which is quite common. Probably all the > resource and device scanning can be removed. If you look at arm64, all > the arch PCI code is just for ACPI. Thanks Rob. Bharat: Can you please take a look? Thanks, Michal From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-dm6nam12on2064.outbound.protection.outlook.com ([40.107.243.64]:4011 "EHLO NAM12-DM6-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726999AbgB0Hby (ORCPT ); Thu, 27 Feb 2020 02:31:54 -0500 Subject: Re: [PATCH 00/10] Hi, References: <0f8140c1-da6f-ef04-0809-252d6de6a5d7@xilinx.com> From: Michal Simek Message-ID: <5dfa98df-8955-59fd-1d65-c0a988190acb@xilinx.com> Date: Thu, 27 Feb 2020 08:31:28 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Rob Herring , Michal Simek Cc: "linux-kernel@vger.kernel.org" , Michal Simek , git , Arnd Bergmann , Andrew Morton , "Aneesh Kumar K.V" , Arvind Sankar , Borislav Petkov , Cornelia Huck , Geert Uytterhoeven , Greg Kroah-Hartman , Greg Ungerer , Heiko Carstens , Kees Cook , Masahiro Yamada , Mike Rapoport , Mubin Sayyed , Nicholas Piggin , Oleg Nesterov , Palmer Dabbelt , Paolo Bonzini , Peter Zijlstra , Randy Dunlap , Shubhrajyoti Datta , Siva Durga Prasad Paladugu , Stefan Asserhall , Vladimir Murzin , Will Deacon , "open list:GENERIC INCLUDE/ASM HEADER FILES" , linux-mm@kvack.org, Bharat Kumar Gogada Message-ID: <20200227073128.l_lmywRdfVRHL3tpq0lDSBEtbuupBOOuZsOPm-Rqh3I@z> On 25. 02. 20 17:32, Rob Herring wrote: > On Mon, Feb 17, 2020 at 8:28 AM Michal Simek wrote: >> >> Hi Rob, >> >> On 14. 02. 20 0:47, Rob Herring wrote: >>> On Wed, Feb 12, 2020 at 2:58 AM Michal Simek wrote: >>>> >>>> >>>> I am sending this series as before SMP support. >>>> Most of these patches are clean ups and should be easy to review them. I >>>> expect there will be more discussions about SMP support. >>> >>> While not really related to adding SMP, any chance you or someone >>> could look at moving microblaze PCI support to drivers/pci/? I suspect >>> much of the code should drop out as we have common helpers for much of >>> it now. That would leave only powerpc and mips for DT+PCI platforms. >> >> can you please suggest changes which could be done? >> I have CC Bharat and he could look at it. > > Look at the host controller drivers in drivers/pci/controller/. > pci-host-{generic,common}.c is a good template to start with as that's > a controller with standard config space accesses and no h/w setup > needed. Essentially you need to call devm_pci_alloc_host_bridge(), > pci_parse_request_of_pci_ranges() and pci_host_probe() with whatever > h/w setup you need in between those calls. > > Looking at the microblaze PCI code, looks like you may need custom > config space accessors which is quite common. Probably all the > resource and device scanning can be removed. If you look at arm64, all > the arch PCI code is just for ACPI. Thanks Rob. Bharat: Can you please take a look? Thanks, Michal