From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael Kerrisk (man-pages)" Subject: Re: [PATCH 10/14] prctl.2: Add PR_SPEC_INDIRECT_BRANCH for SPECULATION_CTRL prctls Date: Wed, 13 May 2020 14:06:38 +0200 Message-ID: <604879eb-1c7e-d08b-a6b8-165e4259b60c@gmail.com> References: <1589301419-24459-1-git-send-email-Dave.Martin@arm.com> <1589301419-24459-11-git-send-email-Dave.Martin@arm.com> <20200513114915.GL21779@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <20200513114915.GL21779-5wv7dgnIgG8@public.gmane.org> Content-Language: en-US Sender: linux-man-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Dave Martin Cc: mtk.manpages-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-man-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Tim Chen , Thomas Gleixner List-Id: linux-arch.vger.kernel.org On 5/13/20 1:49 PM, Dave Martin wrote: > On Wed, May 13, 2020 at 01:21:12PM +0200, Michael Kerrisk (man-pages) wrote: >> Hello Dave, >> >> On 5/12/20 6:36 PM, Dave Martin wrote: >>> Add the PR_SPEC_INDIRECT_BRANCH "misfeature" added in Linux 4.20 >>> for PR_SET_SPECULATION_CTRL and PR_GET_SPECULATION_CTRL. >>> >>> Signed-off-by: Dave Martin >>> Cc: Tim Chen >>> Cc: Thomas Gleixner >> >> Thanks. Patch applied, but not yet pushed while I wait to see if any >> Review/Ack arrives. >> >> Also, could you please check the tweaks I note below. >> >>> --- >>> man2/prctl.2 | 24 ++++++++++++++++++------ >>> 1 file changed, 18 insertions(+), 6 deletions(-) >>> >>> diff --git a/man2/prctl.2 b/man2/prctl.2 >>> index e8eaf95..66417cf 100644 >>> --- a/man2/prctl.2 >>> +++ b/man2/prctl.2 >>> @@ -1213,11 +1213,20 @@ arguments must be specified as 0; otherwise the call fails with the error >>> .\" commit 356e4bfff2c5489e016fdb925adbf12a1e3950ee >>> Sets the state of the speculation misfeature specified in >>> .IR arg2 . >>> -Currently, the only permitted value for this argument is >>> +Currently, this argument must be one of: >>> +.RS >>> +.TP >>> .B PR_SPEC_STORE_BYPASS >>> -(otherwise the call fails with the error >>> +speculative store bypass control, or >> >> s/speculative/enable speculative/ >> >>> +.\" commit 9137bb27e60e554dab694eafa4cca241fa3a694f >>> +.TP >>> +.BR PR_SPEC_INDIRECT_BRANCH " (since Linux 4.20)" >>> +indirect branch speculation control. >> >> s/indirect/enable indirect/ > > That doesn't seem quite right. My goof, not looking at the bigger context of the patch. > > arg2 just identifies what behaviour to configure. > It's arg3 that says whether to disable / enable it or whatever. > > > While editing this I did wonder whether the "control" was helpful. > Maybe just dropping that word from these entries would help. Okay I tried to fix things, and made also some other edits. How does the following look to you? PR_SET_SPECULATION_CTRL (since Linux 4.17) Sets the state of the speculation misfeature specified in arg2. The speculation-misfeature settings are per-thread attributes. Currently, arg2 must be one of: PR_SPEC_STORE_BYPASS Set the state of the speculative store bypass mis‐ feature. PR_SPEC_INDIRECT_BRANCH (since Linux 4.20) Set the state of the indirect branch speculation misfeature. If arg2 does not have one of the above values, then the call fails with the error ENODEV. The arg3 argument is used to hand in the control value, which is one of the following: ... Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42322 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727778AbgEMMGl (ORCPT ); Wed, 13 May 2020 08:06:41 -0400 Subject: Re: [PATCH 10/14] prctl.2: Add PR_SPEC_INDIRECT_BRANCH for SPECULATION_CTRL prctls References: <1589301419-24459-1-git-send-email-Dave.Martin@arm.com> <1589301419-24459-11-git-send-email-Dave.Martin@arm.com> <20200513114915.GL21779@arm.com> From: "Michael Kerrisk (man-pages)" Message-ID: <604879eb-1c7e-d08b-a6b8-165e4259b60c@gmail.com> Date: Wed, 13 May 2020 14:06:38 +0200 MIME-Version: 1.0 In-Reply-To: <20200513114915.GL21779@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Dave Martin Cc: mtk.manpages@gmail.com, linux-man@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Tim Chen , Thomas Gleixner Message-ID: <20200513120638.FDlTvTF4Gvn4rMvilUOtFcRb2sYyL-V0TSofxh044LA@z> On 5/13/20 1:49 PM, Dave Martin wrote: > On Wed, May 13, 2020 at 01:21:12PM +0200, Michael Kerrisk (man-pages) wrote: >> Hello Dave, >> >> On 5/12/20 6:36 PM, Dave Martin wrote: >>> Add the PR_SPEC_INDIRECT_BRANCH "misfeature" added in Linux 4.20 >>> for PR_SET_SPECULATION_CTRL and PR_GET_SPECULATION_CTRL. >>> >>> Signed-off-by: Dave Martin >>> Cc: Tim Chen >>> Cc: Thomas Gleixner >> >> Thanks. Patch applied, but not yet pushed while I wait to see if any >> Review/Ack arrives. >> >> Also, could you please check the tweaks I note below. >> >>> --- >>> man2/prctl.2 | 24 ++++++++++++++++++------ >>> 1 file changed, 18 insertions(+), 6 deletions(-) >>> >>> diff --git a/man2/prctl.2 b/man2/prctl.2 >>> index e8eaf95..66417cf 100644 >>> --- a/man2/prctl.2 >>> +++ b/man2/prctl.2 >>> @@ -1213,11 +1213,20 @@ arguments must be specified as 0; otherwise the call fails with the error >>> .\" commit 356e4bfff2c5489e016fdb925adbf12a1e3950ee >>> Sets the state of the speculation misfeature specified in >>> .IR arg2 . >>> -Currently, the only permitted value for this argument is >>> +Currently, this argument must be one of: >>> +.RS >>> +.TP >>> .B PR_SPEC_STORE_BYPASS >>> -(otherwise the call fails with the error >>> +speculative store bypass control, or >> >> s/speculative/enable speculative/ >> >>> +.\" commit 9137bb27e60e554dab694eafa4cca241fa3a694f >>> +.TP >>> +.BR PR_SPEC_INDIRECT_BRANCH " (since Linux 4.20)" >>> +indirect branch speculation control. >> >> s/indirect/enable indirect/ > > That doesn't seem quite right. My goof, not looking at the bigger context of the patch. > > arg2 just identifies what behaviour to configure. > It's arg3 that says whether to disable / enable it or whatever. > > > While editing this I did wonder whether the "control" was helpful. > Maybe just dropping that word from these entries would help. Okay I tried to fix things, and made also some other edits. How does the following look to you? PR_SET_SPECULATION_CTRL (since Linux 4.17) Sets the state of the speculation misfeature specified in arg2. The speculation-misfeature settings are per-thread attributes. Currently, arg2 must be one of: PR_SPEC_STORE_BYPASS Set the state of the speculative store bypass mis‐ feature. PR_SPEC_INDIRECT_BRANCH (since Linux 4.20) Set the state of the indirect branch speculation misfeature. If arg2 does not have one of the above values, then the call fails with the error ENODEV. The arg3 argument is used to hand in the control value, which is one of the following: ... Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/