Re: [PATCH v3 03/13] x86/mm: Remove kernel_unmap_pages_in_pgd() and efi_cleanup_page_tables()

Matt Fleming
2016-06-21T09:53:42Z

On Mon, 20 Jun, at 04:43:33PM, Andy Lutomirski wrote:
> kernel_unmap_pages_in_pgd() is dangerous: if a pgd entry in
> init_mm.pgd were to be cleared, callers would need to ensure that
> the pgd entry hadn't been propagated to any other pgd.
>
> Its only caller was efi_cleanup_page_tables(), and that, in turn,
> was unused, so just delete both functions. This leaves a couple of
> other helpers unused, so delete them, too.
>
> Cc: Matt Fleming <matt@codeblueprint.co.uk>
> Cc: linux-efi@vger.kernel.org
> Signed-off-by: Andy Lutomirski <luto@kernel.org>
> ---
> arch/x86/include/asm/efi.h | 1 -
> arch/x86/include/asm/pgtable_types.h | 2 --
> arch/x86/mm/pageattr.c | 28 ----------------------------
> arch/x86/platform/efi/efi.c | 2 --
> arch/x86/platform/efi/efi_32.c | 3 ---
> arch/x86/platform/efi/efi_64.c | 5 -----
> 6 files changed, 41 deletions(-)

Looks fine.

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>