From: David Howells <dhowells@redhat.com>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, rusty@rustcorp.com.au,
linux-arch@vger.kernel.org, randy.dunlap@oracle.com
Subject: Re: + expose-range-checking-functions-from-arch-specific.patch added to -mm tree
Date: Tue, 10 Apr 2007 11:17:50 +0100 [thread overview]
Message-ID: <6632.1176200270@redhat.com> (raw)
In-Reply-To: <200704062127.l36LRMA7019394@shell0.pdx.osdl.net>
akpm@linux-foundation.org wrote:
> + * @limit: the first invalid value
If this is the case, ...
> + *
> + * Like val + len > limit, except with overflow checking.
> + */
> +static inline bool val_outside(unsigned long val, unsigned long len,
> + unsigned long limit)
> +
> +{
> + return val + len > limit || val + len < val;
... then shouldn't that be "val + len >= limit"?
David
next prev parent reply other threads:[~2007-04-10 10:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-06 21:27 + expose-range-checking-functions-from-arch-specific.patch added to -mm tree akpm
2007-04-10 10:17 ` David Howells [this message]
2007-04-11 2:19 ` Rusty Russell
2007-04-11 2:48 ` Andrew Morton
2007-04-11 10:49 ` David Howells
2007-04-11 18:24 ` Andrew Morton
2007-04-11 23:28 ` Rusty Russell
2007-04-12 16:05 ` + expose-range-checking-functions-from-arch-specific.patchadded " Luck, Tony
2007-04-13 0:08 ` Rusty Russell
2007-04-11 23:41 ` + expose-range-checking-functions-from-arch-specific.patch added " Rusty Russell
2007-04-12 10:47 ` David Howells
2007-04-12 14:51 ` Randy Dunlap
2007-04-12 7:42 ` Geert Uytterhoeven
2007-04-11 13:17 ` Rusty Russell
2007-04-11 17:03 ` David Howells
2007-04-11 18:31 ` Andrew Morton
2007-04-11 19:17 ` David Howells
2007-04-11 22:52 ` Rusty Russell
2007-04-12 10:49 ` David Howells
2007-04-11 10:47 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6632.1176200270@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-arch@vger.kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).