From: Arnd Bergmann <arnd@arndb.de>
To: libc-alpha@sourceware.org
Cc: Bamvor Jian Zhang <bamvor.zhangjian@huawei.com>,
Yury Norov <ynorov@caviumnetworks.com>,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arch@vger.kernel.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org,
joseph@codesourcery.com,
christoph.muellner@theobroma-systems.com, szabolcs.nagy@arm.com,
klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de,
Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl,
geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com,
manuel.montezelo@gmail.com, linyongting@huawei.com,
maxim.kuvyrkov@linaro.org, davem@davemloft.net,
zhouchengming1@huawei.com, cmetcalf@ezchip.com,
Andrew Pinski <apinski@cavium.com>
Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it
Date: Fri, 02 Sep 2016 14:55:34 +0200 [thread overview]
Message-ID: <6815916.BISHOLF1Ut@wuerfel> (raw)
In-Reply-To: <57C9587B.9080006@huawei.com>
On Friday, September 2, 2016 6:46:19 PM CEST Bamvor Jian Zhang wrote:
> diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h
> index 043d17a..78bea1d 100644
> --- a/arch/arm64/include/uapi/asm/unistd.h
> +++ b/arch/arm64/include/uapi/asm/unistd.h
> @@ -16,4 +16,9 @@
>
> #define __ARCH_WANT_RENAMEAT
>
> +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */
> +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT)
> +#define __ARCH_WANT_SYNC_FILE_RANGE2
> +#endif
> +
> #include <asm-generic/unistd.h>
> diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c
> index 10fc0ca..13c9c9d 100644
> --- a/arch/arm64/kernel/sys_ilp32.c
> +++ b/arch/arm64/kernel/sys_ilp32.c
> @@ -42,7 +42,7 @@
> #define compat_sys_pwrite64 compat_sys_pwrite64_wrapper
> #define compat_sys_readahead compat_sys_readahead_wrapper
> #define compat_sys_shmat sys_shmat
> -#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper
> +#define compat_sys_sync_file_range2 compat_sys_sync_file_range2_wrapper
> #define compat_sys_truncate64 compat_sys_truncate64_wrapper
> #define sys_mmap2 compat_sys_mmap2_wrapper
> #define sys_ptrace compat_sys_ptrace
>
Looks good to me.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: libc-alpha@sourceware.org
Cc: Bamvor Jian Zhang <bamvor.zhangjian@huawei.com>,
Yury Norov <ynorov@caviumnetworks.com>,
catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-arch@vger.kernel.org, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, pinskia@gmail.com, broonie@kernel.org,
joseph@codesourcery.com,
christoph.muellner@theobroma-systems.com, szabolcs.nagy@arm.com,
klimov.linux@gmail.com, Nathan_Lynch@mentor.com, agraf@suse.de,
Prasun.Kapoor@caviumnetworks.com, kilobyte@angband.pl,
geert@linux-m68k.org, philipp.tomsich@theobroma-systems.com,
manuel.montezelo@gmail.com, linyongting@huawei.com,
maxim.kuvyrkov@linaro.org, davem@davemloft.net,
zhouchengming1@huawei.com, cmetcalf@ezchip.com,
Andrew Pinski <apinski@cavium.com>,
Andrew Pinski <Andrew.Pinski@caviumnetworks.com>,
Hanjun Guo <guohanjun@huawei.com>,
chenjianguo 00365834 <chenjianguo3@huawei.com>,
jijun 00321192 <jijun2@huawei.com>
Subject: Re: [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it
Date: Fri, 02 Sep 2016 14:55:34 +0200 [thread overview]
Message-ID: <6815916.BISHOLF1Ut@wuerfel> (raw)
Message-ID: <20160902125534.Z7bU2hzOcxzcwclgLn9F0RgXHzAWgqPxHQIDqDYL3IA@z> (raw)
In-Reply-To: <57C9587B.9080006@huawei.com>
On Friday, September 2, 2016 6:46:19 PM CEST Bamvor Jian Zhang wrote:
> diff --git a/arch/arm64/include/uapi/asm/unistd.h b/arch/arm64/include/uapi/asm/unistd.h
> index 043d17a..78bea1d 100644
> --- a/arch/arm64/include/uapi/asm/unistd.h
> +++ b/arch/arm64/include/uapi/asm/unistd.h
> @@ -16,4 +16,9 @@
>
> #define __ARCH_WANT_RENAMEAT
>
> +/* We need to make sure it works for both userspace and kernel(sys_ilp32.c) */
> +#if defined(__ILP32__) || defined(__SYSCALL_COMPAT)
> +#define __ARCH_WANT_SYNC_FILE_RANGE2
> +#endif
> +
> #include <asm-generic/unistd.h>
> diff --git a/arch/arm64/kernel/sys_ilp32.c b/arch/arm64/kernel/sys_ilp32.c
> index 10fc0ca..13c9c9d 100644
> --- a/arch/arm64/kernel/sys_ilp32.c
> +++ b/arch/arm64/kernel/sys_ilp32.c
> @@ -42,7 +42,7 @@
> #define compat_sys_pwrite64 compat_sys_pwrite64_wrapper
> #define compat_sys_readahead compat_sys_readahead_wrapper
> #define compat_sys_shmat sys_shmat
> -#define compat_sys_sync_file_range compat_sys_sync_file_range2_wrapper
> +#define compat_sys_sync_file_range2 compat_sys_sync_file_range2_wrapper
> #define compat_sys_truncate64 compat_sys_truncate64_wrapper
> #define sys_mmap2 compat_sys_mmap2_wrapper
> #define sys_ptrace compat_sys_ptrace
>
Looks good to me.
Arnd
next prev parent reply other threads:[~2016-09-02 12:55 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-17 11:46 [RFC2 nowrap: PATCH v7 00/18] ILP32 for ARM64 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 01/18] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 02/18] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 03/18] arm64: ensure the kernel is compiled for LP64 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 04/18] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 05/18] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2016-08-17 11:46 ` [PATCH 06/18] thread: move thread bits accessors to separated file Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 07/18] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 08/18] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 09/18] arm64: introduce binfmt_elf32.c Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 10/18] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 11/18] arm64: ilp32: share aarch32 syscall handlers Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-09-02 10:46 ` Bamvor Jian Zhang
2016-09-02 10:46 ` Bamvor Jian Zhang
2016-09-02 12:55 ` Arnd Bergmann [this message]
2016-09-02 12:55 ` Arnd Bergmann
2016-09-02 13:04 ` Yury Norov
2016-09-02 13:04 ` Yury Norov
2016-08-17 11:46 ` [PATCH 13/18] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 14/18] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2016-08-17 11:46 ` [PATCH 15/18] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 16/18] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 11:46 ` [PATCH 17/18] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 13:18 ` Andreas Schwab
2016-08-17 11:46 ` [PATCH 18/18] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2016-08-17 11:46 ` Yury Norov
2016-08-17 12:28 ` [RFC2 nowrap: PATCH v7 00/18] ILP32 for ARM64 Alexander Graf
2016-08-17 12:48 ` Yury Norov
2016-08-17 12:48 ` Yury Norov
2016-08-17 12:54 ` Dr. Philipp Tomsich
2016-08-17 12:54 ` Dr. Philipp Tomsich
2016-08-17 14:29 ` Catalin Marinas
2016-08-17 14:29 ` Catalin Marinas
2016-08-17 14:32 ` Dr. Philipp Tomsich
2016-08-17 14:32 ` Dr. Philipp Tomsich
2016-08-17 15:26 ` Catalin Marinas
2016-08-17 15:26 ` Catalin Marinas
2016-08-18 9:45 ` Yury Norov
2016-08-18 9:45 ` Yury Norov
2016-09-02 10:20 ` Bamvor Jian Zhang
2016-09-02 10:20 ` Bamvor Jian Zhang
-- strict thread matches above, loose matches on Subject: below --
2016-10-21 20:32 [RFC3 " Yury Norov
2016-10-21 20:33 ` [PATCH 12/18] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2016-10-21 20:33 ` Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6815916.BISHOLF1Ut@wuerfel \
--to=arnd@arndb.de \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=apinski@cavium.com \
--cc=bamvor.zhangjian@huawei.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=christoph.muellner@theobroma-systems.com \
--cc=cmetcalf@ezchip.com \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=joseph@codesourcery.com \
--cc=kilobyte@angband.pl \
--cc=klimov.linux@gmail.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyongting@huawei.com \
--cc=manuel.montezelo@gmail.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=schwidefsky@de.ibm.com \
--cc=szabolcs.nagy@arm.com \
--cc=ynorov@caviumnetworks.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).