From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B1EB3C07A; Fri, 10 Apr 2026 03:19:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775791191; cv=none; b=YPx7D2ukJINjVyoFEggseMy8WvishcTeQpd34BdBA4OKWqMjQJ6xXh5BAqj8f5uNvw5djOFQQMqNf3z88RcLvxuCHCxwhSRjOmk9AXIk+BYhLjBCPj4eKB/bho4QYa1QatDf88B7ymJrrvUYKKY8NeT2qcPl3uCzs4qvgLRZVgI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775791191; c=relaxed/simple; bh=++Koq39UWrgs6Y9/teNpfuGX4Prd7yZehxjZlfBpaLk=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: Mime-Version:Content-Type; b=Ak0nrvXkPexITmWLxBs7XylQK+RYfnICDTD60Y6sA7K0Q038mPcgp661khz47fXka2ISiV0cLqgihMmp2a54s/XZ/yzHzuhNZJ4HuYOqQ8DwcdvuH7Ru0kBuG0gaxSkPimHXhKlfFDSM7IKq3zUl4elUACKjw28WExZx3WDqx1I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XliNMAwV; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XliNMAwV" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A58AAC116C6; Fri, 10 Apr 2026 03:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1775791190; bh=++Koq39UWrgs6Y9/teNpfuGX4Prd7yZehxjZlfBpaLk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=XliNMAwVPQqvLfHAreBvvnypr8I9CKJLGLuXd5oM+g9gygnfolGrtVyL6RQ/jT8EE NWhsrlT9QPJSFKOCQi8DHFNBuzHufJqSU25F03B2cYM/QQmiGn5sn6o26qJL4GZTNh 7Mj/vCYrjofvYVtgMoRCsFjn5TllB+H/gagaWHX7dQnPRcVAggH9YoldRgaI2QQdXO U05TFDVRhQ0u0tCPAhBXcM3Z2F/u+XfbWWAz8uT1J4oaOwmFdk0tPN4Kl6CYAOpjCY qzbFZUntNydp97AMg25LA7tazuK3JQqoDkVoDsRCBQcI3zs1J/cxi4spQ3a9HdT7Qt 1yNyrVBsYutPQ== Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfauth.phl.internal (Postfix) with ESMTP id BEAFCF4007B; Thu, 9 Apr 2026 23:19:48 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Thu, 09 Apr 2026 23:19:48 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefhedrtddtgddvkedvlecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpeffhffvvefkjghfufggtgfgsehtjeertddttdejnecuhfhrohhmpeffrghnucghihhl lhhirghmshcuoegujhgsfieskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpe elhfeiudfgvdeijedtleeltdduueekffejjedvjefhgeevjeefueejledtleetjeenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegujhgsfidomh gvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudejjedvfedtgeehhedqfeeffeel gedtgeejqdgujhgsfieppehkvghrnhgvlhdrohhrghesfhgrshhtmhgrihhlrdgtohhmpd hnsggprhgtphhtthhopeehjedpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohephhgt hheslhhsthdruggvpdhrtghpthhtoheprhhitghhrghrugdrhhgvnhguvghrshhonheslh hinhgrrhhordhorhhgpdhrtghpthhtohepmhgrthhtshhtkeeksehgmhgrihhlrdgtohhm pdhrtghpthhtoheplhhinhhmrghgjeesghhmrghilhdrtghomhdprhgtphhtthhopehlih hnuhigsegrrhhmlhhinhhugidrohhrghdruhhkpdhrtghpthhtoheptggrthgrlhhinhdr mhgrrhhinhgrshesrghrmhdrtghomhdprhgtphhtthhopeifihhllheskhgvrhhnvghlrd horhhgpdhrtghpthhtoheprghruggssehkvghrnhgvlhdrohhrghdprhgtphhtthhopegt hhgvnhhhuhgrtggriheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i67ae4b3e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Apr 2026 23:19:47 -0400 (EDT) Date: Thu, 09 Apr 2026 20:19:47 -0700 From: Dan Williams To: Christoph Hellwig Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Russell King , Catalin Marinas , Will Deacon , Ard Biesheuvel , Huacai Chen , WANG Xuerui , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , "Christophe Leroy (CS GROUP)" , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , "David S. Miller" , Andreas Larsson , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Herbert Xu , Dan Williams , Chris Mason , David Sterba , Arnd Bergmann , Song Liu , Yu Kuai , Li Nan , Theodore Ts'o , "Jason A. Donenfeld" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-crypto@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-arch@vger.kernel.org, linux-raid@vger.kernel.org Message-ID: <69d86c53cfc4_2b31100e7@djbw-dev.notmuch> In-Reply-To: <20260327061704.3707577-25-hch@lst.de> References: <20260327061704.3707577-1-hch@lst.de> <20260327061704.3707577-25-hch@lst.de> Subject: Re: [PATCH 24/28] async_xor: use xor_gen Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Christoph Hellwig wrote: > Replace use of the loop around xor_blocks with the easier to use xor_gen > API. > > Signed-off-by: Christoph Hellwig > --- > crypto/async_tx/async_xor.c | 34 ++++++++++------------------------ > 1 file changed, 10 insertions(+), 24 deletions(-) [..] > @@ -168,11 +156,10 @@ dma_xor_aligned_offsets(struct dma_device *device, unsigned int offset, > * > * honored flags: ASYNC_TX_ACK, ASYNC_TX_XOR_ZERO_DST, ASYNC_TX_XOR_DROP_DST > * > - * xor_blocks always uses the dest as a source so the > - * ASYNC_TX_XOR_ZERO_DST flag must be set to not include dest data in > - * the calculation. The assumption with dma engines is that they only > - * use the destination buffer as a source when it is explicitly specified > - * in the source list. > + * xor_gen always uses the dest as a source so the ASYNC_TX_XOR_ZERO_DST flag > + * must be set to not include dest data in the calculation. The assumption with > + * dma engines is that they only use the destination buffer as a source when it > + * is explicitly specified in the source list. > * > * src_list note: if the dest is also a source it must be at index zero. > * The contents of this array will be overwritten if a scribble region > @@ -259,11 +246,10 @@ EXPORT_SYMBOL_GPL(async_xor_offs); > * > * honored flags: ASYNC_TX_ACK, ASYNC_TX_XOR_ZERO_DST, ASYNC_TX_XOR_DROP_DST > * > - * xor_blocks always uses the dest as a source so the > - * ASYNC_TX_XOR_ZERO_DST flag must be set to not include dest data in > - * the calculation. The assumption with dma engines is that they only > - * use the destination buffer as a source when it is explicitly specified > - * in the source list. > + * xor_gen always uses the dest as a source so the ASYNC_TX_XOR_ZERO_DST flag > + * must be set to not include dest data in the calculation. The assumption with > + * dma engines is that they only use the destination buffer as a source when it > + * is explicitly specified in the source list. In retrospect, no need to duplicate this help, but as is: Reviewed-by: Dan Williams