From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD82C41513 for ; Fri, 11 Aug 2023 14:27:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235944AbjHKO07 (ORCPT ); Fri, 11 Aug 2023 10:26:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235993AbjHKO06 (ORCPT ); Fri, 11 Aug 2023 10:26:58 -0400 Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3938B30C8; Fri, 11 Aug 2023 07:26:57 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id DAF7B3200918; Fri, 11 Aug 2023 10:26:55 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 11 Aug 2023 10:26:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1691764015; x=1691850415; bh=FP +WVqD4FWw/1GEA6CcYKtr0HgvONb8SncErIfqh1+g=; b=DJtxgYEDfYvGa1fJTF Nm7EXNZMwhpC4FXqSPoDRPGx9dzcAVhJfVOE7cdz4DKxI6qz7ous8YB4GwD1Nz8I xA0L6Sx9i1RD9NHG4grDbmMCBeFfkuou3UvhViPJhENaDpTD0LYHH9YZfeGuTadv 8MyeBe5d50SRr9+7N6ySJqkeNR4ySTkKaDxTaKAOV8Q0psLcDnuIOxU9zlwQ2gOv uWu6/tL4QmdDA3Jc6/O3jGLyIzn/Y9rs97O72v+YZYjn1LzAGJWbc56ltIs6BCfj fzmzgySVgcQYgU/jzEvcMj8Q3q07XDLnPshQTPyT26ABJwC91IJEC4y4rInF27Cj t26A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1691764015; x=1691850415; bh=FP+WVqD4FWw/1 GEA6CcYKtr0HgvONb8SncErIfqh1+g=; b=pKWFoDJDyfEhdBFi/1kKATeuIQ70I s7Sd4dSp3eP6hCNuj2jCsgWg4vrCL8cPjxDUIsdQBRUJOOJ8LRYgIEuVRFaAz7wH sct4EKVxgPMuVX+fpLhybHnmxDlEOuS1H6tOOHGvTYhikbro84+zzkZRZZOqafUj uZtl0xnW1E6lpxG2dIYVR5HQYIgebMH0nJZDYembMKuTBIv7uwhhJAfn7p4TDljr HrT6kcsVVl1/v7XZOo2FngrZGiClbWCP1o9yAHGaf+3h+ZCT6DjmYLBlVcspgwo9 3B5TrUhElPgUgnxfPICwAceCgipS7l65FEBPd996smlnMZeT8VVbuQg5w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrleekgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesthdtredtreertdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusgdruggvqeenucggtffrrghtth gvrhhnpeffheeugeetiefhgeethfejgfdtuefggeejleehjeeutefhfeeggefhkedtkeet ffenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrrh hnugesrghrnhgusgdruggv X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id DC2D6B60089; Fri, 11 Aug 2023 10:26:54 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-624-g7714e4406d-fm-20230801.001-g7714e440 Mime-Version: 1.0 Message-Id: <6e1c3faf-83f3-4627-bd74-42fea5b88dfb@app.fastmail.com> In-Reply-To: <20230811141943.GB3948268@dev-arch.thelio-3990X> References: <20230811140327.3754597-1-arnd@kernel.org> <20230811140327.3754597-3-arnd@kernel.org> <20230811141943.GB3948268@dev-arch.thelio-3990X> Date: Fri, 11 Aug 2023 16:26:34 +0200 From: "Arnd Bergmann" To: "Nathan Chancellor" , "Arnd Bergmann" Cc: "Masahiro Yamada" , "Nick Desaulniers" , "Nicolas Schier" , "Guenter Roeck" , "Lee Jones" , "Stephen Rothwell" , linux-kbuild@vger.kernel.org, Linux-Arch Subject: Re: [PATCH 2/9] Kbuild: consolidate warning flags in scripts/Makefile.extrawarn Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arch@vger.kernel.org On Fri, Aug 11, 2023, at 16:19, Nathan Chancellor wrote: > On Fri, Aug 11, 2023 at 04:03:20PM +0200, Arnd Bergmann wrote: >> From: Arnd Bergmann >> >> Warning options are enabled and disabled in inconsistent ways and >> inconsistent locations. Start rearranging those by moving all options >> into Makefile.extrawarn. >> >> This should not change any behavior, but makes sure we can group them >> in a way that ensures that each warning that got temporarily disabled >> is turned back on at an appropriate W=1 level later on. >> >> Signed-off-by: Arnd Bergmann >> --- >> Makefile | 88 ------------------------------------- >> scripts/Makefile.extrawarn | 90 ++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 90 insertions(+), 88 deletions(-) > > This shuffle seems reasonable to me. Would it make sense to rename the > Makefile from Makefile.extrawarn to just Makefile.warn or > Makefile.warnings? They are still "extra" warnings but to me, the > meaning of the Makefile is changing so it seems reasonable to drop the > "extra" part. Renaming the file seems fine, but I'd much prefer to do that separately if we decide to do it, otherwise rebasing my patches is going to be even more painful. Arnd