From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu-cheng Yu Subject: Re: [RFC PATCH v9 04/27] x86/cet: Add control-protection fault handler Date: Thu, 05 Mar 2020 12:44:19 -0800 Message-ID: <6e9214021448a04bfad823535eaa2320496fdabf.camel@intel.com> References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-5-yu-cheng.yu@intel.com> <0bc74a85-7058-0cca-62b8-949c8a881c62@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <0bc74a85-7058-0cca-62b8-949c8a881c62@intel.com> Sender: linux-doc-owner@vger.kernel.org To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz List-Id: linux-arch.vger.kernel.org On Wed, 2020-02-26 at 09:10 -0800, Dave Hansen wrote: > On 2/5/20 10:19 AM, Yu-cheng Yu wrote: > > diff --git a/arch/x86/kernel/idt.c b/arch/x86/kernel/idt.c > > index 87ef69a72c52..8ed406f469e7 100644 > > --- a/arch/x86/kernel/idt.c > > +++ b/arch/x86/kernel/idt.c > > @@ -102,6 +102,10 @@ static const __initconst struct idt_data def_idts[] = { > > #elif defined(CONFIG_X86_32) > > SYSG(IA32_SYSCALL_VECTOR, entry_INT80_32), > > #endif > > + > > +#ifdef CONFIG_X86_64 > > + INTG(X86_TRAP_CP, control_protection), > > +#endif > > }; > > This patch in particular appears to have all of its code unconditionally > compiled in. That's in contrast to things that have Kconfig options, like: > > #ifdef CONFIG_X86_MCE > INTG(X86_TRAP_MC, &machine_check), > #endif > > or: > > #ifdef CONFIG_X86_THERMAL_VECTOR > INTG(THERMAL_APIC_VECTOR, thermal_interrupt), > #endif > > Is there a reason this code is always compiled in on 64-bit even when > the config option is off? I will change it to CONFIG_X86_INTEL_CET. Yu-cheng From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <6e9214021448a04bfad823535eaa2320496fdabf.camel@intel.com> Subject: Re: [RFC PATCH v9 04/27] x86/cet: Add control-protection fault handler From: Yu-cheng Yu Date: Thu, 05 Mar 2020 12:44:19 -0800 In-Reply-To: <0bc74a85-7058-0cca-62b8-949c8a881c62@intel.com> References: <20200205181935.3712-1-yu-cheng.yu@intel.com> <20200205181935.3712-5-yu-cheng.yu@intel.com> <0bc74a85-7058-0cca-62b8-949c8a881c62@intel.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-doc-owner@vger.kernel.org To: Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , x86-patch-review@intel.com List-ID: Message-ID: <20200305204419.aqkzsai-i2bwVY6J3vtgELzjMGjizGtZLQxHuKbxhmo@z> On Wed, 2020-02-26 at 09:10 -0800, Dave Hansen wrote: > On 2/5/20 10:19 AM, Yu-cheng Yu wrote: > > diff --git a/arch/x86/kernel/idt.c b/arch/x86/kernel/idt.c > > index 87ef69a72c52..8ed406f469e7 100644 > > --- a/arch/x86/kernel/idt.c > > +++ b/arch/x86/kernel/idt.c > > @@ -102,6 +102,10 @@ static const __initconst struct idt_data def_idts[] = { > > #elif defined(CONFIG_X86_32) > > SYSG(IA32_SYSCALL_VECTOR, entry_INT80_32), > > #endif > > + > > +#ifdef CONFIG_X86_64 > > + INTG(X86_TRAP_CP, control_protection), > > +#endif > > }; > > This patch in particular appears to have all of its code unconditionally > compiled in. That's in contrast to things that have Kconfig options, like: > > #ifdef CONFIG_X86_MCE > INTG(X86_TRAP_MC, &machine_check), > #endif > > or: > > #ifdef CONFIG_X86_THERMAL_VECTOR > INTG(THERMAL_APIC_VECTOR, thermal_interrupt), > #endif > > Is there a reason this code is always compiled in on 64-bit even when > the config option is off? I will change it to CONFIG_X86_INTEL_CET. Yu-cheng