From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 3/3] Fix M68K irqflags Date: Fri, 03 Sep 2010 07:44:19 +0100 Message-ID: <7077.1283496259@redhat.com> References: <4C804F3A.8020001@snapgear.com> <19747.1283422807@redhat.com> <20100902102203.19806.39028.stgit@warthog.procyon.org.uk> Return-path: Received: from mx1.redhat.com ([209.132.183.28]:5222 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751432Ab0ICGof (ORCPT ); Fri, 3 Sep 2010 02:44:35 -0400 In-Reply-To: <4C804F3A.8020001@snapgear.com> Sender: linux-arch-owner@vger.kernel.org List-ID: To: Greg Ungerer Cc: dhowells@redhat.com, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Greg Ungerer wrote: > > - DEFINE(THREAD_SIZE, THREAD_SIZE); > > - > > This breaks final link due to missing THREAD_SIZE definition in head.S: > > LD vmlinux > arch/m68knommu/platform/coldfire/head.o: In function `_clear_bss': > (.head.text+0xa4): undefined reference to `THREAD_SIZE' > > > Without that asm-offsets.c change it works on my ColdFire boards. > I am happy with it: With that, I get a duplicate reference to THREAD_SIZE. head.S should include asm/thread_info.h rather than THREAD_SIZE being redefined in asm-offsets. CC init/do_mounts_rd.o In file included from /warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/asm-offsets.h:1, from arch/m68knommu/platform/coldfire/entry.S:36: include/generated/asm-offsets.h:46:1: warning: "THREAD_SIZE" redefined In file included from /warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/thread_info.h:2, from arch/m68knommu/platform/coldfire/entry.S:32: /warthog/nfs/linux-2.6-fscache/arch/m68k/include/asm/thread_info_no.h:27:1: warning: this is the location of the previous definition Unfortunately, I don't have a binutils that can handle the funny Coldfire instructions. Can you point me at a Coldfire toolchain? David