From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: "geert@linux-m68k.org" <geert@linux-m68k.org>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
"Alexey.Brodkin@synopsys.com" <Alexey.Brodkin@synopsys.com>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"greg@kroah.com" <greg@kroah.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [RESEND PATCH v2] devres: Really align data field to unsigned long long
Date: Mon, 9 Jul 2018 07:22:08 +0000 [thread overview]
Message-ID: <71dfb71de86ebe365897b2069bec0cb40b376928.camel@synopsys.com> (raw)
In-Reply-To: <CAMuHMdVBBu6gho_JVQTiOHxVFHqX2MUxS_c-6-x50OEu4OqpRQ@mail.gmail.com>
Hi Geert,
On Mon, 2018-07-09 at 09:07 +0200, Geert Uytterhoeven wrote:
> On Mon, Jul 9, 2018 at 7:49 AM Greg KH <greg@kroah.com> wrote:
> > On Mon, Jul 09, 2018 at 07:44:44AM +0300, Alexey Brodkin wrote:
> > > Depending on ABI "long long" type of a particular 32-bit CPU
> > > might be aligned by either word (32-bits) or double word (64-bits).
>
> Or even 16-bit (on e.g. m68k).
Indeed, thanks for the note!
Will add this in my v3.
For ARC I'd like this fix to be back-ported starting
from v4.8 where we added support of "native" atomic64_t, see commit
ce6365270ecd (" ARCv2: Implement atomic64 based on LLOCKD/SCONDD instructions").
What about m68k, do you have any preference of earliest kernel version
where this fix might be useful?
-Alexey
next prev parent reply other threads:[~2018-07-09 7:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-09 4:44 [RESEND PATCH v2] devres: Really align data field to unsigned long long Alexey Brodkin
2018-07-09 4:44 ` Alexey Brodkin
2018-07-09 5:48 ` Greg KH
2018-07-09 5:48 ` Greg KH
2018-07-09 6:46 ` Alexey Brodkin
2018-07-09 6:46 ` Alexey Brodkin
2018-07-09 7:06 ` greg
2018-07-09 7:06 ` greg
2018-07-09 7:17 ` Alexey Brodkin
2018-07-09 7:17 ` Alexey Brodkin
2018-07-09 7:33 ` greg
2018-07-09 7:33 ` greg
2018-07-09 7:07 ` Geert Uytterhoeven
2018-07-09 7:07 ` Geert Uytterhoeven
2018-07-09 7:22 ` Alexey Brodkin [this message]
2018-07-09 7:22 ` Alexey Brodkin
2018-07-09 7:52 ` Geert Uytterhoeven
2018-07-09 7:52 ` Geert Uytterhoeven
2018-07-09 8:37 ` Alexey Brodkin
2018-07-09 8:37 ` Alexey Brodkin
2018-07-09 9:03 ` Geert Uytterhoeven
2018-07-09 9:03 ` Geert Uytterhoeven
2018-07-09 9:16 ` David Laight
2018-07-09 9:16 ` David Laight
2018-07-09 9:23 ` Geert Uytterhoeven
2018-07-09 9:23 ` Geert Uytterhoeven
2018-07-09 9:54 ` David Laight
2018-07-09 9:54 ` David Laight
2018-07-09 9:59 ` Alexey Brodkin
2018-07-09 9:59 ` Alexey Brodkin
2018-07-09 10:18 ` David Laight
2018-07-09 10:18 ` David Laight
2018-07-09 10:23 ` Alexey Brodkin
2018-07-09 10:23 ` Alexey Brodkin
2018-07-09 18:27 ` Vineet Gupta
2018-07-09 18:27 ` Vineet Gupta
2018-07-10 6:42 ` Alexey Brodkin
2018-07-10 6:42 ` Alexey Brodkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71dfb71de86ebe365897b2069bec0cb40b376928.camel@synopsys.com \
--to=alexey.brodkin@synopsys.com \
--cc=geert@linux-m68k.org \
--cc=greg@kroah.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox