From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A8E771CC147; Fri, 6 Sep 2024 11:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725623579; cv=none; b=bK31wh/r2RLors3SGupwrfwC20rUpq6UZjSS0KD9MNe8pLeWU5k+x5tlKz9WNeX31OOjkAhZ3BVY3xsmCNHRO/MyTfokruvW2krCFl6YZal+HBoTbf8Y37hQ2wvRDO3Hellxd+JnHnnlPvh3nxwKFtp+jXiK05ay+eMu1Nqb+Dw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725623579; c=relaxed/simple; bh=IKrZnhFDxnXq31XmUBrR57Qz8ZUzXA7i1uyXXW3VBPQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TIO/zIzLEvLo5B9MmZqt/6kKq/Mxesu6zarXx1yNzWWFIrfCba+mx4HAfld6WUMF5FwER/5yHyywMNHfTbwT+RNycX0kOoIyvrSd30tm8M4+oBbVzTwG3WExTgEuvJFbgLHl603CIRDj/eFQ+P7VfvVBp6s8rFpQqS5q24wyqEw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 34291113E; Fri, 6 Sep 2024 04:53:24 -0700 (PDT) Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 612893F73B; Fri, 6 Sep 2024 04:52:54 -0700 (PDT) Message-ID: <72f3d6cf-a03b-4a16-9983-77d3dd70b0ea@arm.com> Date: Fri, 6 Sep 2024 12:52:52 +0100 Precedence: bulk X-Mailing-List: linux-arch@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 9/9] vdso: Modify getrandom to include the correct namespace To: Christophe Leroy , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Cc: Andy Lutomirski , Thomas Gleixner , "Jason A . Donenfeld" , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Ingo Molnar , Borislav Petkov , Dave Hansen , "H . Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers References: <20240903151437.1002990-1-vincenzo.frascino@arm.com> <20240903151437.1002990-10-vincenzo.frascino@arm.com> Content-Language: en-US From: Vincenzo Frascino In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 04/09/2024 18:26, Christophe Leroy wrote: > > > Le 03/09/2024 à 17:14, Vincenzo Frascino a écrit : ... > > Now build fails on powerpc because struct vgetrandom_opaque_params is unknown. > > x86 get it by chance via the following header inclusion chain: > > In file included from ./include/linux/random.h:10, >                  from ./include/linux/nodemask.h:98, >                  from ./include/linux/mmzone.h:18, >                  from ./include/linux/gfp.h:7, >                  from ./include/linux/xarray.h:16, >                  from ./include/linux/radix-tree.h:21, >                  from ./include/linux/idr.h:15, >                  from ./include/linux/kernfs.h:12, >                  from ./include/linux/sysfs.h:16, >                  from ./include/linux/kobject.h:20, >                  from ./include/linux/of.h:18, >                  from ./include/linux/clocksource.h:19, >                  from ./include/clocksource/hyperv_timer.h:16, >                  from ./arch/x86/include/asm/vdso/gettimeofday.h:21, >                  from ./include/vdso/datapage.h:164, >                  from arch/x86/entry/vdso/../../../../lib/vdso/getrandom.c:7, >                  from arch/x86/entry/vdso/vgetrandom.c:7: > > > > This tells me very little ;) Can you please provide more details? e.g. What is the error you are getting? How do I reproduce it? I am happy to include the required change as part of this series. Overall, the reason why I am doing this exercise it to sanitize the headers for all the architectures so that in future we do not have issues. It is good we find problems now. -- Regards, Vincenzo