From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
	by smtp.subspace.kernel.org (Postfix) with ESMTP id 6D6011C57AD;
	Thu, 10 Oct 2024 12:37:32 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1728563853; cv=none; b=dPsMpJREFH/EIt19MT9lpMeGDIlj7qOwO9mC+4ll5zTPCU7khUxXCHh78a/1v+ZmEyrZzprRO2yYMBHfQOmzVMm9jhwH+a5CQgs/tSRRq7p5WGDY6KSWzFk+wtJiMLxjtqBckJE2Wf4Nb3LMxLru+YvosP4Fg65E/ydcBZGaEu0=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1728563853; c=relaxed/simple;
	bh=yGivnwnfO1U8pvxO72Vtcwv1sibiLDu5yDY6sLoAjD4=;
	h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:
	 In-Reply-To:Content-Type; b=o4BIbYpOScErSsHjAf1+vqT0GDiNyS21bH3dElfEI+AuVp4bi5RkdInbKGlP0Y/8vOXQ6pdxWn2sT8wVfEnQeqdtHM/pQ1OSarFOEMTCTHr6GN2hspG3N7sY7ukC02WOk27/kTt7ysSfby2FB3vFJCmEzC4Rmj9J+HghmsTMZak=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73C78497;
	Thu, 10 Oct 2024 05:38:01 -0700 (PDT)
Received: from [10.1.196.72] (e119884-lin.cambridge.arm.com [10.1.196.72])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 3595B3F58B;
	Thu, 10 Oct 2024 05:37:29 -0700 (PDT)
Message-ID: <7433aee2-a2c3-43ae-8ebf-2d9e4f66cf56@arm.com>
Date: Thu, 10 Oct 2024 13:37:27 +0100
Precedence: bulk
X-Mailing-List: linux-arch@vger.kernel.org
List-Id: <linux-arch.vger.kernel.org>
List-Subscribe: <mailto:linux-arch+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-arch+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 2/2] vdso: Introduce vdso/page.h
To: Michael Ellerman <mpe@ellerman.id.au>,
 Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org,
 linux-arch@vger.kernel.org, linux-mm@kvack.org
Cc: Andy Lutomirski <luto@kernel.org>, "Jason A . Donenfeld"
 <Jason@zx2c4.com>, Christophe Leroy <christophe.leroy@csgroup.eu>,
 Nicholas Piggin <npiggin@gmail.com>, Naveen N Rao <naveen@kernel.org>,
 Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
 Dave Hansen <dave.hansen@linux.intel.com>, "H . Peter Anvin"
 <hpa@zytor.com>, Theodore Ts'o <tytso@mit.edu>, Arnd Bergmann
 <arnd@arndb.de>, Andrew Morton <akpm@linux-foundation.org>,
 Steven Rostedt <rostedt@goodmis.org>, Masami Hiramatsu
 <mhiramat@kernel.org>, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
References: <20241003152910.3287259-1-vincenzo.frascino@arm.com>
 <20241003152910.3287259-3-vincenzo.frascino@arm.com> <87wmihr49g.ffs@tglx>
 <87ttdlr3s5.ffs@tglx> <878quw7rrs.fsf@mail.lhotse>
Content-Language: en-US
From: Vincenzo Frascino <vincenzo.frascino@arm.com>
In-Reply-To: <878quw7rrs.fsf@mail.lhotse>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit



On 10/10/2024 00:58, Michael Ellerman wrote:
> Thomas Gleixner <tglx@linutronix.de> writes:
>> On Wed, Oct 09 2024 at 11:53, Thomas Gleixner wrote:
>>> On Thu, Oct 03 2024 at 16:29, Vincenzo Frascino wrote:
>>
>> Hit send too early.
>>
>>>> +#if defined(CONFIG_PHYS_ADDR_T_64BIT)
>>>> +#define PAGE_MASK	(~((1 << CONFIG_PAGE_SHIFT) - 1))
>>
>> This really wants a comment. The magic reliance on integer sign
>> expansion is any thing than obvious.
> 
> +1
> 
> Vincenzo feel free to take/modify the one from arch/powerpc/include/asm/page.h :)
> 

I will, thank you :)

> cheers

-- 
Regards,
Vincenzo