From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Howells Subject: Re: [PATCH 2/3] M68K: Use CONFIG_MMU not __uClinux__ to select m68knommu contributions Date: Fri, 03 Sep 2010 10:52:57 +0100 Message-ID: <7877.1283507577@redhat.com> References: <19747.1283422807@redhat.com> <20100902102158.19806.14133.stgit@warthog.procyon.org.uk> <3048.1283505520@redhat.com> <4C80C068.1010302@snapgear.com> Return-path: Received: from mx1.redhat.com ([209.132.183.28]:55538 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900Ab0ICJx1 (ORCPT ); Fri, 3 Sep 2010 05:53:27 -0400 In-Reply-To: Sender: linux-arch-owner@vger.kernel.org List-ID: To: Geert Uytterhoeven Cc: dhowells@redhat.com, Greg Ungerer , Andreas Schwab , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org Geert Uytterhoeven wrote: > > Not sure about m68k but m68knommu targets already setup > > appropriate -mcpu flags for its various supported CPU types. > > Same for m68k. It doesn't seem to: warthog>grep -r mcpu arch/m68k warthog1>grep -r mtune arch/m68k warthog1> I see that m68knommu does: warthog1>grep -r mcpu arch/m68knommu/ arch/m68knommu/Makefile:cflags-$(CONFIG_M5206) := $(call cc-option,-mcpu=5206,-m5200) arch/m68knommu/Makefile:cflags-$(CONFIG_M520x) := $(call cc-option,-mcpu=5208,-m5200) arch/m68knommu/Makefile:cflags-$(CONFIG_M523x) := $(call cc-option,-mcpu=523x,-m5307) ... I guess the m68k compiler I already had doesn't fully support -m5200, since I see that, but it doesn't compile some of the instructions when compiling the m68knommu defconfig (CONFIG_M520x=y). David