From: Markus Elfring <Markus.Elfring@web.de>
To: Matthias Maennich <maennich@google.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Martijn Coenen <maco@android.com>,
linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-modules@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, kernel-team@android.com,
usb-storage@lists.one-eyed-alien.net, x86@kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jessica Yu <jeyu@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Cameron <Jonathan.Cameron@hua>
Subject: Re: [v2 08/10] scripts: Coccinelle script for namespace dependencies
Date: Thu, 22 Aug 2019 13:00:52 +0200 [thread overview]
Message-ID: <796bc082-7708-172e-df1e-13447ef6b577@web.de> (raw)
In-Reply-To: <20190822091858.GA60652@google.com>
> $srctree is defined by kbuild in the toplevel Makefile.
How is this variable passed to the file “scripts/nsdeps”?
>> * Would you like to support a separate build directory for desired adjustments?
>
> No, as the purpose of this script is to directly patch the kernel
> sources where applicable.
Will there occasionally be a need to provide a generated patch
(without in-place file modification)?
>> I suggest to assign the name for the temporary file to a variable
>> which should be used by subsequent commands.
>
> I somehow don't agree that this is an improvement to the code as the
> variable would likely be something like ${source_file_tmp}.
Would you dare to choose a shorter variable name?
> ${source_file}.tmp does express the intent of a temporary file next to
> the original source file and the reader of the code does not need to
> reason about the value of ${source_file_tmp}.
I would find a code variant with less suffix repetition nicer.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Matthias Maennich <maennich@google.com>,
cocci@systeme.lip6.fr, kernel-janitors@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Julia Lawall <Julia.Lawall@lip6.fr>,
Martijn Coenen <maco@android.com>,
linux-arch@vger.kernel.org, linux-kbuild@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org,
linux-modules@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-usb@vger.kernel.org, kernel-team@android.com,
usb-storage@lists.one-eyed-alien.net, x86@kernel.org,
Alan Stern <stern@rowland.harvard.edu>,
Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Gilles Muller <Gilles.Muller@lip6.fr>,
"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@redhat.com>,
Jessica Yu <jeyu@kernel.org>,
Joel Fernandes <joel@joelfernandes.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
Martijn Coenen <maco@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Mauro Carvalho Chehab <mchehab+samsung@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Nicolas Palix <nicolas.palix@imag.fr>,
Oliver Neukum <oneukum@suse.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Sam Ravnborg <sam@ravnborg.org>,
Sandeep Patil <sspatil@google.com>,
Stephen Boyd <sboyd@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [v2 08/10] scripts: Coccinelle script for namespace dependencies
Date: Thu, 22 Aug 2019 13:00:52 +0200 [thread overview]
Message-ID: <796bc082-7708-172e-df1e-13447ef6b577@web.de> (raw)
Message-ID: <20190822110052.LvBZIs3qfsSjbpLDS2WPbgeTPKh97e_ZFtSA83IRR4U@z> (raw)
In-Reply-To: <20190822091858.GA60652@google.com>
> $srctree is defined by kbuild in the toplevel Makefile.
How is this variable passed to the file “scripts/nsdeps”?
>> * Would you like to support a separate build directory for desired adjustments?
>
> No, as the purpose of this script is to directly patch the kernel
> sources where applicable.
Will there occasionally be a need to provide a generated patch
(without in-place file modification)?
>> I suggest to assign the name for the temporary file to a variable
>> which should be used by subsequent commands.
>
> I somehow don't agree that this is an improvement to the code as the
> variable would likely be something like ${source_file_tmp}.
Would you dare to choose a shorter variable name?
> ${source_file}.tmp does express the intent of a temporary file next to
> the original source file and the reader of the code does not need to
> reason about the value of ${source_file_tmp}.
I would find a code variant with less suffix repetition nicer.
Regards,
Markus
next prev parent reply other threads:[~2019-08-22 11:00 UTC|newest]
Thread overview: 182+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 12:21 [PATCH 0/6] Symbol namespaces Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 1/6] export: explicitly align struct kernel_symbol Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 2/6] module: add support for symbol namespaces Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-19 16:32 ` Jessica Yu
2018-07-19 16:32 ` Jessica Yu
2018-07-20 7:54 ` Martijn Coenen
2018-07-20 7:54 ` Martijn Coenen
2018-07-20 14:49 ` Jessica Yu
2018-07-20 14:49 ` Jessica Yu
2018-07-20 15:42 ` Martijn Coenen
2018-07-20 15:42 ` Martijn Coenen
2018-07-23 11:12 ` Jessica Yu
2018-07-23 11:12 ` Jessica Yu
2018-07-24 7:44 ` Martijn Coenen
2018-07-24 7:44 ` Martijn Coenen
2018-07-24 7:56 ` Martijn Coenen
2018-07-24 7:56 ` Martijn Coenen
2018-07-25 15:55 ` Jessica Yu
2018-07-25 15:55 ` Jessica Yu
2018-07-25 16:48 ` Lucas De Marchi
2018-07-25 16:48 ` Lucas De Marchi
2018-07-26 7:44 ` Martijn Coenen
2018-07-26 7:44 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 3/6] modpost: add support for checking " Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 4/6] modpost: add support for generating namespace dependencies Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-23 6:49 ` Jessica Yu
2018-07-23 6:49 ` Jessica Yu
2018-07-16 12:21 ` [PATCH 5/6] scripts: Coccinelle script for " Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 12:21 ` [PATCH 6/6] RFC: USB: storage: move symbols into USB_STORAGE namespace Martijn Coenen
2018-07-16 12:21 ` Martijn Coenen
2018-07-16 15:33 ` [PATCH 0/6] Symbol namespaces Greg Kroah-Hartman
2018-07-16 15:33 ` Greg Kroah-Hartman
2018-07-23 14:28 ` Arnd Bergmann
2018-07-23 14:28 ` Arnd Bergmann
2018-07-24 8:09 ` Martijn Coenen
2018-07-24 8:09 ` Martijn Coenen
2018-07-24 9:08 ` Arnd Bergmann
2018-07-24 9:08 ` Arnd Bergmann
2019-08-13 12:16 ` [PATCH v2 0/10] Symbol namespaces - RFC Matthias Maennich
2019-08-13 12:16 ` Matthias Maennich
2019-08-13 12:16 ` [PATCH v2 01/10] module: support reading multiple values per modinfo tag Matthias Maennich
2019-08-13 12:16 ` Matthias Maennich
2019-08-13 12:40 ` Greg KH
2019-08-13 12:40 ` Greg KH
2019-08-13 12:16 ` [PATCH v2 02/10] export: explicitly align struct kernel_symbol Matthias Maennich
2019-08-13 12:16 ` Matthias Maennich
2019-08-13 12:41 ` Greg KH
2019-08-13 12:41 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 03/10] module: add support for symbol namespaces Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 15:26 ` Greg KH
2019-08-13 15:26 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 04/10] modpost: " Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 15:27 ` Greg KH
2019-08-13 15:27 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 05/10] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 18:17 ` Greg KH
2019-08-13 18:17 ` Greg KH
2019-08-13 20:15 ` Saravana Kannan
2019-08-13 20:15 ` Saravana Kannan
2019-08-14 12:54 ` Matthias Maennich
2019-08-14 12:54 ` Matthias Maennich
2019-08-14 17:34 ` Saravana Kannan
2019-08-14 17:34 ` Saravana Kannan
2019-08-13 12:17 ` [PATCH v2 06/10] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 18:16 ` Greg KH
2019-08-13 18:16 ` Greg KH
2019-08-13 18:16 ` Greg KH
2019-08-13 18:16 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 07/10] modpost: add support for generating namespace dependencies Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 18:21 ` Greg KH
2019-08-13 18:21 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 08/10] scripts: Coccinelle script for " Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 12:31 ` Julia Lawall
2019-08-13 12:31 ` Julia Lawall
2019-08-13 12:44 ` Greg KH
2019-08-13 12:44 ` Greg KH
2019-08-14 6:36 ` [Cocci] " Himanshu Jha
2019-08-14 6:36 ` Himanshu Jha
2019-08-14 8:03 ` Matthias Maennich
2019-08-14 8:03 ` Matthias Maennich
2019-08-14 12:00 ` [v2 " Markus Elfring
2019-08-14 12:00 ` Markus Elfring
2019-08-14 12:20 ` Matthias Maennich
2019-08-15 13:50 ` Markus Elfring
2019-08-15 13:50 ` Markus Elfring
2019-08-22 9:18 ` Matthias Maennich
2019-08-22 9:18 ` Matthias Maennich
2019-08-22 11:00 ` Markus Elfring [this message]
2019-08-22 11:00 ` Markus Elfring
2019-08-13 12:17 ` [PATCH v2 09/10] usb-storage: remove single-use define for debugging Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 12:42 ` Greg KH
2019-08-13 12:42 ` Greg KH
2019-08-13 13:12 ` Greg KH
2019-08-13 13:12 ` Greg KH
2019-08-13 12:17 ` [PATCH v2 10/10] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
2019-08-13 12:17 ` Matthias Maennich
2019-08-13 12:45 ` Greg KH
2019-08-13 12:45 ` Greg KH
2019-08-13 12:47 ` Greg KH
2019-08-13 12:47 ` Greg KH
2019-08-13 15:02 ` Matthias Maennich
2019-08-13 15:02 ` Matthias Maennich
[not found] ` <20190813121733.52480-1-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 11:49 ` [PATCH v3 00/11] Symbol Namespaces Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 01/11] module: support reading multiple values per modinfo tag Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 02/11] export: explicitly align struct kernel_symbol Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 03/11] module: add support for symbol namespaces Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-27 15:37 ` Jessica Yu
2019-08-27 15:37 ` Jessica Yu
2019-08-27 16:04 ` Matthias Maennich
2019-08-27 16:04 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 04/11] modpost: " Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-26 16:21 ` Jessica Yu
2019-08-26 16:21 ` Jessica Yu
2019-08-27 14:41 ` Matthias Maennich
2019-08-27 14:41 ` Matthias Maennich
2019-08-28 9:43 ` Jessica Yu
2019-08-28 9:43 ` Jessica Yu
2019-08-28 9:55 ` Matthias Maennich
2019-08-28 9:55 ` Matthias Maennich
2019-08-28 10:16 ` Jessica Yu
2019-08-28 10:16 ` Jessica Yu
2019-08-21 11:49 ` [PATCH v3 05/11] module: add config option MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 06/11] export: allow definition default namespaces in Makefiles or sources Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-28 10:49 ` Jessica Yu
2019-08-28 10:49 ` Jessica Yu
2019-08-28 10:56 ` Matthias Maennich
2019-08-28 10:56 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 07/11] modpost: add support for generating namespace dependencies Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 11:49 ` [PATCH v3 08/11] scripts: Coccinelle script for " Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-22 6:09 ` [v3 " Markus Elfring
2019-08-22 6:09 ` Markus Elfring
2019-08-29 12:13 ` [PATCH v3 " Jessica Yu
2019-08-29 12:13 ` Jessica Yu
2019-08-21 11:49 ` [PATCH v3 09/11] usb-storage: remove single-use define for debugging Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 12:37 ` Greg KH
2019-08-21 12:37 ` Greg KH
2019-08-21 13:21 ` Thomas Gleixner
2019-08-21 13:21 ` Thomas Gleixner
2019-08-21 13:32 ` Greg KH
2019-08-21 13:32 ` Greg KH
2019-08-21 11:49 ` [PATCH v3 10/11] RFC: usb-storage: export symbols in USB_STORAGE namespace Matthias Maennich
2019-08-21 11:49 ` Matthias Maennich
2019-08-21 12:38 ` Greg KH
2019-08-21 12:38 ` Greg KH
2019-08-21 14:36 ` Jessica Yu
2019-08-21 14:36 ` Jessica Yu
2019-08-21 23:13 ` Christoph Hellwig
2019-08-21 23:13 ` Christoph Hellwig
2019-08-22 8:32 ` Matthias Maennich
2019-08-22 8:32 ` Matthias Maennich
[not found] ` <20190821114955.12788-1-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 11:49 ` [PATCH v3 11/11] RFC: watchdog: export core symbols in WATCHDOG_CORE namespace Matthias Maennich
[not found] ` <20190821114955.12788-12-maennich-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2019-08-21 12:39 ` Greg KH
2019-08-21 14:59 ` Guenter Roeck
[not found] ` <20190821145911.GA6521-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2019-08-21 16:28 ` Matthias Maennich
2019-08-21 12:46 ` [PATCH v3 00/11] Symbol Namespaces Nicolas Pitre
[not found] ` <nycvar.YSQ.7.76.1908210840490.19480-fMhRO7WWcppj+hNMo8g0rg@public.gmane.org>
2019-08-21 13:37 ` Greg KH
[not found] ` <20190821133737.GB4890-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2019-08-21 20:48 ` Nicolas Pitre
2019-08-21 13:11 ` Peter Zijlstra
[not found] ` <20190821131140.GC2349-Nxj+rRp3nVydTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org>
2019-08-21 13:38 ` Greg KH
[not found] ` <20190821133846.GC4890-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2019-08-21 14:03 ` Matthias Maennich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=796bc082-7708-172e-df1e-13447ef6b577@web.de \
--to=markus.elfring@web.de \
--cc=Gilles.Muller@lip6.fr \
--cc=Jonathan.Cameron@hua \
--cc=Julia.Lawall@lip6.fr \
--cc=arnd@arndb.de \
--cc=cocci@systeme.lip6.fr \
--cc=davem@davemloft.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=jeyu@kernel.org \
--cc=joel@joelfernandes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=maco@android.com \
--cc=maennich@google.com \
--cc=mingo@redhat.com \
--cc=stern@rowland.harvard.edu \
--cc=usb-storage@lists.one-eyed-alien.net \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).