From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend Van Spriel Subject: Re: [GIT PULL] kbuild changes for v4.9-rc1 Date: Sun, 18 Dec 2016 12:03:34 +0100 Message-ID: <8311f14c-3d1e-6354-323a-87701cabaa97@broadcom.com> References: <20161017065131.GA27863@angband.pl> <20161017175951.31d8f4b7@roar.ozlabs.ibm.com> <20161017100130.GA16013@angband.pl> <7212667f-f508-2b41-a380-8f736814d8cc@suse.cz> <5ee08a93-6b17-d1c2-af1c-ab9aa218903c@suse.cz> <9dec52ac-dc82-73c5-6b36-b5eb7cc052fa@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9dec52ac-dc82-73c5-6b36-b5eb7cc052fa@suse.cz> Sender: linux-kbuild-owner@vger.kernel.org To: Jiri Slaby , Linus Torvalds Cc: Adam Borowski , Nicholas Piggin , Omar Sandoval , Michal Marek , Alexey Dobriyan , Stephen Rothwell , Al Viro , Linux Kbuild mailing list , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" List-Id: linux-arch.vger.kernel.org On 18-12-2016 11:49, Jiri Slaby wrote: > On 12/18/2016, 12:59 AM, Linus Torvalds wrote: >> On Sat, Dec 17, 2016 at 12:57 AM, Jiri Slaby wrote: >>> >>> Yes, disk drivers won't load: >>> [ 2.141973] virtio_pci: disagrees about version of symbol mcount >>> [ 2.144415] virtio_pci: Unknown symbol mcount (err -22) >> >> This makes no sense. >> >> mcount isn't even one of the symbols that the patch by Adam is touching. > > asm-prototypes.h in his patch includes asm/ftrace.h, where the function > is declared. That should be enough IIUC scripts/Makefile.build. > >> There's something else screwed up here. Not to mention that others >> don't have your issue. > > I suppose people don't run i386 kernels or have different config. > >> Do you have some other hacks in this area? Are you testing actual >> plain 4.9, or do you (for example) still carry Arnd's patch around >> that turned out to not work (reverted by f27c2f69cc8e in my tree)? > > Not at all. This was plain 4.9 packaged by suse -- only rpm-related > fixes. I tried plain 4.9 without rpm right now with the same output: > # insmod soundcore.ko > [ 31.582326] soundcore: disagrees about version of symbol mcount > [ 31.586183] soundcore: Unknown symbol mcount (err -22) > insmod: ERROR: could not insert module soundcore.ko: Invalid parameters I hit an mcount issue a while back (years?) which was due to building a driver with gcc v4.x while kernel was built using gcc v4.y. Not claiming that is your issue though. Regards, Arend From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com ([74.125.82.45]:35824 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759559AbcLRLDi (ORCPT ); Sun, 18 Dec 2016 06:03:38 -0500 Received: by mail-wm0-f45.google.com with SMTP id a197so71242437wmd.0 for ; Sun, 18 Dec 2016 03:03:37 -0800 (PST) Subject: Re: [GIT PULL] kbuild changes for v4.9-rc1 References: <20161017065131.GA27863@angband.pl> <20161017175951.31d8f4b7@roar.ozlabs.ibm.com> <20161017100130.GA16013@angband.pl> <7212667f-f508-2b41-a380-8f736814d8cc@suse.cz> <5ee08a93-6b17-d1c2-af1c-ab9aa218903c@suse.cz> <9dec52ac-dc82-73c5-6b36-b5eb7cc052fa@suse.cz> From: Arend Van Spriel Message-ID: <8311f14c-3d1e-6354-323a-87701cabaa97@broadcom.com> Date: Sun, 18 Dec 2016 12:03:34 +0100 MIME-Version: 1.0 In-Reply-To: <9dec52ac-dc82-73c5-6b36-b5eb7cc052fa@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-arch-owner@vger.kernel.org List-ID: To: Jiri Slaby , Linus Torvalds Cc: Adam Borowski , Nicholas Piggin , Omar Sandoval , Michal Marek , Alexey Dobriyan , Stephen Rothwell , Al Viro , Linux Kbuild mailing list , Linux Kernel Mailing List , "linux-arch@vger.kernel.org" Message-ID: <20161218110334.z7d_2pMbUdh2IvUgyMGjfEA8tTwyIHaroFtHPuglAO0@z> On 18-12-2016 11:49, Jiri Slaby wrote: > On 12/18/2016, 12:59 AM, Linus Torvalds wrote: >> On Sat, Dec 17, 2016 at 12:57 AM, Jiri Slaby wrote: >>> >>> Yes, disk drivers won't load: >>> [ 2.141973] virtio_pci: disagrees about version of symbol mcount >>> [ 2.144415] virtio_pci: Unknown symbol mcount (err -22) >> >> This makes no sense. >> >> mcount isn't even one of the symbols that the patch by Adam is touching. > > asm-prototypes.h in his patch includes asm/ftrace.h, where the function > is declared. That should be enough IIUC scripts/Makefile.build. > >> There's something else screwed up here. Not to mention that others >> don't have your issue. > > I suppose people don't run i386 kernels or have different config. > >> Do you have some other hacks in this area? Are you testing actual >> plain 4.9, or do you (for example) still carry Arnd's patch around >> that turned out to not work (reverted by f27c2f69cc8e in my tree)? > > Not at all. This was plain 4.9 packaged by suse -- only rpm-related > fixes. I tried plain 4.9 without rpm right now with the same output: > # insmod soundcore.ko > [ 31.582326] soundcore: disagrees about version of symbol mcount > [ 31.586183] soundcore: Unknown symbol mcount (err -22) > insmod: ERROR: could not insert module soundcore.ko: Invalid parameters I hit an mcount issue a while back (years?) which was due to building a driver with gcc v4.x while kernel was built using gcc v4.y. Not claiming that is your issue though. Regards, Arend