From: Julien Thierry <julien.thierry@arm.com>
To: James Morse <james.morse@arm.com>, linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, daniel.thompson@linaro.org,
joel@joelfernandes.org, marc.zyngier@arm.com,
christoffer.dall@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, mark.rutland@arm.com,
Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v9 01/26] arm64: Fix HCR.TGE status for NMI contexts
Date: Mon, 28 Jan 2019 15:42:42 +0000 [thread overview]
Message-ID: <847c54ef-ea41-eea5-8aff-72e0cea465f8@arm.com> (raw)
In-Reply-To: <8e8c4f5b-5b83-7bbc-1b84-36d68e210968@arm.com>
Hi James,
On 28/01/2019 11:48, James Morse wrote:
> Hi Julien,
>
> On 21/01/2019 15:33, Julien Thierry wrote:
>> When using VHE, the host needs to clear HCR_EL2.TGE bit in order
>> to interract with guest TLBs, switching from EL2&0 translation regime
>
> (interact)
>
>
>> to EL1&0.
>>
>> However, some non-maskable asynchronous event could happen while TGE is
>> cleared like SDEI. Because of this address translation operations
>> relying on EL2&0 translation regime could fail (tlb invalidation,
>> userspace access, ...).
>>
>> Fix this by properly setting HCR_EL2.TGE when entering NMI context and
>> clear it if necessary when returning to the interrupted context.
>
> Yes please. This would not have been fun to debug!
>
> Reviewed-by: James Morse <james.morse@arm.com>
>
>
Thanks.
>
> I was looking for why we need core code to do this, instead of updating the
> arch's call sites. Your 'irqdesc: Add domain handlers for NMIs' patch (pointed
> to from the cover letter) is the reason: core-code calls nmi_enter()/nmi_exit()
> itself.
>
Yes, that's the main reason.
>
>> diff --git a/arch/arm64/include/asm/hardirq.h b/arch/arm64/include/asm/hardirq.h
>> index 1473fc2..94b7481 100644
>> --- a/arch/arm64/include/asm/hardirq.h
>> +++ b/arch/arm64/include/asm/hardirq.h
>> @@ -19,6 +19,7 @@
>> #include <linux/cache.h>
>> #include <linux/threads.h>
>> #include <asm/irq.h>
>> +#include <asm/kvm_arm.h>
>
> percpu.h?
> sysreg.h?
> barrier.h?
>
Good point, I'll add those.
Thanks,
--
Julien Thierry
next prev parent reply other threads:[~2019-01-28 15:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1548084825-8803-1-git-send-email-julien.thierry@arm.com>
2019-01-21 15:33 ` [PATCH v9 01/26] arm64: Fix HCR.TGE status for NMI contexts Julien Thierry
2019-01-21 15:33 ` Julien Thierry
2019-01-23 22:57 ` Sasha Levin
2019-01-28 11:48 ` James Morse
2019-01-28 11:48 ` James Morse
2019-01-28 15:42 ` Julien Thierry [this message]
2019-01-28 15:42 ` Julien Thierry
2019-01-31 8:19 ` Christoffer Dall
2019-01-31 8:19 ` Christoffer Dall
2019-01-31 8:56 ` Julien Thierry
2019-01-31 8:56 ` Julien Thierry
2019-01-31 9:27 ` Christoffer Dall
2019-01-31 9:27 ` Christoffer Dall
2019-01-31 9:40 ` Julien Thierry
2019-01-31 9:40 ` Julien Thierry
2019-01-31 9:48 ` Christoffer Dall
2019-01-31 9:48 ` Christoffer Dall
2019-01-31 9:53 ` Marc Zyngier
2019-01-31 9:53 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=847c54ef-ea41-eea5-8aff-72e0cea465f8@arm.com \
--to=julien.thierry@arm.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=james.morse@arm.com \
--cc=joel@joelfernandes.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).