public inbox for linux-arch@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Thomas Garnier <thgarnie@google.com>,
	kernel-hardening@lists.openwall.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Christopher Li <sparse@chrisli.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Jason Baron <jbaron@akamai.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Lukas Wunner <lukas@wunner.de>, Kees Cook <keescook@chromium.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Mathieu
Subject: Re: [PATCH v5 15/27] compiler: Option to default to hidden symbols
Date: Mon, 25 Jun 2018 16:25:03 -0700	[thread overview]
Message-ID: <8486eb8b-e233-4e2f-e976-da7b4cefc673@infradead.org> (raw)
In-Reply-To: <20180625224014.134829-16-thgarnie@google.com>

On 06/25/18 15:39, Thomas Garnier wrote:
> Provide an option to default visibility to hidden except for key
> symbols. This option is disabled by default and will be used by x86_64
> PIE support to remove errors between compilation units.
> 
> The default visibility is also enabled for external symbols that are
> compared as they maybe equals (start/end of sections). In this case,
> older versions of GCC will remove the comparison if the symbols are
> hidden. This issue exists at least on gcc 4.9 and before.
> 
> Signed-off-by: Thomas Garnier <thgarnie@google.com>
> ---

> diff --git a/init/Kconfig b/init/Kconfig
> index 24b60536e26b..d4f90cc38ede 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1718,6 +1718,13 @@ config PROFILING
>  config TRACEPOINTS
>  	bool
>  
> +#
> +# Default to hidden visibility for all symbols.
> +# Useful for Position Independent Code to reduce global references.
> +#
> +config DEFAULT_HIDDEN
> +	bool
> +

I certainly would appreciate a better/more descriptive kconfig symbol name
here.

>  source "arch/Kconfig"
>  
>  endmenu		# General setup


thanks,
-- 
~Randy

WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: Thomas Garnier <thgarnie@google.com>,
	kernel-hardening@lists.openwall.com
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, Borislav Petkov <bp@alien8.de>,
	"Luis R. Rodriguez" <mcgrof@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Christopher Li <sparse@chrisli.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Jason Baron <jbaron@akamai.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Kate Stewart <kstewart@linuxfoundation.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Philippe Ombredanne <pombredanne@nexb.com>,
	Lukas Wunner <lukas@wunner.de>, Kees Cook <keescook@chromium.org>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	"Peter Zijlstra (Intel)" <peterz@infradead.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	linux-sparse@vger.kernel.org
Subject: Re: [PATCH v5 15/27] compiler: Option to default to hidden symbols
Date: Mon, 25 Jun 2018 16:25:03 -0700	[thread overview]
Message-ID: <8486eb8b-e233-4e2f-e976-da7b4cefc673@infradead.org> (raw)
Message-ID: <20180625232503.Li5X0tUkrJK_GZupmz9xp5sH4upwaCa6XLZoHyJiqb8@z> (raw)
In-Reply-To: <20180625224014.134829-16-thgarnie@google.com>

On 06/25/18 15:39, Thomas Garnier wrote:
> Provide an option to default visibility to hidden except for key
> symbols. This option is disabled by default and will be used by x86_64
> PIE support to remove errors between compilation units.
> 
> The default visibility is also enabled for external symbols that are
> compared as they maybe equals (start/end of sections). In this case,
> older versions of GCC will remove the comparison if the symbols are
> hidden. This issue exists at least on gcc 4.9 and before.
> 
> Signed-off-by: Thomas Garnier <thgarnie@google.com>
> ---

> diff --git a/init/Kconfig b/init/Kconfig
> index 24b60536e26b..d4f90cc38ede 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1718,6 +1718,13 @@ config PROFILING
>  config TRACEPOINTS
>  	bool
>  
> +#
> +# Default to hidden visibility for all symbols.
> +# Useful for Position Independent Code to reduce global references.
> +#
> +config DEFAULT_HIDDEN
> +	bool
> +

I certainly would appreciate a better/more descriptive kconfig symbol name
here.

>  source "arch/Kconfig"
>  
>  endmenu		# General setup


thanks,
-- 
~Randy

  parent reply	other threads:[~2018-06-25 23:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-25 22:38 [PATCH v5 00/27] x86: PIE support and option to extend KASLR randomization Thomas Garnier via Virtualization
2018-06-25 22:39 ` [PATCH v5 15/27] compiler: Option to default to hidden symbols Thomas Garnier
2018-06-25 22:39   ` Thomas Garnier
2018-06-25 23:25   ` Randy Dunlap [this message]
2018-06-25 23:25     ` Randy Dunlap
2018-06-25 22:39 ` [PATCH v5 24/27] x86/mm: Make the x86 GOT read-only Thomas Garnier
2018-06-25 22:39   ` Thomas Garnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8486eb8b-e233-4e2f-e976-da7b4cefc673@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=arnd@arndb.de \
    --cc=bp@alien8.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpa@zytor.com \
    --cc=jbaron@akamai.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=kstewart@linuxfoundation.org \
    --cc=lukas@wunner.de \
    --cc=mcgrof@kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=pombredanne@nexb.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rostedt@goodmis.org \
    --cc=sparse@chrisli.org \
    --cc=tglx@linutronix.de \
    --cc=thgarnie@google.com \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox