From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v8 01/26] arm64: Fix HCR.TGE status for NMI contexts Date: Mon, 28 Jan 2019 09:16:21 +0000 Message-ID: <86munlw3a2.wl-marc.zyngier@arm.com> References: <1546956464-48825-1-git-send-email-julien.thierry@arm.com> <1546956464-48825-2-git-send-email-julien.thierry@arm.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <1546956464-48825-2-git-send-email-julien.thierry@arm.com> Sender: linux-kernel-owner@vger.kernel.org To: Julien Thierry Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, daniel.thompson@linaro.org, joel@joelfernandes.org, christoffer.dall@arm.com, james.morse@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, Arnd Bergmann , linux-arch@vger.kernel.org, stable@vger.kernel.org List-Id: linux-arch.vger.kernel.org On Tue, 08 Jan 2019 14:07:19 +0000, Julien Thierry wrote: > > When using VHE, the host needs to clear HCR_EL2.TGE bit in order > to interract with guest TLBs, switching from EL2&0 translation regime > to EL1&0. > > However, some non-maskable asynchronous event could happen while TGE is > cleared like SDEI. Because of this address translation operations > relying on EL2&0 translation regime could fail (tlb invalidation, > userspace access, ...). > > Fix this by properly setting HCR_EL2.TGE when entering NMI context and > clear it if necessary when returning to the interrupted context. > > Signed-off-by: Julien Thierry > Suggested-by: Marc Zyngier > Cc: Arnd Bergmann > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: James Morse > Cc: linux-arch@vger.kernel.org > Cc: stable@vger.kernel.org Reviewed-by: Marc Zyngier Thanks, M. -- Jazz is not dead, it just smell funny. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from foss.arm.com ([217.140.101.70]:41516 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbfA1JQ0 (ORCPT ); Mon, 28 Jan 2019 04:16:26 -0500 Date: Mon, 28 Jan 2019 09:16:21 +0000 Message-ID: <86munlw3a2.wl-marc.zyngier@arm.com> From: Marc Zyngier Subject: Re: [PATCH v8 01/26] arm64: Fix HCR.TGE status for NMI contexts In-Reply-To: <1546956464-48825-2-git-send-email-julien.thierry@arm.com> References: <1546956464-48825-1-git-send-email-julien.thierry@arm.com> <1546956464-48825-2-git-send-email-julien.thierry@arm.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-arch-owner@vger.kernel.org List-ID: To: Julien Thierry Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, daniel.thompson@linaro.org, joel@joelfernandes.org, christoffer.dall@arm.com, james.morse@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, mark.rutland@arm.com, Arnd Bergmann , linux-arch@vger.kernel.org, stable@vger.kernel.org Message-ID: <20190128091621.9Wo2Q2KQLHqFA1JjVWZYp8riHbisxNuNsiCyD-nb63Q@z> On Tue, 08 Jan 2019 14:07:19 +0000, Julien Thierry wrote: > > When using VHE, the host needs to clear HCR_EL2.TGE bit in order > to interract with guest TLBs, switching from EL2&0 translation regime > to EL1&0. > > However, some non-maskable asynchronous event could happen while TGE is > cleared like SDEI. Because of this address translation operations > relying on EL2&0 translation regime could fail (tlb invalidation, > userspace access, ...). > > Fix this by properly setting HCR_EL2.TGE when entering NMI context and > clear it if necessary when returning to the interrupted context. > > Signed-off-by: Julien Thierry > Suggested-by: Marc Zyngier > Cc: Arnd Bergmann > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: James Morse > Cc: linux-arch@vger.kernel.org > Cc: stable@vger.kernel.org Reviewed-by: Marc Zyngier Thanks, M. -- Jazz is not dead, it just smell funny.